diff --git a/Dangerfile b/Dangerfile index 73789df7..b134a792 100644 --- a/Dangerfile +++ b/Dangerfile @@ -1,23 +1,33 @@ +#Check for changes to README.md +has_readme_changes = git.modified_files.include?("README.md") # Ensure there is a summary for a pull request fail 'Please provide a summary in the Pull Request description' if github.pr_body.length < 5 + +# Warn if pull request is not updated +warn 'Please update the Pull Request title to contain the script name' if github.pr_title.include? 'Update README.md' # Warn when there are merge commits in the diff warn 'Please rebase to get rid of the merge commits in this Pull Request' if git.commits.any? { |c| c.message =~ /^Merge branch 'master'/ } # Check links -require 'json' -results = File.read 'ab-results-README.md-markdown-table.json' -j = JSON.parse results -if j['error']==true +if has_readme_changes + require 'json' + results = File.read 'ab-results-README.md-markdown-table.json' + j = JSON.parse results + if j['error']==true fail j['title'] markdown j['message'] + end +end -# Check syntx -require 'json' -results = File.read 'syntaxcheck.json' -j = JSON.parse results -if j['error']==true +# Check syntax +if has_readme_changes + require 'json' + results = File.read 'syntaxcheck.json' + j = JSON.parse results + if j['error']==true fail j['title'] markdown j['message'] -end + end +end