refactor(app): name the feedback label helper refLabel

The reference parser uses issueRef as a reference kind.

Signed-off-by: bircni <bircni@icloud.com>
This commit is contained in:
bircni committed 2026-10-11 22:49:40 +02:00
1 parent 71189fd15f
commit 023724d4c9
2 files changed
+4 -4

No files matched your search

+2 -2
View File
@@ -162,8 +162,8 @@ func (a *application) printURL(cmd *cobra.Command, url string) error {
return err
}
// issueRef names an issue or pull request in feedback: "alice/x#5 (Fix login)".
func issueRef(repo string, number int64, title string) string {
// refLabel names an issue or pull request in feedback: "alice/x#5 (Fix login)".
func refLabel(repo string, number int64, title string) string {
return fmt.Sprintf("%s#%d (%s)", repo, number, title)
}
+2 -2
View File
@@ -363,7 +363,7 @@ func TestMutationFeedback(t *testing.T) {
deps.Streams.OutTTY = tc.tty
deps.Getenv = envFunc(map[string]string{"NO_COLOR": "1"})
a, cmd := outputApplication(deps, tc.json)
ref := issueRef("alice/x", 12, "Fix\x1b[2J login")
ref := refLabel("alice/x", 12, "Fix\x1b[2J login")
a.done(cmd, "Created issue %s", ref)
a.warn(cmd, "Issue %s is already closed", ref)
require.NoError(t, a.printURL(cmd, "https://example.org/12"))
@@ -387,7 +387,7 @@ func TestBatchDoneReportsEachSuccess(t *testing.T) {
return listed{Number: n, Title: fmt.Sprintf("Issue %d", n)}, nil
}
label := func(n int64) string { return fmt.Sprintf("#%d", n) }
report := func(item listed) string { return "Closed issue " + issueRef("alice/x", item.Number, item.Title) }
report := func(item listed) string { return "Closed issue " + refLabel("alice/x", item.Number, item.Title) }
for _, tc := range []struct {
name, json, out, stderr string
tty bool