Git/gitea-tea
1
0 Fork 0
mirror of https://gitea.com/gitea/tea.git synced 2026-10-26 11:01:25 +01:00
Code Issues Packages Projects Releases Wiki Activity

fix: address verified review findings (terminal-forms-1)

Browse Source 
Signed-off-by: bircni <bircni@icloud.com>
This commit is contained in:
bircni committed 2026-10-18 17:42:24 +02:00
1 parent caeed59bc6
commit 0910cf307a
21 files changed
+329 -53
Download Patch File Download Diff File Expand all files Collapse all files

No files matched your search

internal/app/pull_create_test.go
+13 -1
View File
@@ -49,7 +49,7 @@ func TestPullCreateAgitPushesToMatchingRemoteWithoutRemoteFlag(t *testing.T) {
switch {
case r.URL.Path == "/api/v1/repos/alice/project":
_, _ = w.Write([]byte(`{"full_name":"alice/project","default_branch":"main","permissions":{"push":true}}`))
case strings.HasPrefix(r.URL.Path, "/api/v1/repos/alice/project/raw/"):
case r.URL.Path == "/api/v1/orgs/alice", strings.HasPrefix(r.URL.Path, "/api/v1/repos/alice/project/raw/"):
w.WriteHeader(http.StatusNotFound)
case r.Method == http.MethodGet:
_, _ = w.Write([]byte(`[]`))
@@ -313,3 +313,15 @@ func TestCompareRefEscapesBranchNames(t *testing.T) {
require.Equal(t, "fix%2312", compareRef("fix#12"))
require.Equal(t, "bob:fix%25x", compareRef("bob:fix%x"))
}
func TestPullCreateRefusesHeadEqualToBaseBeforePushing(t *testing.T) {
creates := 0
deps, runner, _ := publishCreateEnv(t, &creates)
err := Execute(context.Background(), deps, []string{"pr", "create", "-R", "alice/project", "--title", "PR", "--head", "main", "--base", "main", "--no-input", "--yes"})
require.Equal(t, clierr.Usage, clierr.ExitCode(err))
require.ErrorContains(t, err, `must be on a branch named differently than "main"`)
require.Zero(t, creates)
for _, call := range runner.calls {
require.NotContains(t, call, "push")
}
}