Code Cleanup (#869)

- switch to golangci-lint for linting
- switch to gofmpt for formatting
- fix lint and fmt issues that came up from switch to new tools
- upgrade go-sdk to 0.23.2
- support pagination for listing tracked times
- remove `FixPullHeadSha` workaround (upstream fix has been merged for 5+ years at this point)
- standardize on US spelling (previously a mix of US&UK spelling)
- remove some unused code
- reduce some duplication in parsing state and issue type
- reduce some duplication in reading input for secrets and variables
- reduce some duplication with PR Review code
- report error for when yaml parsing fails
- various other misc cleanup

Reviewed-on: https://gitea.com/gitea/tea/pulls/869
Co-authored-by: techknowlogick <techknowlogick@gitea.com>
Co-committed-by: techknowlogick <techknowlogick@gitea.com>

cmd/flags/generic.go

@@ -141,3 +141,34 @@ var NotificationStateFlag = NewCsvFlag(
 func FieldsFlag(availableFields, defaultFields []string) *CsvFlag {
 	return NewCsvFlag("fields", "fields to print", []string{"f"}, availableFields, defaultFields)
 }
+
+// ParseState parses a state string and returns the corresponding gitea.StateType
+func ParseState(stateStr string) (gitea.StateType, error) {
+	switch stateStr {
+	case "all":
+		return gitea.StateAll, nil
+	case "", "open":
+		return gitea.StateOpen, nil
+	case "closed":
+		return gitea.StateClosed, nil
+	default:
+		return "", errors.New("unknown state '" + stateStr + "'")
+	}
+}
+
+// ParseIssueKind parses a kind string and returns the corresponding gitea.IssueType.
+// If kindStr is empty, returns the provided defaultKind.
+func ParseIssueKind(kindStr string, defaultKind gitea.IssueType) (gitea.IssueType, error) {
+	switch kindStr {
+	case "":
+		return defaultKind, nil
+	case "all":
+		return gitea.IssueTypeAll, nil
+	case "issue", "issues":
+		return gitea.IssueTypeIssue, nil
+	case "pull", "pulls", "pr":
+		return gitea.IssueTypePull, nil
+	default:
+		return "", errors.New("unknown kind '" + kindStr + "'")
+	}
+}

cmd/flags/generic_test.go

@@ -55,7 +55,7 @@ func TestPaginationFlags(t *testing.T) {
 			expectedPage:  2,
 			expectedLimit: 20,
 		},
-		{ //TODO: Should no paging be applied as -1 or a separate flag? It's not obvious that page=-1 turns off paging and limit is ignored
+		{ // TODO: Should no paging be applied as -1 or a separate flag? It's not obvious that page=-1 turns off paging and limit is ignored
 			name:          "no paging",
 			args:          []string{"test", "--limit", "20", "--page", "-1"},
 			expectedPage:  -1,
@@ -78,8 +78,8 @@ func TestPaginationFlags(t *testing.T) {
 			require.NoError(t, err)
 		})
 	}
-
 }
+
 func TestPaginationFailures(t *testing.T) {
 	cases := []struct {
 		name          string
@@ -102,7 +102,7 @@ func TestPaginationFailures(t *testing.T) {
 			expectedError: ErrPage,
 		},
 		{
-			//urfave does not validate all flags in one pass
+			// urfave does not validate all flags in one pass
 			name:          "negative paging and paging",
 			args:          []string{"test", "--page", "-2", "--limit", "-10"},
 			expectedError: ErrPage,