Code Cleanup (#869)

- switch to golangci-lint for linting
- switch to gofmpt for formatting
- fix lint and fmt issues that came up from switch to new tools
- upgrade go-sdk to 0.23.2
- support pagination for listing tracked times
- remove `FixPullHeadSha` workaround (upstream fix has been merged for 5+ years at this point)
- standardize on US spelling (previously a mix of US&UK spelling)
- remove some unused code
- reduce some duplication in parsing state and issue type
- reduce some duplication in reading input for secrets and variables
- reduce some duplication with PR Review code
- report error for when yaml parsing fails
- various other misc cleanup

Reviewed-on: https://gitea.com/gitea/tea/pulls/869
Co-authored-by: techknowlogick <techknowlogick@gitea.com>
Co-committed-by: techknowlogick <techknowlogick@gitea.com>

cmd/pulls/approve.go

@@ -4,16 +4,11 @@
 package pulls
 
 import (
-	"fmt"
-	"strings"
-
 	stdctx "context"
 
 	"code.gitea.io/sdk/gitea"
 	"code.gitea.io/tea/cmd/flags"
 	"code.gitea.io/tea/modules/context"
-	"code.gitea.io/tea/modules/task"
-	"code.gitea.io/tea/modules/utils"
 	"github.com/urfave/cli/v3"
 )
 
@@ -26,20 +21,7 @@ var CmdPullsApprove = cli.Command{
 	ArgsUsage:   "<pull index> [<comment>]",
 	Action: func(_ stdctx.Context, cmd *cli.Command) error {
 		ctx := context.InitCommand(cmd)
-		ctx.Ensure(context.CtxRequirement{RemoteRepo: true})
-
-		if ctx.Args().Len() == 0 {
-			return fmt.Errorf("Must specify a PR index")
-		}
-
-		idx, err := utils.ArgToIndex(ctx.Args().First())
-		if err != nil {
-			return err
-		}
-
-		comment := strings.Join(ctx.Args().Tail(), " ")
-
-		return task.CreatePullReview(ctx, idx, gitea.ReviewStateApproved, comment, nil)
+		return runPullReview(ctx, gitea.ReviewStateApproved, false)
 	},
 	Flags: flags.AllDefaultFlags,
 }

cmd/pulls/checkout.go

@@ -40,7 +40,7 @@ func runPullsCheckout(_ stdctx.Context, cmd *cli.Command) error {
 		RemoteRepo: true,
 	})
 	if ctx.Args().Len() != 1 {
-		return fmt.Errorf("Must specify a PR index")
+		return fmt.Errorf("pull request index is required")
 	}
 	idx, err := utils.ArgToIndex(ctx.Args().First())
 	if err != nil {

cmd/pulls/clean.go

@@ -35,7 +35,7 @@ func runPullsClean(_ stdctx.Context, cmd *cli.Command) error {
 	ctx := context.InitCommand(cmd)
 	ctx.Ensure(context.CtxRequirement{LocalRepo: true})
 	if ctx.Args().Len() != 1 {
-		return fmt.Errorf("Must specify a PR index")
+		return fmt.Errorf("pull request index is required")
 	}
 
 	idx, err := utils.ArgToIndex(ctx.Args().First())

cmd/pulls/close.go

@@ -19,7 +19,7 @@ var CmdPullsClose = cli.Command{
 	Description: `Change state of one or more pull requests to 'closed'`,
 	ArgsUsage:   "<pull index> [<pull index>...]",
 	Action: func(ctx context.Context, cmd *cli.Command) error {
-		var s = gitea.StateClosed
+		s := gitea.StateClosed
 		return editPullState(ctx, cmd, gitea.EditPullRequestOption{State: &s})
 	},
 	Flags: flags.AllDefaultFlags,

cmd/pulls/create.go

@@ -48,7 +48,7 @@ func runPullsCreate(_ stdctx.Context, cmd *cli.Command) error {
 	})
 
 	// no args -> interactive mode
-	if ctx.NumFlags() == 0 {
+	if ctx.IsInteractiveMode() {
 		if err := interact.CreatePull(ctx); err != nil && !interact.IsQuitting(err) {
 			return err
 		}

cmd/pulls/edit.go

@@ -20,7 +20,7 @@ func editPullState(_ stdctx.Context, cmd *cli.Command, opts gitea.EditPullReques
 	ctx := context.InitCommand(cmd)
 	ctx.Ensure(context.CtxRequirement{RemoteRepo: true})
 	if ctx.Args().Len() == 0 {
-		return fmt.Errorf("Please provide a Pull Request index")
+		return fmt.Errorf("pull request index is required")
 	}
 
 	indices, err := utils.ArgsToIndices(ctx.Args().Slice())

cmd/pulls/list.go

@@ -33,21 +33,15 @@ func RunPullsList(_ stdctx.Context, cmd *cli.Command) error {
 	ctx := context.InitCommand(cmd)
 	ctx.Ensure(context.CtxRequirement{RemoteRepo: true})
 
-	state := gitea.StateOpen
-	switch ctx.String("state") {
-	case "all":
-		state = gitea.StateAll
-	case "open":
-		state = gitea.StateOpen
-	case "closed":
-		state = gitea.StateClosed
+	state, err := flags.ParseState(ctx.String("state"))
+	if err != nil {
+		return err
 	}
 
 	prs, _, err := ctx.Login.Client().ListRepoPullRequests(ctx.Owner, ctx.Repo, gitea.ListPullRequestsOptions{
 		ListOptions: flags.GetListOptions(),
 		State:       state,
 	})
-
 	if err != nil {
 		return err
 	}

cmd/pulls/reject.go

@@ -5,15 +5,10 @@ package pulls
 
 import (
 	stdctx "context"
-	"fmt"
-	"strings"
-
-	"code.gitea.io/tea/cmd/flags"
-	"code.gitea.io/tea/modules/context"
-	"code.gitea.io/tea/modules/task"
-	"code.gitea.io/tea/modules/utils"
 
 	"code.gitea.io/sdk/gitea"
+	"code.gitea.io/tea/cmd/flags"
+	"code.gitea.io/tea/modules/context"
 	"github.com/urfave/cli/v3"
 )
 
@@ -25,20 +20,7 @@ var CmdPullsReject = cli.Command{
 	ArgsUsage:   "<pull index> <reason>",
 	Action: func(_ stdctx.Context, cmd *cli.Command) error {
 		ctx := context.InitCommand(cmd)
-		ctx.Ensure(context.CtxRequirement{RemoteRepo: true})
-
-		if ctx.Args().Len() < 2 {
-			return fmt.Errorf("Must specify a PR index and comment")
-		}
-
-		idx, err := utils.ArgToIndex(ctx.Args().First())
-		if err != nil {
-			return err
-		}
-
-		comment := strings.Join(ctx.Args().Tail(), " ")
-
-		return task.CreatePullReview(ctx, idx, gitea.ReviewStateRequestChanges, comment, nil)
+		return runPullReview(ctx, gitea.ReviewStateRequestChanges, true)
 	},
 	Flags: flags.AllDefaultFlags,
 }

cmd/pulls/reopen.go

@@ -20,7 +20,7 @@ var CmdPullsReopen = cli.Command{
 	Description: `Change state of one or more pull requests to 'open'`,
 	ArgsUsage:   "<pull index> [<pull index>...]",
 	Action: func(ctx context.Context, cmd *cli.Command) error {
-		var s = gitea.StateOpen
+		s := gitea.StateOpen
 		return editPullState(ctx, cmd, gitea.EditPullRequestOption{State: &s})
 	},
 	Flags: flags.AllDefaultFlags,

cmd/pulls/review_helpers.go

@@ -0,0 +1,40 @@
+// Copyright 2026 The Gitea Authors. All rights reserved.
+// SPDX-License-Identifier: MIT
+
+package pulls
+
+import (
+	"fmt"
+	"strings"
+
+	"code.gitea.io/sdk/gitea"
+	"code.gitea.io/tea/modules/context"
+	"code.gitea.io/tea/modules/task"
+	"code.gitea.io/tea/modules/utils"
+)
+
+// runPullReview handles the common logic for approving/rejecting pull requests
+func runPullReview(ctx *context.TeaContext, state gitea.ReviewStateType, requireComment bool) error {
+	ctx.Ensure(context.CtxRequirement{RemoteRepo: true})
+
+	minArgs := 1
+	if requireComment {
+		minArgs = 2
+	}
+
+	if ctx.Args().Len() < minArgs {
+		if requireComment {
+			return fmt.Errorf("pull request index and comment are required")
+		}
+		return fmt.Errorf("pull request index is required")
+	}
+
+	idx, err := utils.ArgToIndex(ctx.Args().First())
+	if err != nil {
+		return err
+	}
+
+	comment := strings.Join(ctx.Args().Tail(), " ")
+
+	return task.CreatePullReview(ctx, idx, state, comment, nil)
+}