Code Cleanup (#869)

- switch to golangci-lint for linting
- switch to gofmpt for formatting
- fix lint and fmt issues that came up from switch to new tools
- upgrade go-sdk to 0.23.2
- support pagination for listing tracked times
- remove `FixPullHeadSha` workaround (upstream fix has been merged for 5+ years at this point)
- standardize on US spelling (previously a mix of US&UK spelling)
- remove some unused code
- reduce some duplication in parsing state and issue type
- reduce some duplication in reading input for secrets and variables
- reduce some duplication with PR Review code
- report error for when yaml parsing fails
- various other misc cleanup

Reviewed-on: https://gitea.com/gitea/tea/pulls/869
Co-authored-by: techknowlogick <techknowlogick@gitea.com>
Co-committed-by: techknowlogick <techknowlogick@gitea.com>

cmd/times/list.go

@@ -65,6 +65,8 @@ Depending on your permissions on the repository, only your own tracked times mig
 			Usage:   "Show all times tracked by you across all repositories (overrides command arguments)",
 		},
 		timeFieldsFlag,
+		&flags.PaginationPageFlag,
+		&flags.PaginationLimitFlag,
 	}, flags.AllDefaultFlags...),
 }
 
@@ -92,11 +94,15 @@ func RunTimesList(_ stdctx.Context, cmd *cli.Command) error {
 		}
 	}
 
-	opts := gitea.ListTrackedTimesOptions{Since: from, Before: until}
+	opts := gitea.ListTrackedTimesOptions{
+		ListOptions: flags.GetListOptions(),
+		Since:       from,
+		Before:      until,
+	}
 
 	user := ctx.Args().First()
 	if ctx.Bool("mine") {
-		times, _, err = client.GetMyTrackedTimes()
+		times, _, err = client.ListMyTrackedTimes(opts)
 		fields = []string{"created", "repo", "issue", "duration"}
 	} else if user == "" {
 		// get all tracked times on the repo
@@ -104,9 +110,9 @@ func RunTimesList(_ stdctx.Context, cmd *cli.Command) error {
 		fields = []string{"created", "issue", "user", "duration"}
 	} else if strings.HasPrefix(user, "#") {
 		// get all tracked times on the specified issue
-		issue, err := utils.ArgToIndex(user)
-		if err != nil {
-			return err
+		issue, parseErr := utils.ArgToIndex(user)
+		if parseErr != nil {
+			return parseErr
 		}
 		times, _, err = client.ListIssueTrackedTimes(ctx.Owner, ctx.Repo, issue, opts)
 		fields = []string{"created", "user", "duration"}