Code Cleanup (#869)

- switch to golangci-lint for linting
- switch to gofmpt for formatting
- fix lint and fmt issues that came up from switch to new tools
- upgrade go-sdk to 0.23.2
- support pagination for listing tracked times
- remove `FixPullHeadSha` workaround (upstream fix has been merged for 5+ years at this point)
- standardize on US spelling (previously a mix of US&UK spelling)
- remove some unused code
- reduce some duplication in parsing state and issue type
- reduce some duplication in reading input for secrets and variables
- reduce some duplication with PR Review code
- report error for when yaml parsing fails
- various other misc cleanup

Reviewed-on: https://gitea.com/gitea/tea/pulls/869
Co-authored-by: techknowlogick <techknowlogick@gitea.com>
Co-committed-by: techknowlogick <techknowlogick@gitea.com>

modules/interact/pull_merge.go

@@ -19,7 +19,7 @@ import (
 // MergePull interactively creates a PR
 func MergePull(ctx *context.TeaContext) error {
 	if ctx.LocalRepo == nil {
-		return fmt.Errorf("Must specify a PR index")
+		return fmt.Errorf("pull request index is required")
 	}
 
 	branch, _, err := ctx.LocalRepo.TeaGetCurrentBranchNameAndSHA()
@@ -51,9 +51,12 @@ func getPullIndex(ctx *context.TeaContext, branch string) (int64, error) {
 
 	// paginated fetch
 	var prs []*gitea.PullRequest
-	var err error
 	for {
+		var err error
 		prs, _, err = c.ListRepoPullRequests(ctx.Owner, ctx.Repo, opts)
+		if err != nil {
+			return 0, err
+		}
 		if len(prs) == 0 {
 			return 0, fmt.Errorf("No open PRs found")
 		}