Code Cleanup (#869)

- switch to golangci-lint for linting
- switch to gofmpt for formatting
- fix lint and fmt issues that came up from switch to new tools
- upgrade go-sdk to 0.23.2
- support pagination for listing tracked times
- remove `FixPullHeadSha` workaround (upstream fix has been merged for 5+ years at this point)
- standardize on US spelling (previously a mix of US&UK spelling)
- remove some unused code
- reduce some duplication in parsing state and issue type
- reduce some duplication in reading input for secrets and variables
- reduce some duplication with PR Review code
- report error for when yaml parsing fails
- various other misc cleanup

Reviewed-on: https://gitea.com/gitea/tea/pulls/869
Co-authored-by: techknowlogick <techknowlogick@gitea.com>
Co-committed-by: techknowlogick <techknowlogick@gitea.com>

modules/task/login_create.go

@@ -51,7 +51,7 @@ func CreateLogin(name, token, user, passwd, otp, scopes, sshKey, giteaURL, sshCe
 	// checks ...
 	// ... if we have a url
 	if len(giteaURL) == 0 {
-		return fmt.Errorf("You have to input Gitea server URL")
+		return fmt.Errorf("Gitea server URL is required")
 	}
 
 	// ... if there already exist a login with same name

modules/task/milestone_create.go

@@ -15,7 +15,6 @@ import (
 
 // CreateMilestone creates a milestone in the given repo and prints the result
 func CreateMilestone(login *config.Login, repoOwner, repoName, title, description string, deadline *time.Time, state gitea.StateType) error {
-
 	// title is required
 	if len(title) == 0 {
 		return fmt.Errorf("Title is required")

modules/task/pull_checkout.go

@@ -9,7 +9,6 @@ import (
 	"code.gitea.io/sdk/gitea"
 	"code.gitea.io/tea/modules/config"
 	local_git "code.gitea.io/tea/modules/git"
-	"code.gitea.io/tea/modules/workaround"
 
 	"github.com/go-git/go-git/v5"
 	git_config "github.com/go-git/go-git/v5/config"
@@ -29,9 +28,6 @@ func PullCheckout(
 	if err != nil {
 		return fmt.Errorf("couldn't fetch PR: %s", err)
 	}
-	if err := workaround.FixPullHeadSha(client, pr); err != nil {
-		return err
-	}
 
 	// FIXME: should use ctx.LocalRepo..?
 	localRepo, err := local_git.RepoForWorkdir()

modules/task/pull_clean.go

@@ -8,7 +8,6 @@ import (
 
 	"code.gitea.io/tea/modules/config"
 	local_git "code.gitea.io/tea/modules/git"
-	"code.gitea.io/tea/modules/workaround"
 
 	"code.gitea.io/sdk/gitea"
 	git_config "github.com/go-git/go-git/v5/config"
@@ -33,9 +32,6 @@ func PullClean(login *config.Login, repoOwner, repoName string, index int64, ign
 	if err != nil {
 		return err
 	}
-	if err := workaround.FixPullHeadSha(client, pr); err != nil {
-		return err
-	}
 
 	if pr.State == gitea.StateOpen {
 		return fmt.Errorf("PR is still open, won't delete branches")
@@ -96,15 +92,15 @@ call me again with the --ignore-sha flag`, remoteBranch)
 
 	if !remoteDeleted && pr.Head.Repository.Permissions.Push {
 		fmt.Printf("Deleting remote branch %s\n", remoteBranch)
-		url, err := r.TeaRemoteURL(branch.Remote)
-		if err != nil {
-			return err
+		url, urlErr := r.TeaRemoteURL(branch.Remote)
+		if urlErr != nil {
+			return urlErr
 		}
-		auth, err := local_git.GetAuthForURL(url, login.Token, login.SSHKey, callback)
-		if err != nil {
-			return err
+		auth, authErr := local_git.GetAuthForURL(url, login.Token, login.SSHKey, callback)
+		if authErr != nil {
+			return authErr
 		}
-		err = r.TeaDeleteRemoteBranch(branch.Remote, remoteBranch, auth)
+		return r.TeaDeleteRemoteBranch(branch.Remote, remoteBranch, auth)
 	}
-	return err
+	return nil
 }

modules/task/repo_clone.go

@@ -40,7 +40,7 @@ func RepoClone(
 		return nil, err
 	}
 
-	// default path behaviour as native git
+	// default path behavior as native git
 	if path == "" {
 		path = repoName
 	}