Code Cleanup (#869)

- switch to golangci-lint for linting
- switch to gofmpt for formatting
- fix lint and fmt issues that came up from switch to new tools
- upgrade go-sdk to 0.23.2
- support pagination for listing tracked times
- remove `FixPullHeadSha` workaround (upstream fix has been merged for 5+ years at this point)
- standardize on US spelling (previously a mix of US&UK spelling)
- remove some unused code
- reduce some duplication in parsing state and issue type
- reduce some duplication in reading input for secrets and variables
- reduce some duplication with PR Review code
- report error for when yaml parsing fails
- various other misc cleanup

Reviewed-on: https://gitea.com/gitea/tea/pulls/869
Co-authored-by: techknowlogick <techknowlogick@gitea.com>
Co-committed-by: techknowlogick <techknowlogick@gitea.com>

modules/utils/input.go

@@ -0,0 +1,87 @@
+// Copyright 2026 The Gitea Authors. All rights reserved.
+// SPDX-License-Identifier: MIT
+
+package utils
+
+import (
+	"bufio"
+	"fmt"
+	"io"
+	"os"
+	"strings"
+	"syscall"
+
+	"github.com/urfave/cli/v3"
+	"golang.org/x/term"
+)
+
+// ReadValueOptions contains options for reading a value from various sources
+type ReadValueOptions struct {
+	// ResourceName is the name of the resource (e.g., "secret", "variable")
+	ResourceName string
+	// PromptMsg is the message to display when prompting interactively
+	PromptMsg string
+	// Hidden determines if the input should be hidden (for secrets/passwords)
+	Hidden bool
+	// AllowEmpty determines if empty values are allowed
+	AllowEmpty bool
+}
+
+// ReadValue reads a value from various sources in the following priority order:
+// 1. From a file specified by --file flag
+// 2. From stdin if --stdin flag is set
+// 3. From command arguments (second argument)
+// 4. Interactive prompt
+func ReadValue(cmd *cli.Command, opts ReadValueOptions) (string, error) {
+	var value string
+
+	// 1. Read from file
+	if filePath := cmd.String("file"); filePath != "" {
+		content, err := os.ReadFile(filePath)
+		if err != nil {
+			return "", fmt.Errorf("failed to read file: %w", err)
+		}
+		value = strings.TrimSpace(string(content))
+	} else if cmd.Bool("stdin") {
+		// 2. Read from stdin
+		content, err := io.ReadAll(os.Stdin)
+		if err != nil {
+			return "", fmt.Errorf("failed to read from stdin: %w", err)
+		}
+		value = strings.TrimSpace(string(content))
+	} else if cmd.Args().Len() >= 2 {
+		// 3. Use provided argument
+		value = cmd.Args().Get(1)
+	} else {
+		// 4. Interactive prompt
+		if opts.PromptMsg == "" {
+			opts.PromptMsg = fmt.Sprintf("Enter %s value", opts.ResourceName)
+		}
+		fmt.Printf("%s: ", opts.PromptMsg)
+
+		if opts.Hidden {
+			// Hidden input for secrets/passwords
+			byteValue, err := term.ReadPassword(int(syscall.Stdin))
+			if err != nil {
+				return "", fmt.Errorf("failed to read %s value: %w", opts.ResourceName, err)
+			}
+			fmt.Println() // Add newline after hidden input
+			value = string(byteValue)
+		} else {
+			// Regular visible input - read entire line including spaces
+			reader := bufio.NewReader(os.Stdin)
+			input, err := reader.ReadString('\n')
+			if err != nil {
+				return "", fmt.Errorf("failed to read %s value: %w", opts.ResourceName, err)
+			}
+			value = strings.TrimSpace(input)
+		}
+	}
+
+	// Validate non-empty if required
+	if !opts.AllowEmpty && value == "" {
+		return "", fmt.Errorf("%s value cannot be empty", opts.ResourceName)
+	}
+
+	return value, nil
+}

modules/utils/path.go

@@ -62,9 +62,9 @@ func AbsPathWithExpansion(p string) (string, error) {
 	}
 	if p == "~" {
 		return u.HomeDir, nil
-	} else if strings.HasPrefix(p, "~/") {
-		return filepath.Join(u.HomeDir, p[2:]), nil
-	} else {
-		return filepath.Abs(p)
 	}
+	if strings.HasPrefix(p, "~/") {
+		return filepath.Join(u.HomeDir, p[2:]), nil
+	}
+	return filepath.Abs(p)
 }