mirror of
https://gitea.com/gitea/tea.git
synced 2026-10-26 11:01:25 +01:00
refactor: load settings once per run and reuse shared helpers
The application caches the settings snapshot and reloads it only after an update through the store, so output and prompt helpers no longer read and parse config.yml and hosts.yml several times per command. canPrompt and chooser replace the inline prompt-policy checks. Checks are tallied by one services.Tally, terminal.Plural replaces the two app copies, refKind.article/noun replace the comment group's own words, list commands use servicePage, and web URLs are built by repositoryURL and webURL in browser.go. Signed-off-by: bircni <bircni@icloud.com>
This commit is contained in:
42 files changed
+157
-204
No files matched your search
@@ -200,17 +200,7 @@ func reviewerSummary(item services.Pull, reviews []services.Review) string {
|
||||
|
||||
// checkSummary counts checks by outcome: "1 failing, 2 pending, 3 successful", or "" without checks.
|
||||
func checkSummary(checks []services.Check) string {
|
||||
var failing, pending, passed int
|
||||
for _, check := range checks {
|
||||
switch {
|
||||
case check.Pending():
|
||||
pending++
|
||||
case check.Passed():
|
||||
passed++
|
||||
default:
|
||||
failing++
|
||||
}
|
||||
}
|
||||
failing, pending, passed := services.Tally(checks)
|
||||
var parts []string
|
||||
for _, count := range []struct {
|
||||
n int
|
||||
@@ -315,13 +305,13 @@ func (a *application) writeDiscussion(cmd *cobra.Command, target target, v discu
|
||||
_, err := fmt.Fprint(cmd.OutOrStdout(), b.String())
|
||||
return err
|
||||
}
|
||||
view.Meta = v.summary(now) + " • " + plural(int(v.comments), "comment")
|
||||
view.Meta = v.summary(now) + " • " + terminal.Plural(int(v.comments), "comment")
|
||||
view.URL = ""
|
||||
muted := func(text string) string { return terminal.Colorize("muted", text, d.Color) }
|
||||
var b strings.Builder
|
||||
b.WriteString(view.Render(d))
|
||||
if !withComments && v.comments > 0 {
|
||||
b.WriteString("\n" + muted(plural(int(v.comments), "comment")+" — use --comments to view them") + "\n")
|
||||
b.WriteString("\n" + muted(terminal.Plural(int(v.comments), "comment")+" — use --comments to view them") + "\n")
|
||||
}
|
||||
for _, comment := range comments {
|
||||
heading := []string{terminal.Emphasis(terminal.SafeLine(comment.author), d.Color)}
|
||||
@@ -346,10 +336,3 @@ func (a *application) writeDiscussion(cmd *cobra.Command, target target, v discu
|
||||
b.WriteString("\n" + muted("View this "+v.view.Kind+" on Gitea: "+terminal.SafeLine(v.view.URL)) + "\n")
|
||||
return a.writeHuman(cmd, b.String())
|
||||
}
|
||||
|
||||
func plural(n int, unit string) string {
|
||||
if n == 1 {
|
||||
return "1 " + unit
|
||||
}
|
||||
return fmt.Sprintf("%d %ss", n, unit)
|
||||
}
|
||||
Reference in new issue
Block a user