Git/gitea-tea
1
0 Fork 0
mirror of https://gitea.com/gitea/tea.git synced 2026-10-26 19:11:25 +01:00
Code Issues Packages Projects Releases Wiki Activity

fix: seed issue create from --template, edit and delete inline review comments, explain workflow run refs (follow gh)

Browse Source 
Signed-off-by: bircni <bircni@icloud.com>
This commit is contained in:
bircni committed 2026-10-18 18:58:28 +02:00
1 parent 0db9ed463e
commit 2a221d0a81
9 files changed
+122 -21
Download Patch File Download Diff File Expand all files Collapse all files

No files matched your search

internal/app/comments_test.go
+30
View File
@@ -192,3 +192,33 @@ func TestViewCommentsCannotBeCombinedWithJSON(t *testing.T) {
require.ErrorContains(t, err, "tea pr review list <number> --json")
require.Empty(t, out.String())
}
func TestCommentEditAndDeleteReachInlineReviewComments(t *testing.T) {
var calls []string
server := newAuthenticatedServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
calls = append(calls, r.Method+" "+r.URL.Path)
switch r.Method + " " + r.URL.Path {
case "GET /api/v1/repos/alice/project/issues/comments/40":
w.WriteHeader(http.StatusNoContent) // Gitea's answer for inline review comments
case "PATCH /api/v1/repos/alice/project/issues/comments/40":
require.Equal(t, "Fixed", payloadField(t, r, "body"))
_, _ = w.Write([]byte(`{"id":40,"body":"Fixed"}`))
case "DELETE /api/v1/repos/alice/project/issues/comments/40":
w.WriteHeader(http.StatusNoContent)
default:
t.Errorf("unexpected %s %s", r.Method, r.URL.Path)
w.WriteHeader(http.StatusNotFound)
}
}))
defer server.Close()
deps, _, _ := serverDeps(t, server.URL)
run := func(args ...string) error {
return Execute(context.Background(), deps, append([]string{"pr", "comment"}, append(args, "-R", "alice/project", "--no-input")...))
}
require.NoError(t, run("edit", "40", "--body", "Fixed"))
require.NoError(t, run("delete", "40", "--yes"))
require.Contains(t, calls, "PATCH /api/v1/repos/alice/project/issues/comments/40")
require.Contains(t, calls, "DELETE /api/v1/repos/alice/project/issues/comments/40")
// Viewing still explains why an inline review comment cannot be shown.
require.ErrorContains(t, run("view", "40"), "not a plain comment")
}