fix(wiki): list every page without stopping at an empty window

Signed-off-by: bircni <bircni@icloud.com>

internal/services/wiki.go

@@ -7,6 +7,7 @@ import (
 	"context"
 	"encoding/base64"
 	"fmt"
+	"net/http"
 	"strconv"
 
 	gitea "gitea.dev/sdk"
@@ -83,16 +84,27 @@ func (s Wiki) page(ctx context.Context, op repoOperation[*gitea.WikiPage]) (Wiki
 // default page size.
 const wikiPageSize = 50
 
-// ListPage lists a page of wiki pages, with whether more follow and how many there are. It reads
+// ListPage lists a page of wiki pages, with whether more follow and, when the whole wiki was read,
-// the whole page list and pages it on the client, because the server pages it inconsistently.
+// how many there are. Gitea windows the wiki's files, not its pages: a window holds fewer pages
+// than its size, or none, while later windows still hold pages. The windows are read in order
+// while the server links a next one, until one page past the requested page is found.
 func (s Wiki) ListPage(ctx context.Context, limit, page int) (Page[WikiPage], error) {
-	all, err := listAll(func(page int) ([]*gitea.WikiPageMetaData, error) {
+	if limit < 1 || page < 1 {
-		return repoCall(ctx, s.Client, s.Repository, func(ctx context.Context, c *gitea.Client, owner, repo string) ([]*gitea.WikiPageMetaData, *gitea.Response, error) {
+		return Page[WikiPage]{}, fmt.Errorf("limit and page must be positive")
-			return c.Wiki.ListPages(ctx, owner, repo, gitea.ListWikiPagesOptions{ListOptions: listOptions(wikiPageSize, page)})
+	}
-		})
+	all, wanted := []WikiPage{}, page*limit
+	for window := 1; ; window++ {
+		if window > maxListPages {
+			return Page[WikiPage]{}, fmt.Errorf("listing exceeded %d pages", maxListPages)
+		}
+		var headers http.Header
+		items, err := repoCall(ctx, s.Client, s.Repository, func(ctx context.Context, c *gitea.Client, owner, repo string) ([]*gitea.WikiPageMetaData, *gitea.Response, error) {
+			items, resp, err := c.Wiki.ListPages(ctx, owner, repo, gitea.ListWikiPagesOptions{ListOptions: listOptions(wikiPageSize, window)})
+			headers = headerOf(resp)
+			return items, resp, err
 		})
 		if err != nil {
-		if !IsNotFound(err) {
+			if window > 1 || !IsNotFound(err) {
 				return Page[WikiPage]{}, err
 			}
 			// An uninitialized wiki returns 404. Verify repository visibility and
@@ -106,9 +118,18 @@ func (s Wiki) ListPage(ctx context.Context, limit, page int) (Page[WikiPage], er
 			}
 			return Page[WikiPage]{Items: []WikiPage{}, Counted: true}, nil
 		}
-	items, err := pageOf(convertAll(all, func(item *gitea.WikiPageMetaData) WikiPage {
+		all = append(all, convertAll(items, func(item *gitea.WikiPageMetaData) WikiPage {
 			return wikiPageFrom(item.Title, item.HTMLURL, item.LastCommit)
-	}), limit, page)
+		})...)
+		if next, _, _ := pageHints(headers); !next {
+			break
+		}
+		if len(all) >= wanted {
+			items, err := pageOf(all, limit, page)
+			return Page[WikiPage]{Items: items, More: true}, err
+		}
+	}
+	items, err := pageOf(all, limit, page)
 	return Page[WikiPage]{Items: items, More: page*limit < len(all), Total: len(all), Counted: true}, err
 }