fix: tighten error classification and pull request selection

Only Gitea's archived-repository messages mean the repository is archived,
so an archived label is no longer reported as one. Refused POSTs to the
organization, team, user and SSH key collections name the resource they would
have created, and the existing pull request is looked up with escaped branch
names.

pullSelector without an argument refuses an explicit --repo, like gh: the
checked-out branch says nothing about another repository.

Signed-off-by: bircni <bircni@icloud.com>

internal/app/ref.go

@@ -74,11 +74,14 @@ func parseRefURL(raw string, kind refKind) (ref, error) {
 		return ref{}, invalid
 	}
 	segments := strings.Split(strings.Trim(u.Path, "/"), "/")
-	positive := func(i int) int64 {
-		if i >= len(segments) {
-			return 0
+	at := func(i int) string {
+		if i < len(segments) {
+			return segments[i]
 		}
-		n, err := strconv.ParseInt(segments[i], 10, 64)
+		return ""
+	}
+	positive := func(i int) int64 {
+		n, err := strconv.ParseInt(at(i), 10, 64)
 		if err != nil || n < 1 {
 			return 0
 		}
@@ -88,12 +91,12 @@ func parseRefURL(raw string, kind refKind) (ref, error) {
 	for i := 2; i < len(segments); i++ {
 		result := ref{}
 		switch {
-		case kind == runRef && segments[i] == "actions" && i+2 < len(segments) && segments[i+1] == "runs" && positive(i+2) > 0:
+		case kind == runRef && at(i) == "actions" && at(i+1) == "runs" && positive(i+2) > 0:
 			result.Number = positive(i + 2)
-			if i+4 < len(segments) && segments[i+3] == "jobs" {
+			if at(i+3) == "jobs" {
 				result.Job = positive(i + 4)
 			}
-		case kind != runRef && (segments[i] == "issues" || segments[i] == "pulls") && positive(i+1) > 0:
+		case kind != runRef && (at(i) == "issues" || at(i) == "pulls") && positive(i+1) > 0:
 			result.Number = positive(i + 1)
 		default:
 			continue
@@ -188,6 +191,10 @@ func (a *application) sameRepository(first, second string) bool {
 // checked-out branch.
 func (a *application) pullSelector(cmd *cobra.Command, args []string) (target, int64, error) {
 	if len(args) == 0 || args[0] == "" {
+		// The checked-out branch says nothing about a repository chosen with --repo.
+		if a.options.repo != "" {
+			return target{}, 0, clierr.Wrap(clierr.Usage, errors.New("pass a pull request number, URL or branch with --repo"))
+		}
 		return a.currentPull(cmd.Context())
 	}
 	raw := args[0]