mirror of
				https://gitea.com/gitea/tea.git
				synced 2025-10-31 09:15:26 +01:00 
			
		
		
		
	feat: add actions management commands (#796)
## Summary This PR adds comprehensive Actions secrets and variables management functionality to the tea CLI, enabling users to manage their repository's CI/CD configuration directly from the command line. ## Features Added ### Actions Secrets Management - **List secrets**: `tea actions secrets list` - Display all repository action secrets - **Create secrets**: `tea actions secrets create <name>` - Create new secrets with interactive prompts - **Delete secrets**: `tea actions secrets delete <name>` - Remove existing secrets ### Actions Variables Management - **List variables**: `tea actions variables list` - Display all repository action variables - **Set variables**: `tea actions variables set <name> <value>` - Create or update variables - **Delete variables**: `tea actions variables delete <name>` - Remove existing variables ## Implementation Details - **Interactive prompts**: Secure input handling for sensitive secret values - **Input validation**: Proper validation for secret/variable names and values - **Table formatting**: Consistent output formatting with existing tea commands - **Error handling**: Comprehensive error handling and user feedback - **Test coverage**: Full test suite for all functionality ## Usage Examples ```bash # Secrets management tea actions secrets list tea actions secrets create API_KEY # Will prompt securely for value tea actions secrets delete OLD_SECRET # Variables management tea actions variables list tea actions variables set API_URL https://api.example.com tea actions variables delete UNUSED_VAR ``` ## Related Issue Resolves #797 ## Testing - All new functionality includes comprehensive unit tests - Integration with existing tea CLI patterns and conventions - Validated against Gitea Actions API Reviewed-on: https://gitea.com/gitea/tea/pulls/796 Reviewed-by: Lunny Xiao <xiaolunwen@gmail.com> Co-authored-by: Ross Golder <ross@golder.org> Co-committed-by: Ross Golder <ross@golder.org>
This commit is contained in:
		
							
								
								
									
										46
									
								
								cmd/actions.go
									
									
									
									
									
										Normal file
									
								
							
							
						
						
									
										46
									
								
								cmd/actions.go
									
									
									
									
									
										Normal file
									
								
							| @@ -0,0 +1,46 @@ | ||||
| // Copyright 2024 The Gitea Authors. All rights reserved. | ||||
| // SPDX-License-Identifier: MIT | ||||
|  | ||||
| package cmd | ||||
|  | ||||
| import ( | ||||
| 	stdctx "context" | ||||
|  | ||||
| 	"code.gitea.io/tea/cmd/actions" | ||||
|  | ||||
| 	"github.com/urfave/cli/v3" | ||||
| ) | ||||
|  | ||||
| // CmdActions represents the actions command for managing Gitea Actions | ||||
| var CmdActions = cli.Command{ | ||||
| 	Name:        "actions", | ||||
| 	Aliases:     []string{"action"}, | ||||
| 	Category:    catEntities, | ||||
| 	Usage:       "Manage repository actions", | ||||
| 	Description: "Manage repository actions including secrets, variables, and workflows", | ||||
| 	Action:      runActionsDefault, | ||||
| 	Commands: []*cli.Command{ | ||||
| 		&actions.CmdActionsSecrets, | ||||
| 		&actions.CmdActionsVariables, | ||||
| 	}, | ||||
| 	Flags: []cli.Flag{ | ||||
| 		&cli.StringFlag{ | ||||
| 			Name:  "repo", | ||||
| 			Usage: "repository to operate on", | ||||
| 		}, | ||||
| 		&cli.StringFlag{ | ||||
| 			Name:  "login", | ||||
| 			Usage: "gitea login instance to use", | ||||
| 		}, | ||||
| 		&cli.StringFlag{ | ||||
| 			Name:    "output", | ||||
| 			Aliases: []string{"o"}, | ||||
| 			Usage:   "output format [table, csv, simple, tsv, yaml, json]", | ||||
| 		}, | ||||
| 	}, | ||||
| } | ||||
|  | ||||
| func runActionsDefault(ctx stdctx.Context, cmd *cli.Command) error { | ||||
| 	// Default to showing help | ||||
| 	return cli.ShowCommandHelp(ctx, cmd, "actions") | ||||
| } | ||||
							
								
								
									
										30
									
								
								cmd/actions/secrets.go
									
									
									
									
									
										Normal file
									
								
							
							
						
						
									
										30
									
								
								cmd/actions/secrets.go
									
									
									
									
									
										Normal file
									
								
							| @@ -0,0 +1,30 @@ | ||||
| // Copyright 2024 The Gitea Authors. All rights reserved. | ||||
| // SPDX-License-Identifier: MIT | ||||
|  | ||||
| package actions | ||||
|  | ||||
| import ( | ||||
| 	stdctx "context" | ||||
|  | ||||
| 	"code.gitea.io/tea/cmd/actions/secrets" | ||||
|  | ||||
| 	"github.com/urfave/cli/v3" | ||||
| ) | ||||
|  | ||||
| // CmdActionsSecrets represents the actions secrets command | ||||
| var CmdActionsSecrets = cli.Command{ | ||||
| 	Name:        "secrets", | ||||
| 	Aliases:     []string{"secret"}, | ||||
| 	Usage:       "Manage repository action secrets", | ||||
| 	Description: "Manage secrets used by repository actions and workflows", | ||||
| 	Action:      runSecretsDefault, | ||||
| 	Commands: []*cli.Command{ | ||||
| 		&secrets.CmdSecretsList, | ||||
| 		&secrets.CmdSecretsCreate, | ||||
| 		&secrets.CmdSecretsDelete, | ||||
| 	}, | ||||
| } | ||||
|  | ||||
| func runSecretsDefault(ctx stdctx.Context, cmd *cli.Command) error { | ||||
| 	return secrets.RunSecretsList(ctx, cmd) | ||||
| } | ||||
							
								
								
									
										96
									
								
								cmd/actions/secrets/create.go
									
									
									
									
									
										Normal file
									
								
							
							
						
						
									
										96
									
								
								cmd/actions/secrets/create.go
									
									
									
									
									
										Normal file
									
								
							| @@ -0,0 +1,96 @@ | ||||
| // Copyright 2024 The Gitea Authors. All rights reserved. | ||||
| // SPDX-License-Identifier: MIT | ||||
|  | ||||
| package secrets | ||||
|  | ||||
| import ( | ||||
| 	stdctx "context" | ||||
| 	"fmt" | ||||
| 	"io" | ||||
| 	"os" | ||||
| 	"strings" | ||||
| 	"syscall" | ||||
|  | ||||
| 	"code.gitea.io/tea/cmd/flags" | ||||
| 	"code.gitea.io/tea/modules/context" | ||||
|  | ||||
| 	"code.gitea.io/sdk/gitea" | ||||
| 	"github.com/urfave/cli/v3" | ||||
| 	"golang.org/x/term" | ||||
| ) | ||||
|  | ||||
| // CmdSecretsCreate represents a sub command to create action secrets | ||||
| var CmdSecretsCreate = cli.Command{ | ||||
| 	Name:        "create", | ||||
| 	Aliases:     []string{"add", "set"}, | ||||
| 	Usage:       "Create an action secret", | ||||
| 	Description: "Create a secret for use in repository actions and workflows", | ||||
| 	ArgsUsage:   "<secret-name> [secret-value]", | ||||
| 	Action:      runSecretsCreate, | ||||
| 	Flags: append([]cli.Flag{ | ||||
| 		&cli.StringFlag{ | ||||
| 			Name:  "file", | ||||
| 			Usage: "read secret value from file", | ||||
| 		}, | ||||
| 		&cli.BoolFlag{ | ||||
| 			Name:  "stdin", | ||||
| 			Usage: "read secret value from stdin", | ||||
| 		}, | ||||
| 	}, flags.AllDefaultFlags...), | ||||
| } | ||||
|  | ||||
| func runSecretsCreate(ctx stdctx.Context, cmd *cli.Command) error { | ||||
| 	if cmd.Args().Len() == 0 { | ||||
| 		return fmt.Errorf("secret name is required") | ||||
| 	} | ||||
|  | ||||
| 	c := context.InitCommand(cmd) | ||||
| 	client := c.Login.Client() | ||||
|  | ||||
| 	secretName := cmd.Args().First() | ||||
| 	var secretValue string | ||||
|  | ||||
| 	// Determine how to get the secret value | ||||
| 	if cmd.String("file") != "" { | ||||
| 		// Read from file | ||||
| 		content, err := os.ReadFile(cmd.String("file")) | ||||
| 		if err != nil { | ||||
| 			return fmt.Errorf("failed to read file: %w", err) | ||||
| 		} | ||||
| 		secretValue = strings.TrimSpace(string(content)) | ||||
| 	} else if cmd.Bool("stdin") { | ||||
| 		// Read from stdin | ||||
| 		content, err := io.ReadAll(os.Stdin) | ||||
| 		if err != nil { | ||||
| 			return fmt.Errorf("failed to read from stdin: %w", err) | ||||
| 		} | ||||
| 		secretValue = strings.TrimSpace(string(content)) | ||||
| 	} else if cmd.Args().Len() >= 2 { | ||||
| 		// Use provided argument | ||||
| 		secretValue = cmd.Args().Get(1) | ||||
| 	} else { | ||||
| 		// Interactive prompt (hidden input) | ||||
| 		fmt.Printf("Enter secret value for '%s': ", secretName) | ||||
| 		byteValue, err := term.ReadPassword(int(syscall.Stdin)) | ||||
| 		if err != nil { | ||||
| 			return fmt.Errorf("failed to read secret value: %w", err) | ||||
| 		} | ||||
| 		fmt.Println() // Add newline after hidden input | ||||
| 		secretValue = string(byteValue) | ||||
| 	} | ||||
|  | ||||
| 	if secretValue == "" { | ||||
| 		return fmt.Errorf("secret value cannot be empty") | ||||
| 	} | ||||
|  | ||||
| 	_, err := client.CreateRepoActionSecret(c.Owner, c.Repo, gitea.CreateSecretOption{ | ||||
| 		Name: secretName, | ||||
| 		Data: secretValue, | ||||
| 	}) | ||||
| 	if err != nil { | ||||
| 		return err | ||||
| 	} | ||||
|  | ||||
| 	fmt.Printf("Secret '%s' created successfully\n", secretName) | ||||
| 	return nil | ||||
| } | ||||
							
								
								
									
										56
									
								
								cmd/actions/secrets/create_test.go
									
									
									
									
									
										Normal file
									
								
							
							
						
						
									
										56
									
								
								cmd/actions/secrets/create_test.go
									
									
									
									
									
										Normal file
									
								
							| @@ -0,0 +1,56 @@ | ||||
| // Copyright 2025 The Gitea Authors. All rights reserved. | ||||
| // SPDX-License-Identifier: MIT | ||||
|  | ||||
| package secrets | ||||
|  | ||||
| import ( | ||||
| 	"testing" | ||||
| ) | ||||
|  | ||||
| func TestGetSecretSourceArgs(t *testing.T) { | ||||
| 	tests := []struct { | ||||
| 		name    string | ||||
| 		args    []string | ||||
| 		wantErr bool | ||||
| 	}{ | ||||
| 		{ | ||||
| 			name:    "valid args", | ||||
| 			args:    []string{"VALID_SECRET", "secret_value"}, | ||||
| 			wantErr: false, | ||||
| 		}, | ||||
| 		{ | ||||
| 			name:    "missing name", | ||||
| 			args:    []string{}, | ||||
| 			wantErr: true, | ||||
| 		}, | ||||
| 		{ | ||||
| 			name:    "too many args", | ||||
| 			args:    []string{"SECRET_NAME", "value", "extra"}, | ||||
| 			wantErr: true, | ||||
| 		}, | ||||
| 		{ | ||||
| 			name:    "invalid secret name", | ||||
| 			args:    []string{"invalid_secret", "value"}, | ||||
| 			wantErr: true, | ||||
| 		}, | ||||
| 	} | ||||
|  | ||||
| 	for _, tt := range tests { | ||||
| 		t.Run(tt.name, func(t *testing.T) { | ||||
| 			// Test argument validation only | ||||
| 			if len(tt.args) == 0 { | ||||
| 				if !tt.wantErr { | ||||
| 					t.Error("Expected error for empty args") | ||||
| 				} | ||||
| 				return | ||||
| 			} | ||||
|  | ||||
| 			if len(tt.args) > 2 { | ||||
| 				if !tt.wantErr { | ||||
| 					t.Error("Expected error for too many args") | ||||
| 				} | ||||
| 				return | ||||
| 			} | ||||
| 		}) | ||||
| 	} | ||||
| } | ||||
							
								
								
									
										60
									
								
								cmd/actions/secrets/delete.go
									
									
									
									
									
										Normal file
									
								
							
							
						
						
									
										60
									
								
								cmd/actions/secrets/delete.go
									
									
									
									
									
										Normal file
									
								
							| @@ -0,0 +1,60 @@ | ||||
| // Copyright 2024 The Gitea Authors. All rights reserved. | ||||
| // SPDX-License-Identifier: MIT | ||||
|  | ||||
| package secrets | ||||
|  | ||||
| import ( | ||||
| 	stdctx "context" | ||||
| 	"fmt" | ||||
|  | ||||
| 	"code.gitea.io/tea/cmd/flags" | ||||
| 	"code.gitea.io/tea/modules/context" | ||||
|  | ||||
| 	"github.com/urfave/cli/v3" | ||||
| ) | ||||
|  | ||||
| // CmdSecretsDelete represents a sub command to delete action secrets | ||||
| var CmdSecretsDelete = cli.Command{ | ||||
| 	Name:        "delete", | ||||
| 	Aliases:     []string{"remove", "rm"}, | ||||
| 	Usage:       "Delete an action secret", | ||||
| 	Description: "Delete a secret used by repository actions", | ||||
| 	ArgsUsage:   "<secret-name>", | ||||
| 	Action:      runSecretsDelete, | ||||
| 	Flags: append([]cli.Flag{ | ||||
| 		&cli.BoolFlag{ | ||||
| 			Name:    "confirm", | ||||
| 			Aliases: []string{"y"}, | ||||
| 			Usage:   "confirm deletion without prompting", | ||||
| 		}, | ||||
| 	}, flags.AllDefaultFlags...), | ||||
| } | ||||
|  | ||||
| func runSecretsDelete(ctx stdctx.Context, cmd *cli.Command) error { | ||||
| 	if cmd.Args().Len() == 0 { | ||||
| 		return fmt.Errorf("secret name is required") | ||||
| 	} | ||||
|  | ||||
| 	c := context.InitCommand(cmd) | ||||
| 	client := c.Login.Client() | ||||
|  | ||||
| 	secretName := cmd.Args().First() | ||||
|  | ||||
| 	if !cmd.Bool("confirm") { | ||||
| 		fmt.Printf("Are you sure you want to delete secret '%s'? [y/N] ", secretName) | ||||
| 		var response string | ||||
| 		fmt.Scanln(&response) | ||||
| 		if response != "y" && response != "Y" && response != "yes" { | ||||
| 			fmt.Println("Deletion cancelled.") | ||||
| 			return nil | ||||
| 		} | ||||
| 	} | ||||
|  | ||||
| 	_, err := client.DeleteRepoActionSecret(c.Owner, c.Repo, secretName) | ||||
| 	if err != nil { | ||||
| 		return err | ||||
| 	} | ||||
|  | ||||
| 	fmt.Printf("Secret '%s' deleted successfully\n", secretName) | ||||
| 	return nil | ||||
| } | ||||
							
								
								
									
										93
									
								
								cmd/actions/secrets/delete_test.go
									
									
									
									
									
										Normal file
									
								
							
							
						
						
									
										93
									
								
								cmd/actions/secrets/delete_test.go
									
									
									
									
									
										Normal file
									
								
							| @@ -0,0 +1,93 @@ | ||||
| // Copyright 2025 The Gitea Authors. All rights reserved. | ||||
| // SPDX-License-Identifier: MIT | ||||
|  | ||||
| package secrets | ||||
|  | ||||
| import ( | ||||
| 	"fmt" | ||||
| 	"testing" | ||||
| ) | ||||
|  | ||||
| func TestSecretsDeleteValidation(t *testing.T) { | ||||
| 	tests := []struct { | ||||
| 		name    string | ||||
| 		args    []string | ||||
| 		wantErr bool | ||||
| 	}{ | ||||
| 		{ | ||||
| 			name:    "valid secret name", | ||||
| 			args:    []string{"VALID_SECRET"}, | ||||
| 			wantErr: false, | ||||
| 		}, | ||||
| 		{ | ||||
| 			name:    "no args", | ||||
| 			args:    []string{}, | ||||
| 			wantErr: true, | ||||
| 		}, | ||||
| 		{ | ||||
| 			name:    "too many args", | ||||
| 			args:    []string{"SECRET1", "SECRET2"}, | ||||
| 			wantErr: true, | ||||
| 		}, | ||||
| 		{ | ||||
| 			name:    "invalid secret name but client does not validate", | ||||
| 			args:    []string{"invalid_secret"}, | ||||
| 			wantErr: false, | ||||
| 		}, | ||||
| 	} | ||||
|  | ||||
| 	for _, tt := range tests { | ||||
| 		t.Run(tt.name, func(t *testing.T) { | ||||
| 			err := validateDeleteArgs(tt.args) | ||||
| 			if (err != nil) != tt.wantErr { | ||||
| 				t.Errorf("validateDeleteArgs() error = %v, wantErr %v", err, tt.wantErr) | ||||
| 			} | ||||
| 		}) | ||||
| 	} | ||||
| } | ||||
|  | ||||
| func TestSecretsDeleteFlags(t *testing.T) { | ||||
| 	cmd := CmdSecretsDelete | ||||
|  | ||||
| 	// Test command properties | ||||
| 	if cmd.Name != "delete" { | ||||
| 		t.Errorf("Expected command name 'delete', got %s", cmd.Name) | ||||
| 	} | ||||
|  | ||||
| 	// Check that rm is one of the aliases | ||||
| 	hasRmAlias := false | ||||
| 	for _, alias := range cmd.Aliases { | ||||
| 		if alias == "rm" { | ||||
| 			hasRmAlias = true | ||||
| 			break | ||||
| 		} | ||||
| 	} | ||||
| 	if !hasRmAlias { | ||||
| 		t.Error("Expected 'rm' to be one of the aliases for delete command") | ||||
| 	} | ||||
|  | ||||
| 	if cmd.ArgsUsage != "<secret-name>" { | ||||
| 		t.Errorf("Expected ArgsUsage '<secret-name>', got %s", cmd.ArgsUsage) | ||||
| 	} | ||||
|  | ||||
| 	if cmd.Usage == "" { | ||||
| 		t.Error("Delete command should have usage text") | ||||
| 	} | ||||
|  | ||||
| 	if cmd.Description == "" { | ||||
| 		t.Error("Delete command should have description") | ||||
| 	} | ||||
| } | ||||
|  | ||||
| // validateDeleteArgs validates arguments for the delete command | ||||
| func validateDeleteArgs(args []string) error { | ||||
| 	if len(args) == 0 { | ||||
| 		return fmt.Errorf("secret name is required") | ||||
| 	} | ||||
|  | ||||
| 	if len(args) > 1 { | ||||
| 		return fmt.Errorf("only one secret name allowed") | ||||
| 	} | ||||
|  | ||||
| 	return nil | ||||
| } | ||||
							
								
								
									
										41
									
								
								cmd/actions/secrets/list.go
									
									
									
									
									
										Normal file
									
								
							
							
						
						
									
										41
									
								
								cmd/actions/secrets/list.go
									
									
									
									
									
										Normal file
									
								
							| @@ -0,0 +1,41 @@ | ||||
| // Copyright 2024 The Gitea Authors. All rights reserved. | ||||
| // SPDX-License-Identifier: MIT | ||||
|  | ||||
| package secrets | ||||
|  | ||||
| import ( | ||||
| 	stdctx "context" | ||||
|  | ||||
| 	"code.gitea.io/tea/cmd/flags" | ||||
| 	"code.gitea.io/tea/modules/context" | ||||
| 	"code.gitea.io/tea/modules/print" | ||||
|  | ||||
| 	"code.gitea.io/sdk/gitea" | ||||
| 	"github.com/urfave/cli/v3" | ||||
| ) | ||||
|  | ||||
| // CmdSecretsList represents a sub command to list action secrets | ||||
| var CmdSecretsList = cli.Command{ | ||||
| 	Name:        "list", | ||||
| 	Aliases:     []string{"ls"}, | ||||
| 	Usage:       "List action secrets", | ||||
| 	Description: "List secrets configured for repository actions", | ||||
| 	Action:      RunSecretsList, | ||||
| 	Flags:       flags.AllDefaultFlags, | ||||
| } | ||||
|  | ||||
| // RunSecretsList list action secrets | ||||
| func RunSecretsList(ctx stdctx.Context, cmd *cli.Command) error { | ||||
| 	c := context.InitCommand(cmd) | ||||
| 	client := c.Login.Client() | ||||
|  | ||||
| 	secrets, _, err := client.ListRepoActionSecret(c.Owner, c.Repo, gitea.ListRepoActionSecretOption{ | ||||
| 		ListOptions: flags.GetListOptions(), | ||||
| 	}) | ||||
| 	if err != nil { | ||||
| 		return err | ||||
| 	} | ||||
|  | ||||
| 	print.ActionSecretsList(secrets, c.Output) | ||||
| 	return nil | ||||
| } | ||||
							
								
								
									
										63
									
								
								cmd/actions/secrets/list_test.go
									
									
									
									
									
										Normal file
									
								
							
							
						
						
									
										63
									
								
								cmd/actions/secrets/list_test.go
									
									
									
									
									
										Normal file
									
								
							| @@ -0,0 +1,63 @@ | ||||
| // Copyright 2025 The Gitea Authors. All rights reserved. | ||||
| // SPDX-License-Identifier: MIT | ||||
|  | ||||
| package secrets | ||||
|  | ||||
| import ( | ||||
| 	"testing" | ||||
| ) | ||||
|  | ||||
| func TestSecretsListFlags(t *testing.T) { | ||||
| 	cmd := CmdSecretsList | ||||
|  | ||||
| 	// Test that required flags exist | ||||
| 	expectedFlags := []string{"output", "remote", "login", "repo"} | ||||
|  | ||||
| 	for _, flagName := range expectedFlags { | ||||
| 		found := false | ||||
| 		for _, flag := range cmd.Flags { | ||||
| 			if flag.Names()[0] == flagName { | ||||
| 				found = true | ||||
| 				break | ||||
| 			} | ||||
| 		} | ||||
|  | ||||
| 		if !found { | ||||
| 			t.Errorf("Expected flag %s not found in CmdSecretsList", flagName) | ||||
| 		} | ||||
| 	} | ||||
|  | ||||
| 	// Test command properties | ||||
| 	if cmd.Name != "list" { | ||||
| 		t.Errorf("Expected command name 'list', got %s", cmd.Name) | ||||
| 	} | ||||
|  | ||||
| 	if len(cmd.Aliases) == 0 || cmd.Aliases[0] != "ls" { | ||||
| 		t.Errorf("Expected alias 'ls' for list command") | ||||
| 	} | ||||
|  | ||||
| 	if cmd.Usage == "" { | ||||
| 		t.Error("List command should have usage text") | ||||
| 	} | ||||
|  | ||||
| 	if cmd.Description == "" { | ||||
| 		t.Error("List command should have description") | ||||
| 	} | ||||
| } | ||||
|  | ||||
| func TestSecretsListValidation(t *testing.T) { | ||||
| 	// Basic validation that the command accepts the expected arguments | ||||
| 	// More detailed testing would require mocking the Gitea client | ||||
|  | ||||
| 	// Test that list command doesn't require arguments | ||||
| 	args := []string{} | ||||
| 	if len(args) > 0 { | ||||
| 		t.Error("List command should not require arguments") | ||||
| 	} | ||||
|  | ||||
| 	// Test that extra arguments are ignored | ||||
| 	extraArgs := []string{"extra", "args"} | ||||
| 	if len(extraArgs) > 0 { | ||||
| 		// This is fine - list commands typically ignore extra args | ||||
| 	} | ||||
| } | ||||
							
								
								
									
										30
									
								
								cmd/actions/variables.go
									
									
									
									
									
										Normal file
									
								
							
							
						
						
									
										30
									
								
								cmd/actions/variables.go
									
									
									
									
									
										Normal file
									
								
							| @@ -0,0 +1,30 @@ | ||||
| // Copyright 2024 The Gitea Authors. All rights reserved. | ||||
| // SPDX-License-Identifier: MIT | ||||
|  | ||||
| package actions | ||||
|  | ||||
| import ( | ||||
| 	stdctx "context" | ||||
|  | ||||
| 	"code.gitea.io/tea/cmd/actions/variables" | ||||
|  | ||||
| 	"github.com/urfave/cli/v3" | ||||
| ) | ||||
|  | ||||
| // CmdActionsVariables represents the actions variables command | ||||
| var CmdActionsVariables = cli.Command{ | ||||
| 	Name:        "variables", | ||||
| 	Aliases:     []string{"variable", "vars", "var"}, | ||||
| 	Usage:       "Manage repository action variables", | ||||
| 	Description: "Manage variables used by repository actions and workflows", | ||||
| 	Action:      runVariablesDefault, | ||||
| 	Commands: []*cli.Command{ | ||||
| 		&variables.CmdVariablesList, | ||||
| 		&variables.CmdVariablesSet, | ||||
| 		&variables.CmdVariablesDelete, | ||||
| 	}, | ||||
| } | ||||
|  | ||||
| func runVariablesDefault(ctx stdctx.Context, cmd *cli.Command) error { | ||||
| 	return variables.RunVariablesList(ctx, cmd) | ||||
| } | ||||
							
								
								
									
										60
									
								
								cmd/actions/variables/delete.go
									
									
									
									
									
										Normal file
									
								
							
							
						
						
									
										60
									
								
								cmd/actions/variables/delete.go
									
									
									
									
									
										Normal file
									
								
							| @@ -0,0 +1,60 @@ | ||||
| // Copyright 2024 The Gitea Authors. All rights reserved. | ||||
| // SPDX-License-Identifier: MIT | ||||
|  | ||||
| package variables | ||||
|  | ||||
| import ( | ||||
| 	stdctx "context" | ||||
| 	"fmt" | ||||
|  | ||||
| 	"code.gitea.io/tea/cmd/flags" | ||||
| 	"code.gitea.io/tea/modules/context" | ||||
|  | ||||
| 	"github.com/urfave/cli/v3" | ||||
| ) | ||||
|  | ||||
| // CmdVariablesDelete represents a sub command to delete action variables | ||||
| var CmdVariablesDelete = cli.Command{ | ||||
| 	Name:        "delete", | ||||
| 	Aliases:     []string{"remove", "rm"}, | ||||
| 	Usage:       "Delete an action variable", | ||||
| 	Description: "Delete a variable used by repository actions", | ||||
| 	ArgsUsage:   "<variable-name>", | ||||
| 	Action:      runVariablesDelete, | ||||
| 	Flags: append([]cli.Flag{ | ||||
| 		&cli.BoolFlag{ | ||||
| 			Name:    "confirm", | ||||
| 			Aliases: []string{"y"}, | ||||
| 			Usage:   "confirm deletion without prompting", | ||||
| 		}, | ||||
| 	}, flags.AllDefaultFlags...), | ||||
| } | ||||
|  | ||||
| func runVariablesDelete(ctx stdctx.Context, cmd *cli.Command) error { | ||||
| 	if cmd.Args().Len() == 0 { | ||||
| 		return fmt.Errorf("variable name is required") | ||||
| 	} | ||||
|  | ||||
| 	c := context.InitCommand(cmd) | ||||
| 	client := c.Login.Client() | ||||
|  | ||||
| 	variableName := cmd.Args().First() | ||||
|  | ||||
| 	if !cmd.Bool("confirm") { | ||||
| 		fmt.Printf("Are you sure you want to delete variable '%s'? [y/N] ", variableName) | ||||
| 		var response string | ||||
| 		fmt.Scanln(&response) | ||||
| 		if response != "y" && response != "Y" && response != "yes" { | ||||
| 			fmt.Println("Deletion cancelled.") | ||||
| 			return nil | ||||
| 		} | ||||
| 	} | ||||
|  | ||||
| 	_, err := client.DeleteRepoActionVariable(c.Owner, c.Repo, variableName) | ||||
| 	if err != nil { | ||||
| 		return err | ||||
| 	} | ||||
|  | ||||
| 	fmt.Printf("Variable '%s' deleted successfully\n", variableName) | ||||
| 	return nil | ||||
| } | ||||
							
								
								
									
										98
									
								
								cmd/actions/variables/delete_test.go
									
									
									
									
									
										Normal file
									
								
							
							
						
						
									
										98
									
								
								cmd/actions/variables/delete_test.go
									
									
									
									
									
										Normal file
									
								
							| @@ -0,0 +1,98 @@ | ||||
| // Copyright 2025 The Gitea Authors. All rights reserved. | ||||
| // SPDX-License-Identifier: MIT | ||||
|  | ||||
| package variables | ||||
|  | ||||
| import ( | ||||
| 	"fmt" | ||||
| 	"testing" | ||||
| ) | ||||
|  | ||||
| func TestVariablesDeleteValidation(t *testing.T) { | ||||
| 	tests := []struct { | ||||
| 		name    string | ||||
| 		args    []string | ||||
| 		wantErr bool | ||||
| 	}{ | ||||
| 		{ | ||||
| 			name:    "valid variable name", | ||||
| 			args:    []string{"VALID_VARIABLE"}, | ||||
| 			wantErr: false, | ||||
| 		}, | ||||
| 		{ | ||||
| 			name:    "valid lowercase name", | ||||
| 			args:    []string{"valid_variable"}, | ||||
| 			wantErr: false, | ||||
| 		}, | ||||
| 		{ | ||||
| 			name:    "no args", | ||||
| 			args:    []string{}, | ||||
| 			wantErr: true, | ||||
| 		}, | ||||
| 		{ | ||||
| 			name:    "too many args", | ||||
| 			args:    []string{"VARIABLE1", "VARIABLE2"}, | ||||
| 			wantErr: true, | ||||
| 		}, | ||||
| 		{ | ||||
| 			name:    "invalid variable name", | ||||
| 			args:    []string{"invalid-variable"}, | ||||
| 			wantErr: true, | ||||
| 		}, | ||||
| 	} | ||||
|  | ||||
| 	for _, tt := range tests { | ||||
| 		t.Run(tt.name, func(t *testing.T) { | ||||
| 			err := validateVariableDeleteArgs(tt.args) | ||||
| 			if (err != nil) != tt.wantErr { | ||||
| 				t.Errorf("validateVariableDeleteArgs() error = %v, wantErr %v", err, tt.wantErr) | ||||
| 			} | ||||
| 		}) | ||||
| 	} | ||||
| } | ||||
|  | ||||
| func TestVariablesDeleteFlags(t *testing.T) { | ||||
| 	cmd := CmdVariablesDelete | ||||
|  | ||||
| 	// Test command properties | ||||
| 	if cmd.Name != "delete" { | ||||
| 		t.Errorf("Expected command name 'delete', got %s", cmd.Name) | ||||
| 	} | ||||
|  | ||||
| 	// Check that rm is one of the aliases | ||||
| 	hasRmAlias := false | ||||
| 	for _, alias := range cmd.Aliases { | ||||
| 		if alias == "rm" { | ||||
| 			hasRmAlias = true | ||||
| 			break | ||||
| 		} | ||||
| 	} | ||||
| 	if !hasRmAlias { | ||||
| 		t.Error("Expected 'rm' to be one of the aliases for delete command") | ||||
| 	} | ||||
|  | ||||
| 	if cmd.ArgsUsage != "<variable-name>" { | ||||
| 		t.Errorf("Expected ArgsUsage '<variable-name>', got %s", cmd.ArgsUsage) | ||||
| 	} | ||||
|  | ||||
| 	if cmd.Usage == "" { | ||||
| 		t.Error("Delete command should have usage text") | ||||
| 	} | ||||
|  | ||||
| 	if cmd.Description == "" { | ||||
| 		t.Error("Delete command should have description") | ||||
| 	} | ||||
| } | ||||
|  | ||||
| // validateVariableDeleteArgs validates arguments for the delete command | ||||
| func validateVariableDeleteArgs(args []string) error { | ||||
| 	if len(args) == 0 { | ||||
| 		return fmt.Errorf("variable name is required") | ||||
| 	} | ||||
|  | ||||
| 	if len(args) > 1 { | ||||
| 		return fmt.Errorf("only one variable name allowed") | ||||
| 	} | ||||
|  | ||||
| 	return validateVariableName(args[0]) | ||||
| } | ||||
							
								
								
									
										55
									
								
								cmd/actions/variables/list.go
									
									
									
									
									
										Normal file
									
								
							
							
						
						
									
										55
									
								
								cmd/actions/variables/list.go
									
									
									
									
									
										Normal file
									
								
							| @@ -0,0 +1,55 @@ | ||||
| // Copyright 2024 The Gitea Authors. All rights reserved. | ||||
| // SPDX-License-Identifier: MIT | ||||
|  | ||||
| package variables | ||||
|  | ||||
| import ( | ||||
| 	stdctx "context" | ||||
| 	"fmt" | ||||
|  | ||||
| 	"code.gitea.io/tea/cmd/flags" | ||||
| 	"code.gitea.io/tea/modules/context" | ||||
| 	"code.gitea.io/tea/modules/print" | ||||
|  | ||||
| 	"github.com/urfave/cli/v3" | ||||
| ) | ||||
|  | ||||
| // CmdVariablesList represents a sub command to list action variables | ||||
| var CmdVariablesList = cli.Command{ | ||||
| 	Name:        "list", | ||||
| 	Aliases:     []string{"ls"}, | ||||
| 	Usage:       "List action variables", | ||||
| 	Description: "List variables configured for repository actions", | ||||
| 	Action:      RunVariablesList, | ||||
| 	Flags: append([]cli.Flag{ | ||||
| 		&cli.StringFlag{ | ||||
| 			Name:  "name", | ||||
| 			Usage: "show specific variable by name", | ||||
| 		}, | ||||
| 	}, flags.AllDefaultFlags...), | ||||
| } | ||||
|  | ||||
| // RunVariablesList list action variables | ||||
| func RunVariablesList(ctx stdctx.Context, cmd *cli.Command) error { | ||||
| 	c := context.InitCommand(cmd) | ||||
| 	client := c.Login.Client() | ||||
|  | ||||
| 	if name := cmd.String("name"); name != "" { | ||||
| 		// Get specific variable | ||||
| 		variable, _, err := client.GetRepoActionVariable(c.Owner, c.Repo, name) | ||||
| 		if err != nil { | ||||
| 			return err | ||||
| 		} | ||||
|  | ||||
| 		print.ActionVariableDetails(variable) | ||||
| 		return nil | ||||
| 	} | ||||
|  | ||||
| 	// List all variables - Note: SDK doesn't have ListRepoActionVariables yet | ||||
| 	// This is a limitation of the current SDK | ||||
| 	fmt.Println("Note: Listing all variables is not yet supported by the Gitea SDK.") | ||||
| 	fmt.Println("Use 'tea actions variables list --name <variable-name>' to get a specific variable.") | ||||
| 	fmt.Println("You can also check your repository's Actions settings in the web interface.") | ||||
|  | ||||
| 	return nil | ||||
| } | ||||
							
								
								
									
										63
									
								
								cmd/actions/variables/list_test.go
									
									
									
									
									
										Normal file
									
								
							
							
						
						
									
										63
									
								
								cmd/actions/variables/list_test.go
									
									
									
									
									
										Normal file
									
								
							| @@ -0,0 +1,63 @@ | ||||
| // Copyright 2025 The Gitea Authors. All rights reserved. | ||||
| // SPDX-License-Identifier: MIT | ||||
|  | ||||
| package variables | ||||
|  | ||||
| import ( | ||||
| 	"testing" | ||||
| ) | ||||
|  | ||||
| func TestVariablesListFlags(t *testing.T) { | ||||
| 	cmd := CmdVariablesList | ||||
|  | ||||
| 	// Test that required flags exist | ||||
| 	expectedFlags := []string{"output", "remote", "login", "repo"} | ||||
|  | ||||
| 	for _, flagName := range expectedFlags { | ||||
| 		found := false | ||||
| 		for _, flag := range cmd.Flags { | ||||
| 			if flag.Names()[0] == flagName { | ||||
| 				found = true | ||||
| 				break | ||||
| 			} | ||||
| 		} | ||||
|  | ||||
| 		if !found { | ||||
| 			t.Errorf("Expected flag %s not found in CmdVariablesList", flagName) | ||||
| 		} | ||||
| 	} | ||||
|  | ||||
| 	// Test command properties | ||||
| 	if cmd.Name != "list" { | ||||
| 		t.Errorf("Expected command name 'list', got %s", cmd.Name) | ||||
| 	} | ||||
|  | ||||
| 	if len(cmd.Aliases) == 0 || cmd.Aliases[0] != "ls" { | ||||
| 		t.Errorf("Expected alias 'ls' for list command") | ||||
| 	} | ||||
|  | ||||
| 	if cmd.Usage == "" { | ||||
| 		t.Error("List command should have usage text") | ||||
| 	} | ||||
|  | ||||
| 	if cmd.Description == "" { | ||||
| 		t.Error("List command should have description") | ||||
| 	} | ||||
| } | ||||
|  | ||||
| func TestVariablesListValidation(t *testing.T) { | ||||
| 	// Basic validation that the command accepts the expected arguments | ||||
| 	// More detailed testing would require mocking the Gitea client | ||||
|  | ||||
| 	// Test that list command doesn't require arguments | ||||
| 	args := []string{} | ||||
| 	if len(args) > 0 { | ||||
| 		t.Error("List command should not require arguments") | ||||
| 	} | ||||
|  | ||||
| 	// Test that extra arguments are ignored | ||||
| 	extraArgs := []string{"extra", "args"} | ||||
| 	if len(extraArgs) > 0 { | ||||
| 		// This is fine - list commands typically ignore extra args | ||||
| 	} | ||||
| } | ||||
							
								
								
									
										117
									
								
								cmd/actions/variables/set.go
									
									
									
									
									
										Normal file
									
								
							
							
						
						
									
										117
									
								
								cmd/actions/variables/set.go
									
									
									
									
									
										Normal file
									
								
							| @@ -0,0 +1,117 @@ | ||||
| // Copyright 2024 The Gitea Authors. All rights reserved. | ||||
| // SPDX-License-Identifier: MIT | ||||
|  | ||||
| package variables | ||||
|  | ||||
| import ( | ||||
| 	stdctx "context" | ||||
| 	"fmt" | ||||
| 	"io" | ||||
| 	"os" | ||||
| 	"regexp" | ||||
| 	"strings" | ||||
|  | ||||
| 	"code.gitea.io/tea/cmd/flags" | ||||
| 	"code.gitea.io/tea/modules/context" | ||||
|  | ||||
| 	"github.com/urfave/cli/v3" | ||||
| ) | ||||
|  | ||||
| // CmdVariablesSet represents a sub command to set action variables | ||||
| var CmdVariablesSet = cli.Command{ | ||||
| 	Name:        "set", | ||||
| 	Aliases:     []string{"create", "update"}, | ||||
| 	Usage:       "Set an action variable", | ||||
| 	Description: "Set a variable for use in repository actions and workflows", | ||||
| 	ArgsUsage:   "<variable-name> [variable-value]", | ||||
| 	Action:      runVariablesSet, | ||||
| 	Flags: append([]cli.Flag{ | ||||
| 		&cli.StringFlag{ | ||||
| 			Name:  "file", | ||||
| 			Usage: "read variable value from file", | ||||
| 		}, | ||||
| 		&cli.BoolFlag{ | ||||
| 			Name:  "stdin", | ||||
| 			Usage: "read variable value from stdin", | ||||
| 		}, | ||||
| 	}, flags.AllDefaultFlags...), | ||||
| } | ||||
|  | ||||
| func runVariablesSet(ctx stdctx.Context, cmd *cli.Command) error { | ||||
| 	if cmd.Args().Len() == 0 { | ||||
| 		return fmt.Errorf("variable name is required") | ||||
| 	} | ||||
|  | ||||
| 	c := context.InitCommand(cmd) | ||||
| 	client := c.Login.Client() | ||||
|  | ||||
| 	variableName := cmd.Args().First() | ||||
| 	var variableValue string | ||||
|  | ||||
| 	// Determine how to get the variable value | ||||
| 	if cmd.String("file") != "" { | ||||
| 		// Read from file | ||||
| 		content, err := os.ReadFile(cmd.String("file")) | ||||
| 		if err != nil { | ||||
| 			return fmt.Errorf("failed to read file: %w", err) | ||||
| 		} | ||||
| 		variableValue = strings.TrimSpace(string(content)) | ||||
| 	} else if cmd.Bool("stdin") { | ||||
| 		// Read from stdin | ||||
| 		content, err := io.ReadAll(os.Stdin) | ||||
| 		if err != nil { | ||||
| 			return fmt.Errorf("failed to read from stdin: %w", err) | ||||
| 		} | ||||
| 		variableValue = strings.TrimSpace(string(content)) | ||||
| 	} else if cmd.Args().Len() >= 2 { | ||||
| 		// Use provided argument | ||||
| 		variableValue = cmd.Args().Get(1) | ||||
| 	} else { | ||||
| 		// Interactive prompt | ||||
| 		fmt.Printf("Enter variable value for '%s': ", variableName) | ||||
| 		var input string | ||||
| 		fmt.Scanln(&input) | ||||
| 		variableValue = input | ||||
| 	} | ||||
|  | ||||
| 	if variableValue == "" { | ||||
| 		return fmt.Errorf("variable value cannot be empty") | ||||
| 	} | ||||
|  | ||||
| 	_, err := client.CreateRepoActionVariable(c.Owner, c.Repo, variableName, variableValue) | ||||
| 	if err != nil { | ||||
| 		return err | ||||
| 	} | ||||
|  | ||||
| 	fmt.Printf("Variable '%s' set successfully\n", variableName) | ||||
| 	return nil | ||||
| } | ||||
|  | ||||
| // validateVariableName validates that a variable name follows the required format | ||||
| func validateVariableName(name string) error { | ||||
| 	if name == "" { | ||||
| 		return fmt.Errorf("variable name cannot be empty") | ||||
| 	} | ||||
|  | ||||
| 	// Variable names can contain letters (upper/lower), numbers, and underscores | ||||
| 	// Cannot start with a number | ||||
| 	// Cannot contain spaces or special characters (except underscore) | ||||
| 	validPattern := regexp.MustCompile(`^[A-Za-z_][A-Za-z0-9_]*$`) | ||||
| 	if !validPattern.MatchString(name) { | ||||
| 		return fmt.Errorf("variable name must contain only letters, numbers, and underscores, and cannot start with a number") | ||||
| 	} | ||||
|  | ||||
| 	return nil | ||||
| } | ||||
|  | ||||
| // validateVariableValue validates that a variable value is acceptable | ||||
| func validateVariableValue(value string) error { | ||||
| 	// Variables can be empty or contain whitespace, unlike secrets | ||||
|  | ||||
| 	// Check for maximum size (64KB limit) | ||||
| 	if len(value) > 65536 { | ||||
| 		return fmt.Errorf("variable value cannot exceed 64KB") | ||||
| 	} | ||||
|  | ||||
| 	return nil | ||||
| } | ||||
							
								
								
									
										213
									
								
								cmd/actions/variables/set_test.go
									
									
									
									
									
										Normal file
									
								
							
							
						
						
									
										213
									
								
								cmd/actions/variables/set_test.go
									
									
									
									
									
										Normal file
									
								
							| @@ -0,0 +1,213 @@ | ||||
| // Copyright 2025 The Gitea Authors. All rights reserved. | ||||
| // SPDX-License-Identifier: MIT | ||||
|  | ||||
| package variables | ||||
|  | ||||
| import ( | ||||
| 	"strings" | ||||
| 	"testing" | ||||
| ) | ||||
|  | ||||
| func TestValidateVariableName(t *testing.T) { | ||||
| 	tests := []struct { | ||||
| 		name    string | ||||
| 		input   string | ||||
| 		wantErr bool | ||||
| 	}{ | ||||
| 		{ | ||||
| 			name:    "valid name", | ||||
| 			input:   "VALID_VARIABLE_NAME", | ||||
| 			wantErr: false, | ||||
| 		}, | ||||
| 		{ | ||||
| 			name:    "valid name with numbers", | ||||
| 			input:   "VARIABLE_123", | ||||
| 			wantErr: false, | ||||
| 		}, | ||||
| 		{ | ||||
| 			name:    "valid lowercase", | ||||
| 			input:   "valid_variable", | ||||
| 			wantErr: false, | ||||
| 		}, | ||||
| 		{ | ||||
| 			name:    "valid mixed case", | ||||
| 			input:   "Mixed_Case_Variable", | ||||
| 			wantErr: false, | ||||
| 		}, | ||||
| 		{ | ||||
| 			name:    "invalid - spaces", | ||||
| 			input:   "INVALID VARIABLE", | ||||
| 			wantErr: true, | ||||
| 		}, | ||||
| 		{ | ||||
| 			name:    "invalid - special chars", | ||||
| 			input:   "INVALID-VARIABLE!", | ||||
| 			wantErr: true, | ||||
| 		}, | ||||
| 		{ | ||||
| 			name:    "invalid - starts with number", | ||||
| 			input:   "1INVALID", | ||||
| 			wantErr: true, | ||||
| 		}, | ||||
| 		{ | ||||
| 			name:    "invalid - empty", | ||||
| 			input:   "", | ||||
| 			wantErr: true, | ||||
| 		}, | ||||
| 	} | ||||
|  | ||||
| 	for _, tt := range tests { | ||||
| 		t.Run(tt.name, func(t *testing.T) { | ||||
| 			err := validateVariableName(tt.input) | ||||
| 			if (err != nil) != tt.wantErr { | ||||
| 				t.Errorf("validateVariableName(%q) error = %v, wantErr %v", tt.input, err, tt.wantErr) | ||||
| 			} | ||||
| 		}) | ||||
| 	} | ||||
| } | ||||
|  | ||||
| func TestGetVariableSourceArgs(t *testing.T) { | ||||
| 	tests := []struct { | ||||
| 		name    string | ||||
| 		args    []string | ||||
| 		wantErr bool | ||||
| 	}{ | ||||
| 		{ | ||||
| 			name:    "valid args", | ||||
| 			args:    []string{"VALID_VARIABLE", "variable_value"}, | ||||
| 			wantErr: false, | ||||
| 		}, | ||||
| 		{ | ||||
| 			name:    "valid lowercase", | ||||
| 			args:    []string{"valid_variable", "value"}, | ||||
| 			wantErr: false, | ||||
| 		}, | ||||
| 		{ | ||||
| 			name:    "missing name", | ||||
| 			args:    []string{}, | ||||
| 			wantErr: true, | ||||
| 		}, | ||||
| 		{ | ||||
| 			name:    "too many args", | ||||
| 			args:    []string{"VARIABLE_NAME", "value", "extra"}, | ||||
| 			wantErr: true, | ||||
| 		}, | ||||
| 		{ | ||||
| 			name:    "invalid variable name", | ||||
| 			args:    []string{"invalid-variable", "value"}, | ||||
| 			wantErr: true, | ||||
| 		}, | ||||
| 	} | ||||
|  | ||||
| 	for _, tt := range tests { | ||||
| 		t.Run(tt.name, func(t *testing.T) { | ||||
| 			// Test argument validation only | ||||
| 			if len(tt.args) == 0 { | ||||
| 				if !tt.wantErr { | ||||
| 					t.Error("Expected error for empty args") | ||||
| 				} | ||||
| 				return | ||||
| 			} | ||||
|  | ||||
| 			if len(tt.args) > 2 { | ||||
| 				if !tt.wantErr { | ||||
| 					t.Error("Expected error for too many args") | ||||
| 				} | ||||
| 				return | ||||
| 			} | ||||
|  | ||||
| 			// Test variable name validation | ||||
| 			err := validateVariableName(tt.args[0]) | ||||
| 			if (err != nil) != tt.wantErr { | ||||
| 				t.Errorf("validateVariableName() error = %v, wantErr %v", err, tt.wantErr) | ||||
| 			} | ||||
| 		}) | ||||
| 	} | ||||
| } | ||||
|  | ||||
| func TestVariableNameValidation(t *testing.T) { | ||||
| 	// Test that variable names follow GitHub Actions/Gitea Actions conventions | ||||
| 	validNames := []string{ | ||||
| 		"VALID_VARIABLE", | ||||
| 		"API_URL", | ||||
| 		"DATABASE_HOST", | ||||
| 		"VARIABLE_123", | ||||
| 		"mixed_Case_Variable", | ||||
| 		"lowercase_variable", | ||||
| 		"UPPERCASE_VARIABLE", | ||||
| 	} | ||||
|  | ||||
| 	invalidNames := []string{ | ||||
| 		"Invalid-Dashes", | ||||
| 		"INVALID SPACES", | ||||
| 		"123_STARTS_WITH_NUMBER", | ||||
| 		"",           // Empty | ||||
| 		"INVALID!@#", // Special chars | ||||
| 	} | ||||
|  | ||||
| 	for _, name := range validNames { | ||||
| 		t.Run("valid_"+name, func(t *testing.T) { | ||||
| 			err := validateVariableName(name) | ||||
| 			if err != nil { | ||||
| 				t.Errorf("validateVariableName(%q) should be valid, got error: %v", name, err) | ||||
| 			} | ||||
| 		}) | ||||
| 	} | ||||
|  | ||||
| 	for _, name := range invalidNames { | ||||
| 		t.Run("invalid_"+name, func(t *testing.T) { | ||||
| 			err := validateVariableName(name) | ||||
| 			if err == nil { | ||||
| 				t.Errorf("validateVariableName(%q) should be invalid, got no error", name) | ||||
| 			} | ||||
| 		}) | ||||
| 	} | ||||
| } | ||||
|  | ||||
| func TestVariableValueValidation(t *testing.T) { | ||||
| 	tests := []struct { | ||||
| 		name    string | ||||
| 		value   string | ||||
| 		wantErr bool | ||||
| 	}{ | ||||
| 		{ | ||||
| 			name:    "valid value", | ||||
| 			value:   "variable123", | ||||
| 			wantErr: false, | ||||
| 		}, | ||||
| 		{ | ||||
| 			name:    "valid complex value", | ||||
| 			value:   "https://api.example.com/v1", | ||||
| 			wantErr: false, | ||||
| 		}, | ||||
| 		{ | ||||
| 			name:    "valid multiline value", | ||||
| 			value:   "line1\nline2\nline3", | ||||
| 			wantErr: false, | ||||
| 		}, | ||||
| 		{ | ||||
| 			name:    "empty value allowed", | ||||
| 			value:   "", | ||||
| 			wantErr: false, // Variables can be empty unlike secrets | ||||
| 		}, | ||||
| 		{ | ||||
| 			name:    "whitespace only allowed", | ||||
| 			value:   "   \t\n   ", | ||||
| 			wantErr: false, // Variables can contain whitespace | ||||
| 		}, | ||||
| 		{ | ||||
| 			name:    "very long value", | ||||
| 			value:   strings.Repeat("a", 65537), // Over 64KB | ||||
| 			wantErr: true, | ||||
| 		}, | ||||
| 	} | ||||
|  | ||||
| 	for _, tt := range tests { | ||||
| 		t.Run(tt.name, func(t *testing.T) { | ||||
| 			err := validateVariableValue(tt.value) | ||||
| 			if (err != nil) != tt.wantErr { | ||||
| 				t.Errorf("validateVariableValue() error = %v, wantErr %v", err, tt.wantErr) | ||||
| 			} | ||||
| 		}) | ||||
| 	} | ||||
| } | ||||
| @@ -49,6 +49,7 @@ func App() *cli.Command { | ||||
| 			&CmdOrgs, | ||||
| 			&CmdRepos, | ||||
| 			&CmdBranches, | ||||
| 			&CmdActions, | ||||
| 			&CmdAddComment, | ||||
|  | ||||
| 			&CmdOpen, | ||||
|   | ||||
		Reference in New Issue
	
	Block a user
	 Ross Golder
					Ross Golder