Move integration tests to tests/ directory (#973)

Reviewed-on: https://gitea.com/gitea/tea/pulls/973

modules/config/lock_unix_test.go

@@ -1,82 +0,0 @@
-// Copyright 2026 The Gitea Authors. All rights reserved.
-// SPDX-License-Identifier: MIT
-
-//go:build unix
-
-package config
-
-import (
-	"fmt"
-	"os"
-	"os/exec"
-	"path/filepath"
-	"testing"
-	"time"
-)
-
-func TestConfigLock_CrossProcess(t *testing.T) {
-	// Create a temp directory for test
-	tmpDir, err := os.MkdirTemp("", "tea-lock-test")
-	if err != nil {
-		t.Fatalf("failed to create temp dir: %v", err)
-	}
-	defer os.RemoveAll(tmpDir)
-
-	lockPath := filepath.Join(tmpDir, "config.yml.lock")
-
-	// Acquire lock in main process
-	unlock, err := acquireConfigLock(lockPath, 5*time.Second)
-	if err != nil {
-		t.Fatalf("failed to acquire lock: %v", err)
-	}
-	defer unlock()
-
-	// Spawn a subprocess that tries to acquire the same lock
-	// The subprocess should fail to acquire within timeout
-	script := fmt.Sprintf(`
-package main
-
-import (
-	"os"
-	"syscall"
-)
-
-func main() {
-	file, err := os.OpenFile(%q, os.O_CREATE|os.O_RDWR, 0o600)
-	if err != nil {
-		os.Exit(2)
-	}
-	defer file.Close()
-
-	// Try non-blocking lock
-	err = syscall.Flock(int(file.Fd()), syscall.LOCK_EX|syscall.LOCK_NB)
-	if err != nil {
-		// Lock is held - expected behavior
-		os.Exit(0)
-	}
-	// Lock was acquired - unexpected
-	syscall.Flock(int(file.Fd()), syscall.LOCK_UN)
-	os.Exit(1)
-}
-`, lockPath)
-
-	// Write and run the test script
-	scriptPath := filepath.Join(tmpDir, "locktest.go")
-	if err := os.WriteFile(scriptPath, []byte(script), 0o600); err != nil {
-		t.Fatalf("failed to write test script: %v", err)
-	}
-
-	cmd := exec.Command("go", "run", scriptPath)
-	if err := cmd.Run(); err != nil {
-		if exitErr, ok := err.(*exec.ExitError); ok {
-			if exitErr.ExitCode() == 1 {
-				t.Error("subprocess acquired lock when it should have been held")
-			} else if exitErr.ExitCode() == 2 {
-				t.Errorf("subprocess failed to open lock file: %v", err)
-			}
-		} else {
-			t.Errorf("subprocess execution failed: %v", err)
-		}
-	}
-	// Exit code 0 means lock was properly held - success
-}

modules/config/testtools.go

@@ -0,0 +1,13 @@
+// Copyright 2026 The Gitea Authors. All rights reserved.
+// SPDX-License-Identifier: MIT
+
+//go:build testtools
+
+package config
+
+import "time"
+
+// AcquireConfigLockForTesting exposes the internal lock helper to integration tests.
+func AcquireConfigLockForTesting(lockPath string, timeout time.Duration) (func() error, error) {
+	return acquireConfigLock(lockPath, timeout)
+}

modules/context/context_test.go

@@ -4,14 +4,9 @@
 package context
 
 import (
-	"os"
-	"os/exec"
 	"testing"
 
 	"code.gitea.io/tea/modules/config"
-
-	"github.com/stretchr/testify/require"
-	"github.com/urfave/cli/v3"
 )
 
 func Test_MatchLogins(t *testing.T) {
@@ -70,47 +65,3 @@ func Test_MatchLogins(t *testing.T) {
 		})
 	}
 }
-
-func TestInitCommand_WithRepoSlugSkipsLocalRepoDetection(t *testing.T) {
-	tmpDir := t.TempDir()
-	config.SetConfigForTesting(config.LocalConfig{
-		Logins: []config.Login{{
-			Name:    "test-login",
-			URL:     "https://gitea.example.com",
-			Token:   "token",
-			User:    "login-user",
-			Default: true,
-		}},
-	})
-
-	cmd := exec.Command("git", "init", "--object-format=sha256", tmpDir)
-	cmd.Env = os.Environ()
-	require.NoError(t, cmd.Run())
-
-	oldWd, err := os.Getwd()
-	require.NoError(t, err)
-	require.NoError(t, os.Chdir(tmpDir))
-	t.Cleanup(func() {
-		require.NoError(t, os.Chdir(oldWd))
-	})
-
-	cliCmd := cli.Command{
-		Name: "branches",
-		Flags: []cli.Flag{
-			&cli.StringFlag{Name: "login"},
-			&cli.StringFlag{Name: "repo"},
-			&cli.StringFlag{Name: "remote"},
-			&cli.StringFlag{Name: "output"},
-		},
-	}
-	require.NoError(t, cliCmd.Set("repo", "owner/repo"))
-
-	ctx, err := InitCommand(&cliCmd)
-	require.NoError(t, err)
-	require.Equal(t, "owner", ctx.Owner)
-	require.Equal(t, "repo", ctx.Repo)
-	require.Equal(t, "owner/repo", ctx.RepoSlug)
-	require.Nil(t, ctx.LocalRepo)
-	require.NotNil(t, ctx.Login)
-	require.Equal(t, "test-login", ctx.Login.Name)
-}

modules/git/repo_test.go

@@ -1,63 +0,0 @@
-// Copyright 2025 The Gitea Authors. All rights reserved.
-// SPDX-License-Identifier: MIT
-
-package git
-
-import (
-	"os"
-	"os/exec"
-	"path/filepath"
-	"testing"
-
-	"github.com/stretchr/testify/assert"
-)
-
-func TestRepoFromPath_Worktree(t *testing.T) {
-	// Create a temporary directory for test
-	tmpDir, err := os.MkdirTemp("", "tea-worktree-test-*")
-	assert.NoError(t, err)
-	defer os.RemoveAll(tmpDir)
-
-	mainRepoPath := filepath.Join(tmpDir, "main-repo")
-	worktreePath := filepath.Join(tmpDir, "worktree")
-
-	// Initialize main repository
-	cmd := exec.Command("git", "init", mainRepoPath)
-	assert.NoError(t, cmd.Run())
-
-	// Configure git for the test
-	cmd = exec.Command("git", "-C", mainRepoPath, "config", "user.email", "test@example.com")
-	assert.NoError(t, cmd.Run())
-	cmd = exec.Command("git", "-C", mainRepoPath, "config", "user.name", "Test User")
-	assert.NoError(t, cmd.Run())
-
-	// Add a remote to the main repository
-	cmd = exec.Command("git", "-C", mainRepoPath, "remote", "add", "origin", "https://gitea.com/owner/repo.git")
-	assert.NoError(t, cmd.Run())
-
-	// Create an initial commit (required for worktree)
-	readmePath := filepath.Join(mainRepoPath, "README.md")
-	err = os.WriteFile(readmePath, []byte("# Test Repo\n"), 0o644)
-	assert.NoError(t, err)
-	cmd = exec.Command("git", "-C", mainRepoPath, "add", "README.md")
-	assert.NoError(t, cmd.Run())
-	cmd = exec.Command("git", "-C", mainRepoPath, "commit", "-m", "Initial commit")
-	assert.NoError(t, cmd.Run())
-
-	// Create a worktree
-	cmd = exec.Command("git", "-C", mainRepoPath, "worktree", "add", worktreePath, "-b", "test-branch")
-	assert.NoError(t, cmd.Run())
-
-	// Test: Open repository from worktree path
-	repo, err := RepoFromPath(worktreePath)
-	assert.NoError(t, err, "Should be able to open worktree")
-
-	// Test: Read config from worktree (should read from main repo's config)
-	config, err := repo.Config()
-	assert.NoError(t, err, "Should be able to read config")
-
-	// Verify that remotes are accessible from worktree
-	assert.NotEmpty(t, config.Remotes, "Should be able to read remotes from worktree")
-	assert.Contains(t, config.Remotes, "origin", "Should have origin remote")
-	assert.Equal(t, "https://gitea.com/owner/repo.git", config.Remotes["origin"].URLs[0], "Should have correct remote URL")
-}