mirror of
https://gitea.com/gitea/tea.git
synced 2026-10-26 11:01:25 +01:00
fix(auth): prompt for --with-token without echo on a terminal
With stdin on a terminal, auth login --with-token read the pasted token from the raw terminal, which echoed it in clear text without a prompt. It now asks with a hidden "Paste an access token" prompt, and refuses to read the terminal when prompting is disabled. Piped stdin is read as before. Signed-off-by: bircni <bircni@icloud.com>
This commit is contained in:
2 files changed
+33
-1
No files matched your search
@@ -87,6 +87,26 @@ func TestLoginValidatesUserEnvironmentWithFlagPrecedence(t *testing.T) {
|
||||
}
|
||||
}
|
||||
|
||||
func TestLoginWithTokenPromptsWithoutEchoOnATerminal(t *testing.T) {
|
||||
server := newAuthenticatedServer(http.NotFoundHandler())
|
||||
defer server.Close()
|
||||
args := []string{"auth", "login", "--host", server.URL, "--with-token", "--credential-store", "file"}
|
||||
deps, _, _ := testDeps(t)
|
||||
deps.Streams.In = strings.NewReader("echoed-token\n")
|
||||
deps.Streams.InTTY, deps.Streams.ErrTTY = true, true
|
||||
prompt := &scriptedPrompter{secret: " private-login-token "}
|
||||
deps.Prompter = prompt
|
||||
err := Execute(context.Background(), deps, append(args, "--no-input"))
|
||||
require.Equal(t, clierr.Usage, clierr.ExitCode(err), "%v", err)
|
||||
require.ErrorContains(t, err, "tea auth login --with-token < token.txt")
|
||||
require.Empty(t, prompt.secrets)
|
||||
require.NoError(t, Execute(context.Background(), deps, args))
|
||||
require.Equal(t, []string{"Paste an access token"}, prompt.secrets)
|
||||
credential, err := deps.Credentials.Load(server.URL, "alice", settings.StoreFile)
|
||||
require.NoError(t, err)
|
||||
require.Equal(t, "private-login-token", credential.AccessToken)
|
||||
}
|
||||
|
||||
func TestLoginInsecureInstance(t *testing.T) {
|
||||
server := httptest.NewUnstartedServer(http.HandlerFunc(func(w http.ResponseWriter, _ *http.Request) {
|
||||
_, _ = w.Write([]byte(`{"login":"alice"}`))
|
||||
|
||||
Reference in new issue
Block a user