mirror of
				https://gitea.com/gitea/tea.git
				synced 2025-10-31 01:05:26 +01:00 
			
		
		
		
	Improved list output (#281)
remove unused debug var move outputList into a struct so we can add additional functionality for all list output rename list output to table.go make table sortable sort milestones sort milestones descending remove unnecessary if Co-authored-by: Norwin Roosen <git@nroo.de> Reviewed-on: https://gitea.com/gitea/tea/pulls/281 Reviewed-by: khmarbaise <khmarbaise@noreply.gitea.io> Reviewed-by: 6543 <6543@obermui.de> Co-Authored-By: Norwin <noerw@noreply.gitea.io> Co-Committed-By: Norwin <noerw@noreply.gitea.io>
This commit is contained in:
		| @@ -26,20 +26,14 @@ func IssueDetails(issue *gitea.Issue) { | ||||
|  | ||||
| // IssuesList prints a listing of issues | ||||
| func IssuesList(issues []*gitea.Issue, output string) { | ||||
| 	var values [][]string | ||||
| 	headers := []string{ | ||||
| 	t := tableWithHeader( | ||||
| 		"Index", | ||||
| 		"Title", | ||||
| 		"State", | ||||
| 		"Author", | ||||
| 		"Milestone", | ||||
| 		"Updated", | ||||
| 	} | ||||
|  | ||||
| 	if len(issues) == 0 { | ||||
| 		outputList(output, headers, values) | ||||
| 		return | ||||
| 	} | ||||
| 	) | ||||
|  | ||||
| 	for _, issue := range issues { | ||||
| 		author := issue.Poster.FullName | ||||
| @@ -50,38 +44,29 @@ func IssuesList(issues []*gitea.Issue, output string) { | ||||
| 		if issue.Milestone != nil { | ||||
| 			mile = issue.Milestone.Title | ||||
| 		} | ||||
| 		values = append( | ||||
| 			values, | ||||
| 			[]string{ | ||||
| 				strconv.FormatInt(issue.Index, 10), | ||||
| 				issue.Title, | ||||
| 				string(issue.State), | ||||
| 				author, | ||||
| 				mile, | ||||
| 				FormatTime(issue.Updated), | ||||
| 			}, | ||||
| 		t.addRow( | ||||
| 			strconv.FormatInt(issue.Index, 10), | ||||
| 			issue.Title, | ||||
| 			string(issue.State), | ||||
| 			author, | ||||
| 			mile, | ||||
| 			FormatTime(issue.Updated), | ||||
| 		) | ||||
| 	} | ||||
| 	outputList(output, headers, values) | ||||
| 	t.print(output) | ||||
| } | ||||
|  | ||||
| // IssuesPullsList prints a listing of issues & pulls | ||||
| // TODO combine with IssuesList | ||||
| func IssuesPullsList(issues []*gitea.Issue, output string) { | ||||
| 	var values [][]string | ||||
| 	headers := []string{ | ||||
| 	t := tableWithHeader( | ||||
| 		"Index", | ||||
| 		"State", | ||||
| 		"Kind", | ||||
| 		"Author", | ||||
| 		"Updated", | ||||
| 		"Title", | ||||
| 	} | ||||
|  | ||||
| 	if len(issues) == 0 { | ||||
| 		outputList(output, headers, values) | ||||
| 		return | ||||
| 	} | ||||
| 	) | ||||
|  | ||||
| 	for _, issue := range issues { | ||||
| 		name := issue.Poster.FullName | ||||
| @@ -92,18 +77,15 @@ func IssuesPullsList(issues []*gitea.Issue, output string) { | ||||
| 		if issue.PullRequest != nil { | ||||
| 			kind = "Pull" | ||||
| 		} | ||||
| 		values = append( | ||||
| 			values, | ||||
| 			[]string{ | ||||
| 				strconv.FormatInt(issue.Index, 10), | ||||
| 				string(issue.State), | ||||
| 				kind, | ||||
| 				name, | ||||
| 				FormatTime(issue.Updated), | ||||
| 				issue.Title, | ||||
| 			}, | ||||
| 		t.addRow( | ||||
| 			strconv.FormatInt(issue.Index, 10), | ||||
| 			string(issue.State), | ||||
| 			kind, | ||||
| 			name, | ||||
| 			FormatTime(issue.Updated), | ||||
| 			issue.Title, | ||||
| 		) | ||||
| 	} | ||||
|  | ||||
| 	outputList(output, headers, values) | ||||
| 	t.print(output) | ||||
| } | ||||
|   | ||||
		Reference in New Issue
	
	Block a user
	 Norwin
					Norwin