From aee57be8b937aff84329c007a3699edf1bf6f382 Mon Sep 17 00:00:00 2001 From: bircni Date: Mon, 12 Oct 2026 20:45:54 +0200 Subject: [PATCH] test(repo,release): fold the repo delete report into the --yes test and drop redundant setup Signed-off-by: bircni --- internal/app/releases_test.go | 1 - internal/app/repo_mutations_test.go | 18 ++++-------------- internal/app/repos_test.go | 2 -- 3 files changed, 4 insertions(+), 17 deletions(-) diff --git a/internal/app/releases_test.go b/internal/app/releases_test.go index 02c6b6a9..2f38b04e 100644 --- a/internal/app/releases_test.go +++ b/internal/app/releases_test.go @@ -36,7 +36,6 @@ func TestReleaseViewShowsTheLatestReleaseWithNotesAndAssets(t *testing.T) { })) defer server.Close() deps, out, _ := repoTTYDeps(t, server.URL) - deps.Getenv = serverEnv(server.URL, map[string]string{"TERM": "dumb"}) rawMarkdown(t, deps) require.NoError(t, Execute(context.Background(), deps, []string{"release", "view", "-R", "alice/project"})) require.Equal(t, `First release v0.1.0 diff --git a/internal/app/repo_mutations_test.go b/internal/app/repo_mutations_test.go index fc8d1cb3..7bf63c1a 100644 --- a/internal/app/repo_mutations_test.go +++ b/internal/app/repo_mutations_test.go @@ -38,10 +38,12 @@ func TestRepoDeleteAndArchiveRequireExplicitRepositoryWithYes(t *testing.T) { require.ErrorContains(t, err, "--yes requires an explicit repository, not one inferred from git remote upstream: tea repo "+verb+" alice/project --yes") } require.Empty(t, requests) - deps, _, _ := serverDeps(t, server.URL) + deps, out, diagnostics := repoTTYDeps(t, server.URL) deps.Git = upstreamCheckout(server) - require.NoError(t, Execute(context.Background(), deps, []string{"repo", "delete", "alice/project", "--yes"})) + require.NoError(t, Execute(context.Background(), deps, []string{"repo", "rm", "alice/project", "--yes"})) require.Equal(t, []string{"DELETE /api/v1/repos/alice/project"}, requests) + require.Empty(t, out.String()) + require.Equal(t, "✓ Deleted repository alice/project\n", diagnostics.String()) } func TestRepoDeleteAsksToTypeTheRepositoryName(t *testing.T) { @@ -198,15 +200,3 @@ func TestRepoForkAddsTheForkAsOrigin(t *testing.T) { require.Equal(t, "✓ Forked bob/project to alice/mine\n✓ Renamed Git remote origin to upstream\n✓ Added Git remote origin for alice/mine\n", diagnostics.String()) require.Equal(t, "https://gitea.test/alice/mine\n", out.String()) } - -func TestRepoDeleteReportsTheDeletion(t *testing.T) { - server := newAuthenticatedServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) { - require.Equal(t, http.MethodDelete+" /api/v1/repos/alice/x", r.Method+" "+r.URL.Path) - w.WriteHeader(http.StatusNoContent) - })) - defer server.Close() - deps, out, diagnostics := repoTTYDeps(t, server.URL) - require.NoError(t, Execute(context.Background(), deps, []string{"repo", "rm", "alice/x", "--yes"})) - require.Empty(t, out.String()) - require.Equal(t, "✓ Deleted repository alice/x\n", diagnostics.String()) -} diff --git a/internal/app/repos_test.go b/internal/app/repos_test.go index e6d6491b..5946e25e 100644 --- a/internal/app/repos_test.go +++ b/internal/app/repos_test.go @@ -86,7 +86,6 @@ func TestRepoViewShowsStateAndReadme(t *testing.T) { })) defer server.Close() deps, out, _ := repoTTYDeps(t, server.URL) - deps.Getenv = serverEnv(server.URL, map[string]string{"TERM": "dumb"}) rawMarkdown(t, deps) require.NoError(t, Execute(context.Background(), deps, []string{"repo", "view", "bob/project", "--branch", "develop"})) require.Equal(t, `bob/project @@ -151,7 +150,6 @@ func TestRepoViewOfAnEmptyRepositorySkipsTheReadme(t *testing.T) { })) defer server.Close() deps, out, _ := repoTTYDeps(t, server.URL) - deps.Getenv = serverEnv(server.URL, map[string]string{"TERM": "dumb"}) rawMarkdown(t, deps) require.NoError(t, Execute(context.Background(), deps, []string{"repo", "view", "alice/empty"})) require.Contains(t, out.String(), "private • empty • ★ 0")