refactor: improve code quality and efficiency in various files (#548)

- Replace loadConfig() with _ = loadConfig()
- Update file permissions from 0660 to 0o660
- Simplify variable declarations
- Replace golang.org/x/crypto/ssh/terminal with golang.org/x/term
- Remove unused getCertPrincipals function
- Replace time.Now().Sub() with time.Since()
- Add test for ArgToIndex function

Signed-off-by: appleboy <appleboy.tw@gmail.com>

Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
Reviewed-on: https://gitea.com/gitea/tea/pulls/548
Reviewed-by: Lunny Xiao <xiaolunwen@gmail.com>
Reviewed-by: techknowlogick <techknowlogick@noreply.gitea.io>
Co-authored-by: appleboy <appleboy.tw@gmail.com>
Co-committed-by: appleboy <appleboy.tw@gmail.com>

modules/task/login_httpsign.go

@@ -91,15 +91,3 @@ func parseKeys(pkinput []byte, sshPath string) string {
 
 	return ssh.FingerprintSHA256(pkey) + " " + pkey.Type() + " " + comment + " (" + sshPath + ")"
 }
-
-func getCertPrincipals(pkey ssh.PublicKey) []string {
-	var principals []string
-
-	if cert, ok := pkey.(*ssh.Certificate); ok {
-		for _, principal := range cert.ValidPrincipals {
-			principals = append(principals, principal)
-		}
-	}
-
-	return principals
-}

modules/task/repo_clone.go

@@ -26,7 +26,6 @@ func RepoClone(
 	callback func(string) (string, error),
 	depth int,
 ) (*local_git.TeaRepo, error) {
-
 	repoMeta, _, err := login.Client().GetRepo(repoOwner, repoName)
 	if err != nil {
 		return nil, err
@@ -64,10 +63,14 @@ func RepoClone(
 			return nil, err
 		}
 		upstreamBranch := repoMeta.Parent.DefaultBranch
-		repo.CreateRemote(&git_config.RemoteConfig{
+		_, err = repo.CreateRemote(&git_config.RemoteConfig{
 			Name: "upstream",
 			URLs: []string{upstreamURL.String()},
 		})
+		if err != nil {
+			return nil, err
+		}
+
 		repoConf, err := repo.Config()
 		if err != nil {
 			return nil, err