replace log.Fatal/os.Exit with error returns (#941)

* Use stdlib encoders
* Reduce some duplication
* Remove global pagination state
* Dedupe JSON detail types
* Bump golangci-lint

Reviewed-on: https://gitea.com/gitea/tea/pulls/941
Co-authored-by: techknowlogick <techknowlogick@gitea.com>
Co-committed-by: techknowlogick <techknowlogick@gitea.com>

modules/print/table_test.go

@@ -5,10 +5,14 @@ package print
 
 import (
 	"bytes"
+	"encoding/csv"
 	"encoding/json"
+	"io"
 	"testing"
 
 	"github.com/stretchr/testify/assert"
+	"github.com/stretchr/testify/require"
+	"gopkg.in/yaml.v3"
 )
 
 func TestToSnakeCase(t *testing.T) {
@@ -29,7 +33,7 @@ func TestPrint(t *testing.T) {
 
 	buf := &bytes.Buffer{}
 
-	tData.fprint(buf, "json")
+	require.NoError(t, tData.fprint(buf, "json"))
 	result := []struct {
 		A string
 		B string
@@ -51,22 +55,62 @@ func TestPrint(t *testing.T) {
 
 	buf.Reset()
 
-	tData.fprint(buf, "yaml")
+	require.NoError(t, tData.fprint(buf, "yaml"))
 
-	assert.Equal(t, `-
-  A: 'new a'
-  B: 'some bbbb'
--
-  A: 'AAAAA'
-  B: 'b2'
--
-  A: '"abc'
-  B: '"def'
--
-  A: '''abc'
-  B: 'de''f'
--
-  A: '\abc'
-  B: '''def\'
-`, buf.String())
+	var yamlResult []map[string]string
+	require.NoError(t, yaml.Unmarshal(buf.Bytes(), &yamlResult))
+	assert.Equal(t, []map[string]string{
+		{"A": "new a", "B": "some bbbb"},
+		{"A": "AAAAA", "B": "b2"},
+		{"A": "\"abc", "B": "\"def"},
+		{"A": "'abc", "B": "de'f"},
+		{"A": "\\abc", "B": "'def\\"},
+	}, yamlResult)
+}
+
+func TestPrintCSVUsesEscaping(t *testing.T) {
+	tData := &table{
+		headers: []string{"A", "B"},
+		values: [][]string{
+			{"hello,world", `quote "here"`},
+			{"multi\nline", "plain"},
+		},
+	}
+
+	buf := &bytes.Buffer{}
+	require.NoError(t, tData.fprint(buf, "csv"))
+
+	reader := csv.NewReader(bytes.NewReader(buf.Bytes()))
+	records, err := reader.ReadAll()
+	require.NoError(t, err)
+	assert.Equal(t, [][]string{
+		{"A", "B"},
+		{"hello,world", `quote "here"`},
+		{"multi\nline", "plain"},
+	}, records)
+}
+
+func TestPrintJSONPreservesFieldOrder(t *testing.T) {
+	tData := &table{
+		headers: []string{"Zebra", "Apple", "Mango"},
+		values:  [][]string{{"z", "a", "m"}},
+	}
+
+	buf := &bytes.Buffer{}
+	require.NoError(t, tData.fprint(buf, "json"))
+
+	// Keys must appear in header order (Zebra, Apple, Mango), not sorted alphabetically
+	raw := buf.String()
+	zebraIdx := bytes.Index([]byte(raw), []byte(`"zebra"`))
+	appleIdx := bytes.Index([]byte(raw), []byte(`"apple"`))
+	mangoIdx := bytes.Index([]byte(raw), []byte(`"mango"`))
+	assert.Greater(t, appleIdx, zebraIdx, "apple should appear after zebra")
+	assert.Greater(t, mangoIdx, appleIdx, "mango should appear after apple")
+}
+
+func TestPrintUnknownOutputReturnsError(t *testing.T) {
+	tData := &table{headers: []string{"A"}, values: [][]string{{"value"}}}
+
+	err := tData.fprint(io.Discard, "unknown")
+	require.ErrorContains(t, err, `unknown output type "unknown"`)
 }