fix: do not ask for confirmation right after prompting for input

secret set, variable set, team create, webhook create and admin user
create asked a confirmation that defaults to No right after the user
typed the missing values, so pressing Enter discarded the input. They
now submit what the user entered; deletions still confirm.

Signed-off-by: bircni <bircni@icloud.com>
This commit is contained in:
bircni committed 2026-10-11 21:59:18 +02:00
1 parent fcfc497a77
commit b6b3ddc91b
6 files changed
+43 -29

No files matched your search

+1 -3
View File
@@ -78,7 +78,6 @@ func (a *application) actionValueCommand(secret bool) *cobra.Command {
if strings.EqualFold(name, "CI") || strings.HasPrefix(strings.ToUpper(name), "GITEA_") || strings.HasPrefix(strings.ToUpper(name), "GITHUB_") {
return clierr.Wrap(clierr.Usage, errors.New("CI and names beginning GITEA_ or GITHUB_ are reserved"))
}
prompted := false
if verb == "set" {
var err error
if value, err = a.readSecret(cmd, value, file, "value", "value-file"); err != nil {
@@ -100,7 +99,6 @@ func (a *application) actionValueCommand(secret bool) *cobra.Command {
if err != nil {
return err
}
prompted = true
}
if value == "" {
return clierr.Wrap(clierr.Usage, fmt.Errorf("%s value cannot be empty", kind))
@@ -113,7 +111,7 @@ func (a *application) actionValueCommand(secret bool) *cobra.Command {
if err != nil {
return err
}
if verb == "delete" || prompted {
if verb == "delete" {
if err := a.confirm(cmd, verb+" Actions "+kind+" "+name); err != nil {
return err
}