revert: tea 1.0 rewrite (#1122–#1126) (#1146)

Reverts #1126, #1125, #1124, #1123 and #1122. `go.mod` keeps the Go 1.26 line with toolchain `go1.26.9` (instead of the original `go1.26.6`) so the security fix from #1131 isn't lost. reopens #69 reopens #141 reopens #162 reopens #172 reopens #197 reopens #232 reopens #240 reopens #246 reopens #323 reopens #325 reopens #326 reopens #328 reopens #344 reopens #351 reopens #373 reopens #403 reopens #406 reopens #417 reopens #430 reopens #457 reopens #480 reopens #482 reopens #489 reopens #490 reopens #498 reopens #500 reopens #504 reopens #510 reopens #516 reopens #523 reopens #556 reopens #560 reopens #569 reopens #571 reopens #602 reopens #632 reopens #633 reopens #643 reopens #666 reopens #670 reopens #672 reopens #677 reopens #683 reopens #697 reopens #726 reopens #737 reopens #770 reopens #779 reopens #804 reopens #817 reopens #831 reopens #833 reopens #834 reopens #908 reopens #966 reopens #1023 reopens #1029 reopens #1032 reopens #1050 reopens #1052 reopens #1069 reopens #1073 reopens #1087 reopens #1091 reopens #1094 reopens #1110 reopens #1115 reopens #1116 reopens #1118 Reviewed-on: https://gitea.com/gitea/tea/pulls/1146 Reviewed-by: TheFox0x7 <95654+thefox0x7@noreply.gitea.com>
2026-10-26 11:01:25 +01:00 · 2026-10-18 20:56:33 +00:00
1 parent 33bb12729e
commit c5f674111a
@@ -0,0 +1,161 @@
+// Copyright 2026 The Gitea Authors. All rights reserved.
+// SPDX-License-Identifier: MIT
+
+package flags
+
+import (
+	"os"
+	"path/filepath"
+	"strings"
+	"testing"
+
+	"github.com/stretchr/testify/assert"
+	"github.com/stretchr/testify/require"
+)
+
+func TestResolveCreateBody(t *testing.T) {
+	file := filepath.Join(t.TempDir(), "body.md")
+	require.NoError(t, os.WriteFile(file, []byte("from file"), 0o600))
+
+	tests := []struct {
+		name               string
+		description        string
+		descriptionFile    string
+		descriptionFileSet bool
+		stdinPiped         bool
+		stdin              string
+		want               string
+	}{
+		{
+			name:        "description flag",
+			description: "from -d",
+			want:        "from -d",
+		},
+		{
+			name:               "description file",
+			descriptionFile:    file,
+			descriptionFileSet: true,
+			want:               "from file",
+		},
+		{
+			name:               "description file wins over description",
+			description:        "from -d",
+			descriptionFile:    file,
+			descriptionFileSet: true,
+			want:               "from file",
+		},
+		{
+			name:               "dash reads stdin",
+			descriptionFile:    "-",
+			descriptionFileSet: true,
+			stdin:              "from stdin",
+			want:               "from stdin",
+		},
+		{
+			name:        "description wins over piped stdin",
+			description: "from -d",
+			stdinPiped:  true,
+			stdin:       "from stdin",
+			want:        "from -d",
+		},
+		{
+			name:       "piped stdin",
+			stdinPiped: true,
+			stdin:      "from stdin",
+			want:       "from stdin",
+		},
+		{
+			name:        "empty description falls back to piped stdin",
+			description: "",
+			stdinPiped:  true,
+			stdin:       "from stdin",
+			want:        "from stdin",
+		},
+		{
+			name: "empty when no source provided",
+			want: "",
+		},
+	}
+
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			got, err := resolveCreateBody(tt.description, tt.descriptionFile, tt.descriptionFileSet, tt.stdinPiped, strings.NewReader(tt.stdin))
+			require.NoError(t, err)
+			assert.Equal(t, tt.want, got)
+		})
+	}
+}
+
+func TestResolveEditBody(t *testing.T) {
+	file := filepath.Join(t.TempDir(), "body.md")
+	require.NoError(t, os.WriteFile(file, []byte("from file"), 0o600))
+
+	tests := []struct {
+		name               string
+		description        string
+		descriptionSet     bool
+		descriptionFile    string
+		descriptionFileSet bool
+		stdin              string
+		wantBody           string
+		wantSet            bool
+	}{
+		{
+			name: "no description flag",
+		},
+		{
+			name:           "description flag",
+			description:    "from -d",
+			descriptionSet: true,
+			wantBody:       "from -d",
+			wantSet:        true,
+		},
+		{
+			name:           "empty description clears body",
+			descriptionSet: true,
+			wantSet:        true,
+		},
+		{
+			name:               "description file",
+			descriptionFile:    file,
+			descriptionFileSet: true,
+			wantBody:           "from file",
+			wantSet:            true,
+		},
+		{
+			name:               "description file wins over description",
+			description:        "from -d",
+			descriptionSet:     true,
+			descriptionFile:    file,
+			descriptionFileSet: true,
+			wantBody:           "from file",
+			wantSet:            true,
+		},
+		{
+			name:               "dash reads stdin",
+			descriptionFile:    "-",
+			descriptionFileSet: true,
+			stdin:              "from stdin",
+			wantBody:           "from stdin",
+			wantSet:            true,
+		},
+	}
+
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			got, err := resolveEditBody(tt.description, tt.descriptionSet, tt.descriptionFile, tt.descriptionFileSet, strings.NewReader(tt.stdin))
+			require.NoError(t, err)
+			if !tt.wantSet {
+				assert.Nil(t, got)
+				return
+			}
+			require.NotNil(t, got)
+			assert.Equal(t, tt.wantBody, *got)
+		})
+	}
+}
+
+func TestResolveDescriptionSourceError(t *testing.T) {
+	_, err := resolveCreateBody("", filepath.Join(t.TempDir(), "missing.md"), true, false, strings.NewReader(""))
+	require.ErrorContains(t, err, "could not read description file")
+}