revert: tea 1.0 rewrite (#1122–#1126) (#1146)

Reverts #1126, #1125, #1124, #1123 and #1122. `go.mod` keeps the Go 1.26 line with toolchain `go1.26.9` (instead of the original `go1.26.6`) so the security fix from #1131 isn't lost. reopens #69 reopens #141 reopens #162 reopens #172 reopens #197 reopens #232 reopens #240 reopens #246 reopens #323 reopens #325 reopens #326 reopens #328 reopens #344 reopens #351 reopens #373 reopens #403 reopens #406 reopens #417 reopens #430 reopens #457 reopens #480 reopens #482 reopens #489 reopens #490 reopens #498 reopens #500 reopens #504 reopens #510 reopens #516 reopens #523 reopens #556 reopens #560 reopens #569 reopens #571 reopens #602 reopens #632 reopens #633 reopens #643 reopens #666 reopens #670 reopens #672 reopens #677 reopens #683 reopens #697 reopens #726 reopens #737 reopens #770 reopens #779 reopens #804 reopens #817 reopens #831 reopens #833 reopens #834 reopens #908 reopens #966 reopens #1023 reopens #1029 reopens #1032 reopens #1050 reopens #1052 reopens #1069 reopens #1073 reopens #1087 reopens #1091 reopens #1094 reopens #1110 reopens #1115 reopens #1116 reopens #1118 Reviewed-on: https://gitea.com/gitea/tea/pulls/1146 Reviewed-by: TheFox0x7 <95654+thefox0x7@noreply.gitea.com>
2026-10-26 19:11:25 +01:00 · 2026-10-18 20:56:33 +00:00
1 parent 33bb12729e
commit c5f674111a
@@ -0,0 +1,152 @@
+// Copyright 2025 The Gitea Authors. All rights reserved.
+// SPDX-License-Identifier: MIT
+
+package flags
+
+import (
+	"context"
+	"io"
+	"testing"
+
+	gitea "gitea.dev/sdk"
+	"github.com/stretchr/testify/assert"
+	"github.com/stretchr/testify/require"
+	"github.com/urfave/cli/v3"
+)
+
+func TestPaginationFlags(t *testing.T) {
+	var (
+		defaultPage  = PaginationPageFlag.Value
+		defaultLimit = PaginationLimitFlag.Value
+	)
+
+	cases := []struct {
+		name          string
+		args          []string
+		expectedPage  int
+		expectedLimit int
+	}{
+		{
+			name:          "no flags",
+			args:          []string{"test"},
+			expectedPage:  defaultPage,
+			expectedLimit: defaultLimit,
+		},
+		{
+			name:          "only paging",
+			args:          []string{"test", "--page", "5"},
+			expectedPage:  5,
+			expectedLimit: defaultLimit,
+		},
+		{
+			name:          "only limit",
+			args:          []string{"test", "--limit", "10"},
+			expectedPage:  defaultPage,
+			expectedLimit: 10,
+		},
+		{
+			name:          "only limit",
+			args:          []string{"test", "--limit", "10"},
+			expectedPage:  defaultPage,
+			expectedLimit: 10,
+		},
+		{
+			name:          "both flags",
+			args:          []string{"test", "--page", "2", "--limit", "20"},
+			expectedPage:  2,
+			expectedLimit: 20,
+		},
+		{ // TODO: Should no paging be applied as -1 or a separate flag? It's not obvious that page=-1 turns off paging and limit is ignored
+			name:          "no paging",
+			args:          []string{"test", "--limit", "20", "--page", "-1"},
+			expectedPage:  -1,
+			expectedLimit: 20,
+		},
+	}
+
+	for _, tc := range cases {
+		t.Run(tc.name, func(t *testing.T) {
+			cmd := cli.Command{
+				Name: "test-paging",
+				Action: func(_ context.Context, cmd *cli.Command) error {
+					assert.Equal(t, tc.expectedPage, cmd.Int("page"))
+					assert.Equal(t, tc.expectedLimit, cmd.Int("limit"))
+					return nil
+				},
+				Flags: PaginationFlags,
+			}
+			err := cmd.Run(t.Context(), tc.args)
+			require.NoError(t, err)
+		})
+	}
+}
+
+func TestPaginationFailures(t *testing.T) {
+	cases := []struct {
+		name          string
+		args          []string
+		expectedError error
+	}{
+		{
+			name:          "negative limit",
+			args:          []string{"test", "--limit", "-10"},
+			expectedError: ErrLimit,
+		},
+		{
+			name:          "negative paging",
+			args:          []string{"test", "--page", "-2"},
+			expectedError: ErrPage,
+		},
+		{
+			name:          "zero paging",
+			args:          []string{"test", "--page", "0"},
+			expectedError: ErrPage,
+		},
+		{
+			// urfave does not validate all flags in one pass
+			name:          "negative paging and paging",
+			args:          []string{"test", "--page", "-2", "--limit", "-10"},
+			expectedError: ErrPage,
+		},
+	}
+
+	for _, tc := range cases {
+		cmd := cli.Command{
+			Name:      "test-paging",
+			Flags:     PaginationFlags,
+			Writer:    io.Discard,
+			ErrWriter: io.Discard,
+		}
+		t.Run(tc.name, func(t *testing.T) {
+			err := cmd.Run(t.Context(), tc.args)
+			require.ErrorContains(t, err, tc.expectedError.Error())
+			// require.ErrorIs(t, err, tc.expectedError)
+		})
+	}
+}
+
+func TestGetListOptionsDoesNotLeakBetweenCommands(t *testing.T) {
+	var results []gitea.ListOptions
+
+	run := func(args []string) {
+		t.Helper()
+
+		cmd := cli.Command{
+			Name: "test-paging",
+			Action: func(_ context.Context, cmd *cli.Command) error {
+				results = append(results, GetListOptions(cmd))
+				return nil
+			},
+			Flags: PaginationFlags,
+		}
+
+		require.NoError(t, cmd.Run(t.Context(), args))
+	}
+
+	run([]string{"test", "--page", "5", "--limit", "10"})
+	run([]string{"test"})
+
+	require.Len(t, results, 2)
+	assert.Equal(t, gitea.ListOptions{Page: 5, PageSize: 10}, results[0])
+	assert.Equal(t, gitea.ListOptions{Page: defaultPageValue, PageSize: defaultLimitValue}, results[1])
+}