Git/gitea-tea
1
0 Fork 0
mirror of https://gitea.com/gitea/tea.git synced 2026-10-26 11:01:25 +01:00
Code Issues Packages Projects Releases Wiki Activity

fix(org,team): guard the owner team rename, show permission-only team access and tidy member lookups

Browse Source 
Signed-off-by: bircni <bircni@icloud.com>
This commit is contained in:
bircni committed 2026-10-18 20:02:11 +02:00
1 parent dd9e05c6b9
commit dfb56eae67
10 files changed
+124 -12
Download Patch File Download Diff File Expand all files Collapse all files

No files matched your search

internal/services/teams_test.go
+15 -1
View File
@@ -102,7 +102,7 @@ func TestTeamAccessRequests(t *testing.T) {
service := Teams{Client: client}
members, err := service.Members(context.Background(), 3, 5, 2)
require.NoError(t, err)
require.Equal(t, []OrganizationMember{{ID: 2, Username: "bob"}}, members.Items)
require.Equal(t, []TeamMember{{ID: 2, Username: "bob"}}, members.Items)
repos, err := service.Repositories(context.Background(), 3, 5, 1)
require.NoError(t, err)
require.Equal(t, "https://gitea.test/acme/project", repos.Items[0].URL)
@@ -119,6 +119,15 @@ func TestTeamFromKeepsAbsentValuesEmpty(t *testing.T) {
require.Equal(t, Team{ID: 1, Name: "Owners", Permission: "owner", Units: map[string]string{}}, item)
}
func TestTeamUnitLevelAppliesThePermissionToEveryUnit(t *testing.T) {
team := Team{Permission: "write", Units: map[string]string{"repo.wiki": "none"}}
require.Equal(t, "write", team.UnitLevel("repo.code"))
require.Equal(t, "write", team.UnitLevel("repo.wiki"))
require.Equal(t, "read", team.UnitLevel("repo.ext_wiki"))
require.Equal(t, "write", Team{Permission: "none", Units: map[string]string{"repo.code": "write"}}.UnitLevel("repo.code"))
require.Equal(t, "none", Team{Permission: "none"}.UnitLevel("repo.code"))
}
func TestTeamAccessSummarizesUnits(t *testing.T) {
for _, tc := range []struct {
permission string
@@ -132,6 +141,11 @@ func TestTeamAccessSummarizesUnits(t *testing.T) {
{"none", map[string]string{"repo.code": "write", "repo.issues": "write", "repo.pulls": "write", "repo.wiki": "none", "repo.ext_wiki": "read"}, "write (code, issues, pulls)"},
{"none", map[string]string{"repo.code": "write", "repo.wiki": "read"}, "custom"},
{"none", map[string]string{"repo.ext_issues": "read"}, "none"},
// Gitea grants the team permission on every unit when the team has no unit rows.
{"write", nil, "write"},
{"read", map[string]string{}, "read"},
{"write", map[string]string{"repo.wiki": "read"}, "write"},
{"read", map[string]string{"repo.code": "write"}, "custom"},
} {
require.Equal(t, tc.want, Team{Permission: tc.permission, Units: tc.units}.Access(), "%v", tc.units)
}