mirror of
https://gitea.com/gitea/tea.git
synced 2026-10-26 11:01:25 +01:00
feat!: rebuild tea on Cobra with explicit noun/verb commands (#1126)
- **switch tea to the Cobra command tree:** `internal/app` wires the packages from parts 1–4 into explicit noun/verb commands with `--repo`, `--json` / `--jq`, `--sudo` and `--debug`; `main.go` points at it. Build, release and docs tooling (`tools/cli-docs`, Makefile, goreleaser, snap, CI) and README / CONTRIBUTING are updated. - **remove the urfave/cli command tree:** deletes `cmd/`, `modules/`, the old integration tests, contrib completion scripts and the generated `docs/CLI.md`, and drops their dependencies. This commit only deletes. ## Breaking changes This is a breaking release. It requires Gitea 28 or newer; configuration moves to separate `config.yml` and `hosts.yml` files and requires fresh authentication, and command names, aliases, flags and output formats change. `docs/migration-1.0.md` maps every old command, flag and environment variable to its replacement. ## Issues fixes #1118 fixes #1116 fixes #1115 fixes #1094 fixes #1091 fixes #1073 fixes #1052 fixes #1032 fixes #1023 fixes #966 fixes #908 fixes #833 fixes #831 fixes #817 fixes #804 fixes #779 fixes #770 fixes #737 fixes #697 fixes #726 fixes #677 fixes #672 fixes #633 fixes #632 fixes #560 fixes #556 fixes #523 fixes #516 fixes #510 fixes #504 fixes #500 fixes #482 fixes #406 fixes #403 fixes #373 fixes #351 fixes #344 fixes #326 fixes #325 fixes #323 fixes #246 fixes #240 fixes #232 fixes #197 fixes #172 fixes #141 fixes #69 fixes #1110 fixes #569 fixes #480 fixes #666 fixes #670 fixes #457 fixes #643 fixes #498 fixes #490 fixes #1069 fixes #834 fixes #602 fixes #328 fixes #417 fixes #571 fixes #1029 fixes #489 fixes #1050 fixes #162 fixes #430 fixes #1087 fixes #683 Reviewed-on: https://gitea.com/gitea/tea/pulls/1126 Reviewed-by: TheFox0x7 <95654+thefox0x7@noreply.gitea.com>
This commit is contained in:
1 parent
12e415a7a7
commit
f02245449b
456 files changed
+18892
-34015
No files matched your search
@@ -1,108 +0,0 @@
|
||||
// Copyright 2024 The Gitea Authors. All rights reserved.
|
||||
// SPDX-License-Identifier: MIT
|
||||
|
||||
package variables
|
||||
|
||||
import (
|
||||
stdctx "context"
|
||||
"fmt"
|
||||
"regexp"
|
||||
|
||||
"gitea.dev/tea/cmd/flags"
|
||||
"gitea.dev/tea/modules/context"
|
||||
"gitea.dev/tea/modules/utils"
|
||||
|
||||
"github.com/urfave/cli/v3"
|
||||
)
|
||||
|
||||
// CmdVariablesSet represents a sub command to set action variables
|
||||
var CmdVariablesSet = cli.Command{
|
||||
Name: "set",
|
||||
Aliases: []string{"create", "update"},
|
||||
Usage: "Set an action variable",
|
||||
Description: "Set a variable for use in repository actions and workflows",
|
||||
ArgsUsage: "<variable-name> [variable-value]",
|
||||
Action: runVariablesSet,
|
||||
Flags: append([]cli.Flag{
|
||||
&cli.StringFlag{
|
||||
Name: "file",
|
||||
Usage: "read variable value from file",
|
||||
},
|
||||
&cli.BoolFlag{
|
||||
Name: "stdin",
|
||||
Usage: "read variable value from stdin",
|
||||
},
|
||||
}, flags.AllDefaultFlags...),
|
||||
}
|
||||
|
||||
func runVariablesSet(ctx stdctx.Context, cmd *cli.Command) error {
|
||||
if cmd.Args().Len() == 0 {
|
||||
return fmt.Errorf("variable name is required")
|
||||
}
|
||||
|
||||
c, err := context.InitCommand(cmd)
|
||||
if err != nil {
|
||||
return err
|
||||
}
|
||||
if err := c.Ensure(context.CtxRequirement{RemoteRepo: true}); err != nil {
|
||||
return err
|
||||
}
|
||||
client := c.Login.Client()
|
||||
|
||||
variableName := cmd.Args().First()
|
||||
if err := validateVariableName(variableName); err != nil {
|
||||
return err
|
||||
}
|
||||
|
||||
// Read variable value using the utility
|
||||
variableValue, err := utils.ReadValue(cmd, utils.ReadValueOptions{
|
||||
ResourceName: "variable",
|
||||
PromptMsg: fmt.Sprintf("Enter variable value for '%s'", variableName),
|
||||
Hidden: false,
|
||||
AllowEmpty: false,
|
||||
})
|
||||
if err != nil {
|
||||
return err
|
||||
}
|
||||
|
||||
if err := validateVariableValue(variableValue); err != nil {
|
||||
return err
|
||||
}
|
||||
|
||||
_, err = client.Actions.CreateRepoVariable(ctx, c.Owner, c.Repo, variableName, variableValue)
|
||||
if err != nil {
|
||||
return err
|
||||
}
|
||||
|
||||
fmt.Printf("Variable '%s' set successfully\n", variableName)
|
||||
return nil
|
||||
}
|
||||
|
||||
// validateVariableName validates that a variable name follows the required format
|
||||
func validateVariableName(name string) error {
|
||||
if name == "" {
|
||||
return fmt.Errorf("variable name cannot be empty")
|
||||
}
|
||||
|
||||
// Variable names can contain letters (upper/lower), numbers, and underscores
|
||||
// Cannot start with a number
|
||||
// Cannot contain spaces or special characters (except underscore)
|
||||
validPattern := regexp.MustCompile(`^[A-Za-z_][A-Za-z0-9_]*$`)
|
||||
if !validPattern.MatchString(name) {
|
||||
return fmt.Errorf("variable name must contain only letters, numbers, and underscores, and cannot start with a number")
|
||||
}
|
||||
|
||||
return nil
|
||||
}
|
||||
|
||||
// validateVariableValue validates that a variable value is acceptable
|
||||
func validateVariableValue(value string) error {
|
||||
// Variables can be empty or contain whitespace, unlike secrets
|
||||
|
||||
// Check for maximum size (64KB limit)
|
||||
if len(value) > 65536 {
|
||||
return fmt.Errorf("variable value cannot exceed 64KB")
|
||||
}
|
||||
|
||||
return nil
|
||||
}
|
||||
Reference in new issue
Block a user