mirror of
https://gitea.com/gitea/tea.git
synced 2026-10-26 11:01:25 +01:00
feat!: rebuild tea on Cobra with explicit noun/verb commands (#1126)
- **switch tea to the Cobra command tree:** `internal/app` wires the packages from parts 1–4 into explicit noun/verb commands with `--repo`, `--json` / `--jq`, `--sudo` and `--debug`; `main.go` points at it. Build, release and docs tooling (`tools/cli-docs`, Makefile, goreleaser, snap, CI) and README / CONTRIBUTING are updated. - **remove the urfave/cli command tree:** deletes `cmd/`, `modules/`, the old integration tests, contrib completion scripts and the generated `docs/CLI.md`, and drops their dependencies. This commit only deletes. ## Breaking changes This is a breaking release. It requires Gitea 28 or newer; configuration moves to separate `config.yml` and `hosts.yml` files and requires fresh authentication, and command names, aliases, flags and output formats change. `docs/migration-1.0.md` maps every old command, flag and environment variable to its replacement. ## Issues fixes #1118 fixes #1116 fixes #1115 fixes #1094 fixes #1091 fixes #1073 fixes #1052 fixes #1032 fixes #1023 fixes #966 fixes #908 fixes #833 fixes #831 fixes #817 fixes #804 fixes #779 fixes #770 fixes #737 fixes #697 fixes #726 fixes #677 fixes #672 fixes #633 fixes #632 fixes #560 fixes #556 fixes #523 fixes #516 fixes #510 fixes #504 fixes #500 fixes #482 fixes #406 fixes #403 fixes #373 fixes #351 fixes #344 fixes #326 fixes #325 fixes #323 fixes #246 fixes #240 fixes #232 fixes #197 fixes #172 fixes #141 fixes #69 fixes #1110 fixes #569 fixes #480 fixes #666 fixes #670 fixes #457 fixes #643 fixes #498 fixes #490 fixes #1069 fixes #834 fixes #602 fixes #328 fixes #417 fixes #571 fixes #1029 fixes #489 fixes #1050 fixes #162 fixes #430 fixes #1087 fixes #683 Reviewed-on: https://gitea.com/gitea/tea/pulls/1126 Reviewed-by: TheFox0x7 <95654+thefox0x7@noreply.gitea.com>
This commit is contained in:
bircni committed
1 parent
12e415a7a7
commit
f02245449b
456 files changed
+18892
-34015
No files matched your search
@@ -1,220 +0,0 @@
|
||||
// Copyright 2025 The Gitea Authors. All rights reserved.
|
||||
// SPDX-License-Identifier: MIT
|
||||
|
||||
package users
|
||||
|
||||
import (
|
||||
stdctx "context"
|
||||
"fmt"
|
||||
"io"
|
||||
"os"
|
||||
"strings"
|
||||
"syscall"
|
||||
|
||||
gitea "gitea.dev/sdk"
|
||||
|
||||
"gitea.dev/tea/cmd/flags"
|
||||
"gitea.dev/tea/modules/context"
|
||||
"gitea.dev/tea/modules/print"
|
||||
"github.com/urfave/cli/v3"
|
||||
"golang.org/x/term"
|
||||
)
|
||||
|
||||
// CmdUserCreate represents a sub command of users to create a user
|
||||
var CmdUserCreate = cli.Command{
|
||||
Name: "create",
|
||||
Aliases: []string{"add", "new"},
|
||||
Usage: "Create a new user",
|
||||
Description: "Create a new user account",
|
||||
ArgsUsage: " ", // command does not accept arguments
|
||||
Action: RunUserCreate,
|
||||
Flags: append([]cli.Flag{
|
||||
&cli.StringFlag{
|
||||
Name: "username",
|
||||
Aliases: []string{"u"},
|
||||
Usage: "Username for the new user (required)",
|
||||
Required: true,
|
||||
},
|
||||
&cli.StringFlag{
|
||||
Name: "password",
|
||||
Aliases: []string{"p"},
|
||||
Usage: "Password for the new user (will prompt if not provided)",
|
||||
},
|
||||
&cli.StringFlag{
|
||||
Name: "password-file",
|
||||
Usage: "Read password from file",
|
||||
},
|
||||
&cli.BoolFlag{
|
||||
Name: "password-stdin",
|
||||
Usage: "Read password from stdin",
|
||||
},
|
||||
&cli.StringFlag{
|
||||
Name: "email",
|
||||
Aliases: []string{"e"},
|
||||
Usage: "Email address for the new user (required)",
|
||||
Required: true,
|
||||
},
|
||||
&cli.StringFlag{
|
||||
Name: "full-name",
|
||||
Usage: "Full name for the new user",
|
||||
},
|
||||
&cli.BoolFlag{
|
||||
Name: "admin",
|
||||
Usage: "Make the user an administrator",
|
||||
},
|
||||
&cli.BoolFlag{
|
||||
Name: "restricted",
|
||||
Usage: "Make the user restricted",
|
||||
},
|
||||
&cli.BoolFlag{
|
||||
Name: "prohibit-login",
|
||||
Usage: "Prohibit the user from logging in",
|
||||
},
|
||||
&cli.BoolFlag{
|
||||
Name: "no-must-change-password",
|
||||
Usage: "Don't require the user to change password on first login (default: password change required)",
|
||||
},
|
||||
&cli.StringFlag{
|
||||
Name: "visibility",
|
||||
Usage: "Visibility of the user profile (public, limited, private)",
|
||||
Value: "public",
|
||||
},
|
||||
}, flags.AllDefaultFlags...),
|
||||
}
|
||||
|
||||
// RunUserCreate creates a new user
|
||||
func RunUserCreate(requestCtx stdctx.Context, cmd *cli.Command) error {
|
||||
ctx, err := context.InitCommand(cmd)
|
||||
if err != nil {
|
||||
return err
|
||||
}
|
||||
|
||||
username := ctx.String("username")
|
||||
password := ctx.String("password")
|
||||
email := ctx.String("email")
|
||||
fullName := ctx.String("full-name")
|
||||
isAdmin := ctx.Bool("admin")
|
||||
restricted := ctx.Bool("restricted")
|
||||
prohibitLogin := ctx.Bool("prohibit-login")
|
||||
noMustChangePassword := ctx.Bool("no-must-change-password")
|
||||
visibility := ctx.String("visibility")
|
||||
|
||||
// Get password from various sources in priority order
|
||||
if password == "" {
|
||||
if ctx.String("password-file") != "" {
|
||||
// Read from file
|
||||
content, err := os.ReadFile(ctx.String("password-file"))
|
||||
if err != nil {
|
||||
return fmt.Errorf("failed to read password file: %w", err)
|
||||
}
|
||||
password = strings.TrimSpace(string(content))
|
||||
} else if ctx.Bool("password-stdin") {
|
||||
// Read from stdin
|
||||
content, err := io.ReadAll(os.Stdin)
|
||||
if err != nil {
|
||||
return fmt.Errorf("failed to read password from stdin: %w", err)
|
||||
}
|
||||
password = strings.TrimSpace(string(content))
|
||||
} else {
|
||||
// Interactive prompt (hidden input)
|
||||
fmt.Printf("Enter password for '%s': ", username)
|
||||
bytePassword, err := term.ReadPassword(int(syscall.Stdin))
|
||||
if err != nil {
|
||||
return fmt.Errorf("failed to read password: %w", err)
|
||||
}
|
||||
fmt.Println() // Add newline after hidden input
|
||||
password = string(bytePassword)
|
||||
|
||||
if password == "" {
|
||||
return fmt.Errorf("password cannot be empty")
|
||||
}
|
||||
|
||||
// Confirm password (only for interactive mode)
|
||||
fmt.Printf("Confirm password for '%s': ", username)
|
||||
bytePasswordConfirm, err := term.ReadPassword(int(syscall.Stdin))
|
||||
if err != nil {
|
||||
return fmt.Errorf("failed to read password confirmation: %w", err)
|
||||
}
|
||||
fmt.Println() // Add newline after hidden input
|
||||
passwordConfirm := string(bytePasswordConfirm)
|
||||
|
||||
if password != passwordConfirm {
|
||||
return fmt.Errorf("passwords do not match")
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
if password == "" {
|
||||
return fmt.Errorf("password cannot be empty")
|
||||
}
|
||||
|
||||
if email == "" {
|
||||
return fmt.Errorf("email is required")
|
||||
}
|
||||
|
||||
client := ctx.Login.Client()
|
||||
|
||||
// Build create options
|
||||
createOpts := gitea.CreateUserOption{
|
||||
LoginName: username,
|
||||
Username: username,
|
||||
Password: password,
|
||||
Email: email,
|
||||
FullName: fullName,
|
||||
SendNotify: false,
|
||||
}
|
||||
|
||||
// Set must change password flag (pointer to bool required)
|
||||
// By default, require user to change password on first login
|
||||
// Only set to false if --no-must-change-password flag is explicitly set
|
||||
mustChangePassword := !noMustChangePassword
|
||||
createOpts.MustChangePassword = &mustChangePassword
|
||||
|
||||
vis, err := parseUserVisibility(visibility)
|
||||
if err != nil {
|
||||
return err
|
||||
}
|
||||
createOpts.Visibility = vis
|
||||
|
||||
// Create the user
|
||||
user, _, err := client.Admin.CreateUser(requestCtx, createOpts)
|
||||
if err != nil {
|
||||
return err
|
||||
}
|
||||
|
||||
// Admin, Restricted, and ProhibitLogin cannot be set during user creation
|
||||
// We need to update them via AdminEditUser after creation if any of these flags are set
|
||||
if isAdmin || restricted || prohibitLogin {
|
||||
editOpts := gitea.EditUserOption{
|
||||
LoginName: username, // Required field
|
||||
}
|
||||
|
||||
if isAdmin {
|
||||
editOpts.Admin = &isAdmin
|
||||
}
|
||||
|
||||
if restricted {
|
||||
editOpts.Restricted = &restricted
|
||||
}
|
||||
|
||||
if prohibitLogin {
|
||||
editOpts.ProhibitLogin = &prohibitLogin
|
||||
}
|
||||
|
||||
// Update user with admin/restricted/prohibit-login settings
|
||||
_, err = client.Admin.EditUser(requestCtx, username, editOpts)
|
||||
if err != nil {
|
||||
return fmt.Errorf("user created but failed to update admin/restricted/prohibit-login status: %w", err)
|
||||
}
|
||||
|
||||
// Refresh user info to reflect the changes
|
||||
user, _, err = client.Users.GetUserInfo(requestCtx, username)
|
||||
if err != nil {
|
||||
return fmt.Errorf("user updated but failed to retrieve updated user info: %w", err)
|
||||
}
|
||||
}
|
||||
|
||||
print.UserDetails(user)
|
||||
|
||||
return nil
|
||||
}
|
||||
Reference in new issue
Block a user