feat!: rebuild tea on Cobra with explicit noun/verb commands (#1126)

- **switch tea to the Cobra command tree:** `internal/app` wires the packages from parts 1–4 into explicit noun/verb commands with `--repo`, `--json` / `--jq`, `--sudo` and `--debug`; `main.go` points at it. Build, release and docs tooling (`tools/cli-docs`, Makefile, goreleaser, snap, CI) and README / CONTRIBUTING are updated. - **remove the urfave/cli command tree:** deletes `cmd/`, `modules/`, the old integration tests, contrib completion scripts and the generated `docs/CLI.md`, and drops their dependencies. This commit only deletes. ## Breaking changes This is a breaking release. It requires Gitea 28 or newer; configuration moves to separate `config.yml` and `hosts.yml` files and requires fresh authentication, and command names, aliases, flags and output formats change. `docs/migration-1.0.md` maps every old command, flag and environment variable to its replacement. ## Issues fixes #1118 fixes #1116 fixes #1115 fixes #1094 fixes #1091 fixes #1073 fixes #1052 fixes #1032 fixes #1023 fixes #966 fixes #908 fixes #833 fixes #831 fixes #817 fixes #804 fixes #779 fixes #770 fixes #737 fixes #697 fixes #726 fixes #677 fixes #672 fixes #633 fixes #632 fixes #560 fixes #556 fixes #523 fixes #516 fixes #510 fixes #504 fixes #500 fixes #482 fixes #406 fixes #403 fixes #373 fixes #351 fixes #344 fixes #326 fixes #325 fixes #323 fixes #246 fixes #240 fixes #232 fixes #197 fixes #172 fixes #141 fixes #69 fixes #1110 fixes #569 fixes #480 fixes #666 fixes #670 fixes #457 fixes #643 fixes #498 fixes #490 fixes #1069 fixes #834 fixes #602 fixes #328 fixes #417 fixes #571 fixes #1029 fixes #489 fixes #1050 fixes #162 fixes #430 fixes #1087 fixes #683 Reviewed-on: https://gitea.com/gitea/tea/pulls/1126 Reviewed-by: TheFox0x7 <95654+thefox0x7@noreply.gitea.com>
2026-10-26 11:01:25 +01:00 · 2026-10-11 17:23:06 +00:00
1 parent 12e415a7a7
commit f02245449b
@@ -1,101 +0,0 @@
-// Copyright 2026 The Gitea Authors. All rights reserved.
-// SPDX-License-Identifier: MIT
-
-package comments
-
-import (
-	"io"
-	"strings"
-	"testing"
-
-	"github.com/stretchr/testify/assert"
-	"github.com/stretchr/testify/require"
-)
-
-func TestResolveBody(t *testing.T) {
-	testCases := []struct {
-		name        string
-		positional  string
-		description string
-		stdinPiped  bool
-		stdin       string
-		expected    string
-	}{
-		{
-			name:       "positional only",
-			positional: "from positional",
-			expected:   "from positional",
-		},
-		{
-			name:        "description flag only",
-			description: "from -d",
-			expected:    "from -d",
-		},
-		{
-			name:        "positional wins over description for back-compat",
-			positional:  "from positional",
-			description: "from -d",
-			expected:    "from positional",
-		},
-		{
-			name:        "description wins over piped stdin",
-			description: "from -d",
-			stdinPiped:  true,
-			stdin:       "from stdin",
-			expected:    "from -d",
-		},
-		{
-			name:       "piped stdin used when nothing else given",
-			stdinPiped: true,
-			stdin:      "from stdin",
-			expected:   "from stdin",
-		},
-		{
-			name:       "stdin ignored when not piped (interactive terminal)",
-			stdinPiped: false,
-			stdin:      "should never be read",
-			expected:   "",
-		},
-		{
-			name:       "empty when no source provided",
-			stdinPiped: false,
-			expected:   "",
-		},
-		{
-			name:       "piped but empty stdin yields empty body",
-			stdinPiped: true,
-			stdin:      "",
-			expected:   "",
-		},
-	}
-
-	for _, tc := range testCases {
-		t.Run(tc.name, func(t *testing.T) {
-			body, err := resolveBody(tc.positional, tc.description, tc.stdinPiped, strings.NewReader(tc.stdin))
-			require.NoError(t, err)
-			assert.Equal(t, tc.expected, body)
-		})
-	}
-}
-
-// TestResolveBodyDoesNotReadStdinWhenBodyGiven guards the original bug: when a
-// body is supplied positionally (or via -d), stdin must not be consumed, so the
-// command can never block on a non-TTY stdin under CI / agent harnesses.
-func TestResolveBodyDoesNotReadStdinWhenBodyGiven(t *testing.T) {
-	reader := &trackingReader{}
-
-	body, err := resolveBody("positional body", "", true, reader)
-	require.NoError(t, err)
-	assert.Equal(t, "positional body", body)
-	assert.False(t, reader.read, "stdin must not be read when a body is supplied")
-}
-
-// trackingReader records whether Read was ever called.
-type trackingReader struct {
-	read bool
-}
-
-func (r *trackingReader) Read(p []byte) (int, error) {
-	r.read = true
-	return 0, io.EOF
-}