feat!: rebuild tea on Cobra with explicit noun/verb commands (#1126)

- **switch tea to the Cobra command tree:** `internal/app` wires the packages from parts 1–4 into explicit noun/verb commands with `--repo`, `--json` / `--jq`, `--sudo` and `--debug`; `main.go` points at it. Build, release and docs tooling (`tools/cli-docs`, Makefile, goreleaser, snap, CI) and README / CONTRIBUTING are updated. - **remove the urfave/cli command tree:** deletes `cmd/`, `modules/`, the old integration tests, contrib completion scripts and the generated `docs/CLI.md`, and drops their dependencies. This commit only deletes. ## Breaking changes This is a breaking release. It requires Gitea 28 or newer; configuration moves to separate `config.yml` and `hosts.yml` files and requires fresh authentication, and command names, aliases, flags and output formats change. `docs/migration-1.0.md` maps every old command, flag and environment variable to its replacement. ## Issues fixes #1118 fixes #1116 fixes #1115 fixes #1094 fixes #1091 fixes #1073 fixes #1052 fixes #1032 fixes #1023 fixes #966 fixes #908 fixes #833 fixes #831 fixes #817 fixes #804 fixes #779 fixes #770 fixes #737 fixes #697 fixes #726 fixes #677 fixes #672 fixes #633 fixes #632 fixes #560 fixes #556 fixes #523 fixes #516 fixes #510 fixes #504 fixes #500 fixes #482 fixes #406 fixes #403 fixes #373 fixes #351 fixes #344 fixes #326 fixes #325 fixes #323 fixes #246 fixes #240 fixes #232 fixes #197 fixes #172 fixes #141 fixes #69 fixes #1110 fixes #569 fixes #480 fixes #666 fixes #670 fixes #457 fixes #643 fixes #498 fixes #490 fixes #1069 fixes #834 fixes #602 fixes #328 fixes #417 fixes #571 fixes #1029 fixes #489 fixes #1050 fixes #162 fixes #430 fixes #1087 fixes #683 Reviewed-on: https://gitea.com/gitea/tea/pulls/1126 Reviewed-by: TheFox0x7 <95654+thefox0x7@noreply.gitea.com>
2026-10-26 11:01:25 +01:00 · 2026-10-11 17:23:06 +00:00
1 parent 12e415a7a7
commit f02245449b
@@ -1,152 +0,0 @@
-// Copyright 2025 The Gitea Authors. All rights reserved.
-// SPDX-License-Identifier: MIT
-
-package flags
-
-import (
-	"context"
-	"io"
-	"testing"
-
-	gitea "gitea.dev/sdk"
-	"github.com/stretchr/testify/assert"
-	"github.com/stretchr/testify/require"
-	"github.com/urfave/cli/v3"
-)
-
-func TestPaginationFlags(t *testing.T) {
-	var (
-		defaultPage  = PaginationPageFlag.Value
-		defaultLimit = PaginationLimitFlag.Value
-	)
-
-	cases := []struct {
-		name          string
-		args          []string
-		expectedPage  int
-		expectedLimit int
-	}{
-		{
-			name:          "no flags",
-			args:          []string{"test"},
-			expectedPage:  defaultPage,
-			expectedLimit: defaultLimit,
-		},
-		{
-			name:          "only paging",
-			args:          []string{"test", "--page", "5"},
-			expectedPage:  5,
-			expectedLimit: defaultLimit,
-		},
-		{
-			name:          "only limit",
-			args:          []string{"test", "--limit", "10"},
-			expectedPage:  defaultPage,
-			expectedLimit: 10,
-		},
-		{
-			name:          "only limit",
-			args:          []string{"test", "--limit", "10"},
-			expectedPage:  defaultPage,
-			expectedLimit: 10,
-		},
-		{
-			name:          "both flags",
-			args:          []string{"test", "--page", "2", "--limit", "20"},
-			expectedPage:  2,
-			expectedLimit: 20,
-		},
-		{ // TODO: Should no paging be applied as -1 or a separate flag? It's not obvious that page=-1 turns off paging and limit is ignored
-			name:          "no paging",
-			args:          []string{"test", "--limit", "20", "--page", "-1"},
-			expectedPage:  -1,
-			expectedLimit: 20,
-		},
-	}
-
-	for _, tc := range cases {
-		t.Run(tc.name, func(t *testing.T) {
-			cmd := cli.Command{
-				Name: "test-paging",
-				Action: func(_ context.Context, cmd *cli.Command) error {
-					assert.Equal(t, tc.expectedPage, cmd.Int("page"))
-					assert.Equal(t, tc.expectedLimit, cmd.Int("limit"))
-					return nil
-				},
-				Flags: PaginationFlags,
-			}
-			err := cmd.Run(t.Context(), tc.args)
-			require.NoError(t, err)
-		})
-	}
-}
-
-func TestPaginationFailures(t *testing.T) {
-	cases := []struct {
-		name          string
-		args          []string
-		expectedError error
-	}{
-		{
-			name:          "negative limit",
-			args:          []string{"test", "--limit", "-10"},
-			expectedError: ErrLimit,
-		},
-		{
-			name:          "negative paging",
-			args:          []string{"test", "--page", "-2"},
-			expectedError: ErrPage,
-		},
-		{
-			name:          "zero paging",
-			args:          []string{"test", "--page", "0"},
-			expectedError: ErrPage,
-		},
-		{
-			// urfave does not validate all flags in one pass
-			name:          "negative paging and paging",
-			args:          []string{"test", "--page", "-2", "--limit", "-10"},
-			expectedError: ErrPage,
-		},
-	}
-
-	for _, tc := range cases {
-		cmd := cli.Command{
-			Name:      "test-paging",
-			Flags:     PaginationFlags,
-			Writer:    io.Discard,
-			ErrWriter: io.Discard,
-		}
-		t.Run(tc.name, func(t *testing.T) {
-			err := cmd.Run(t.Context(), tc.args)
-			require.ErrorContains(t, err, tc.expectedError.Error())
-			// require.ErrorIs(t, err, tc.expectedError)
-		})
-	}
-}
-
-func TestGetListOptionsDoesNotLeakBetweenCommands(t *testing.T) {
-	var results []gitea.ListOptions
-
-	run := func(args []string) {
-		t.Helper()
-
-		cmd := cli.Command{
-			Name: "test-paging",
-			Action: func(_ context.Context, cmd *cli.Command) error {
-				results = append(results, GetListOptions(cmd))
-				return nil
-			},
-			Flags: PaginationFlags,
-		}
-
-		require.NoError(t, cmd.Run(t.Context(), args))
-	}
-
-	run([]string{"test", "--page", "5", "--limit", "10"})
-	run([]string{"test"})
-
-	require.Len(t, results, 2)
-	assert.Equal(t, gitea.ListOptions{Page: 5, PageSize: 10}, results[0])
-	assert.Equal(t, gitea.ListOptions{Page: defaultPageValue, PageSize: defaultLimitValue}, results[1])
-}