feat!: rebuild tea on Cobra with explicit noun/verb commands (#1126)

- **switch tea to the Cobra command tree:** `internal/app` wires the packages from parts 1–4 into explicit noun/verb commands with `--repo`, `--json` / `--jq`, `--sudo` and `--debug`; `main.go` points at it. Build, release and docs tooling (`tools/cli-docs`, Makefile, goreleaser, snap, CI) and README / CONTRIBUTING are updated. - **remove the urfave/cli command tree:** deletes `cmd/`, `modules/`, the old integration tests, contrib completion scripts and the generated `docs/CLI.md`, and drops their dependencies. This commit only deletes. ## Breaking changes This is a breaking release. It requires Gitea 28 or newer; configuration moves to separate `config.yml` and `hosts.yml` files and requires fresh authentication, and command names, aliases, flags and output formats change. `docs/migration-1.0.md` maps every old command, flag and environment variable to its replacement. ## Issues fixes #1118 fixes #1116 fixes #1115 fixes #1094 fixes #1091 fixes #1073 fixes #1052 fixes #1032 fixes #1023 fixes #966 fixes #908 fixes #833 fixes #831 fixes #817 fixes #804 fixes #779 fixes #770 fixes #737 fixes #697 fixes #726 fixes #677 fixes #672 fixes #633 fixes #632 fixes #560 fixes #556 fixes #523 fixes #516 fixes #510 fixes #504 fixes #500 fixes #482 fixes #406 fixes #403 fixes #373 fixes #351 fixes #344 fixes #326 fixes #325 fixes #323 fixes #246 fixes #240 fixes #232 fixes #197 fixes #172 fixes #141 fixes #69 fixes #1110 fixes #569 fixes #480 fixes #666 fixes #670 fixes #457 fixes #643 fixes #498 fixes #490 fixes #1069 fixes #834 fixes #602 fixes #328 fixes #417 fixes #571 fixes #1029 fixes #489 fixes #1050 fixes #162 fixes #430 fixes #1087 fixes #683 Reviewed-on: https://gitea.com/gitea/tea/pulls/1126 Reviewed-by: TheFox0x7 <95654+thefox0x7@noreply.gitea.com>
2026-10-26 11:01:25 +01:00 · 2026-10-11 17:23:06 +00:00
1 parent 12e415a7a7
commit f02245449b
@@ -1,360 +0,0 @@
-// Copyright 2025 The Gitea Authors. All rights reserved.
-// SPDX-License-Identifier: MIT
-
-package cmd
-
-import (
-	"bytes"
-	stdctx "context"
-	"encoding/json"
-	"fmt"
-	"testing"
-	"time"
-
-	gitea "gitea.dev/sdk"
-	"github.com/stretchr/testify/assert"
-	"github.com/stretchr/testify/require"
-	"github.com/urfave/cli/v3"
-
-	"gitea.dev/tea/cmd/flags"
-	"gitea.dev/tea/modules/config"
-	"gitea.dev/tea/modules/context"
-)
-
-const (
-	testOwner = "testOwner"
-	testRepo  = "testRepo"
-)
-
-type fakeIssueCommentClient struct {
-	owner    string
-	repo     string
-	index    int64
-	comments []*gitea.Comment
-}
-
-func (f *fakeIssueCommentClient) ListIssueComments(_ stdctx.Context, owner, repo string, index int64, _ gitea.ListIssueCommentOptions) ([]*gitea.Comment, *gitea.Response, error) {
-	f.owner = owner
-	f.repo = repo
-	f.index = index
-	return f.comments, nil, nil
-}
-
-type fakeIssueDetailClient struct {
-	owner     string
-	repo      string
-	index     int64
-	issue     *gitea.Issue
-	reactions []*gitea.Reaction
-}
-
-func (f *fakeIssueDetailClient) GetIssue(_ stdctx.Context, owner, repo string, index int64) (*gitea.Issue, *gitea.Response, error) {
-	f.owner = owner
-	f.repo = repo
-	f.index = index
-	return f.issue, nil, nil
-}
-
-func (f *fakeIssueDetailClient) ListIssueReactions(_ stdctx.Context, owner, repo string, index int64, _ gitea.ListIssueReactionsOptions) ([]*gitea.Reaction, *gitea.Response, error) {
-	f.owner = owner
-	f.repo = repo
-	f.index = index
-	return f.reactions, nil, nil
-}
-
-func toCommentPointers(comments []gitea.Comment) []*gitea.Comment {
-	result := make([]*gitea.Comment, 0, len(comments))
-	for i := range comments {
-		comment := comments[i]
-		result = append(result, &comment)
-	}
-	return result
-}
-
-func createTestIssue(comments int, isClosed bool) gitea.Issue {
-	issue := gitea.Issue{
-		ID:      42,
-		Index:   1,
-		Title:   "Test issue",
-		State:   gitea.StateOpen,
-		Body:    "This is a test",
-		Created: time.Date(2025, 31, 10, 23, 59, 59, 999999999, time.UTC),
-		Updated: time.Date(2025, 1, 11, 0, 0, 0, 0, time.UTC),
-		Labels: []*gitea.Label{
-			{
-				Name:        "example/Label1",
-				Color:       "very red",
-				Description: "This is an example label",
-			},
-			{
-				Name:        "example/Label2",
-				Color:       "hardly red",
-				Description: "This is another example label",
-			},
-		},
-		Comments: comments,
-		Poster: &gitea.User{
-			UserName: "testUser",
-		},
-		Assignees: []*gitea.User{
-			{UserName: "testUser"},
-			{UserName: "testUser3"},
-		},
-		HTMLURL: "<space holder>",
-		Closed:  nil, // 2025-11-10T21:20:19Z
-	}
-
-	if isClosed {
-		closed := time.Date(2025, 11, 10, 21, 20, 19, 0, time.UTC)
-		issue.Closed = &closed
-	}
-
-	if isClosed {
-		issue.State = gitea.StateClosed
-	} else {
-		issue.State = gitea.StateOpen
-	}
-
-	return issue
-}
-
-func createTestIssueComments(comments int) []gitea.Comment {
-	baseID := 900
-	var result []gitea.Comment
-
-	for commentID := 0; commentID < comments; commentID++ {
-		result = append(result, gitea.Comment{
-			ID: int64(baseID + commentID),
-			Poster: &gitea.User{
-				UserName: "Freddy",
-			},
-			Body: fmt.Sprintf("This is a test comment #%v", commentID),
-			Created: time.Date(2025, 11, 3, 12, 0, 0, 0, time.UTC).
-				Add(time.Duration(commentID) * time.Hour),
-		})
-	}
-
-	return result
-}
-
-func TestRunIssueDetailAsJSON(t *testing.T) {
-	type TestCase struct {
-		name         string
-		issue        gitea.Issue
-		comments     []gitea.Comment
-		flagComments bool
-	}
-
-	cmd := cli.Command{
-		Name: "t",
-		Flags: []cli.Flag{
-			&cli.BoolFlag{
-				Name:  "comments",
-				Value: false,
-			},
-			&cli.StringFlag{
-				Name:  "output",
-				Value: "json",
-			},
-		},
-	}
-
-	testContext := context.TeaContext{
-		Owner: testOwner,
-		Repo:  testRepo,
-		Login: &config.Login{
-			Name: "testLogin",
-			URL:  "http://127.0.0.1:8081",
-		},
-		Command: &cmd,
-	}
-
-	testCases := []TestCase{
-		{
-			name:         "Simple issue with no comments, no comments requested",
-			issue:        createTestIssue(0, true),
-			comments:     []gitea.Comment{},
-			flagComments: false,
-		},
-		{
-			name:         "Simple issue with no comments, comments requested",
-			issue:        createTestIssue(0, true),
-			comments:     []gitea.Comment{},
-			flagComments: true,
-		},
-		{
-			name:         "Simple issue with comments, no comments requested",
-			issue:        createTestIssue(2, true),
-			comments:     createTestIssueComments(2),
-			flagComments: false,
-		},
-		{
-			name:         "Simple issue with comments, comments requested",
-			issue:        createTestIssue(2, true),
-			comments:     createTestIssueComments(2),
-			flagComments: true,
-		},
-		{
-			name:         "Simple issue with comments, comments requested, not closed",
-			issue:        createTestIssue(2, false),
-			comments:     createTestIssueComments(2),
-			flagComments: true,
-		},
-	}
-
-	for _, testCase := range testCases {
-		t.Run(testCase.name, func(t *testing.T) {
-			client := &fakeIssueCommentClient{
-				comments: toCommentPointers(testCase.comments),
-			}
-
-			testContext.Login.URL = "https://gitea.example.com"
-			testCase.issue.HTMLURL = fmt.Sprintf("%s/%s/%s/issues/%d/", testContext.Login.URL, testOwner, testRepo, testCase.issue.Index)
-
-			var outBuffer bytes.Buffer
-			testContext.Writer = &outBuffer
-			var errBuffer bytes.Buffer
-			testContext.ErrWriter = &errBuffer
-
-			if testCase.flagComments {
-				require.NoError(t, testContext.Set("comments", "true"))
-			} else {
-				require.NoError(t, testContext.Set("comments", "false"))
-			}
-
-			err := runIssueDetailAsJSONWithClient(t.Context(), &testContext, &testCase.issue, client)
-
-			require.NoError(t, err, "Failed to run issue detail as JSON")
-			if testCase.flagComments {
-				assert.Equal(t, testOwner, client.owner)
-				assert.Equal(t, testRepo, client.repo)
-				assert.Equal(t, testCase.issue.Index, client.index)
-			}
-
-			out := outBuffer.String()
-
-			require.NotEmpty(t, out, "Unexpected empty output from runIssueDetailAsJSON")
-
-			// setting expectations
-
-			var expectedLabels []labelData
-			expectedLabels = []labelData{}
-			for _, l := range testCase.issue.Labels {
-				expectedLabels = append(expectedLabels, labelData{
-					Name:        l.Name,
-					Color:       l.Color,
-					Description: l.Description,
-				})
-			}
-
-			var expectedAssignees []string
-			expectedAssignees = []string{}
-			for _, a := range testCase.issue.Assignees {
-				expectedAssignees = append(expectedAssignees, a.UserName)
-			}
-
-			var expectedClosedAt *time.Time
-			if testCase.issue.Closed != nil {
-				expectedClosedAt = testCase.issue.Closed
-			}
-
-			var expectedComments []commentData
-			expectedComments = []commentData{}
-			if testCase.flagComments {
-				for _, c := range testCase.comments {
-					expectedComments = append(expectedComments, commentData{
-						ID:      c.ID,
-						Author:  c.Poster.UserName,
-						Body:    c.Body,
-						Created: c.Created,
-					})
-				}
-			}
-
-			expected := issueData{
-				ID:        testCase.issue.ID,
-				Index:     testCase.issue.Index,
-				Title:     testCase.issue.Title,
-				State:     testCase.issue.State,
-				Created:   testCase.issue.Created,
-				User:      testCase.issue.Poster.UserName,
-				Body:      testCase.issue.Body,
-				URL:       testCase.issue.HTMLURL,
-				ClosedAt:  expectedClosedAt,
-				Labels:    expectedLabels,
-				Assignees: expectedAssignees,
-				Comments:  expectedComments,
-			}
-
-			// validating reality
-			var actual issueData
-			dec := json.NewDecoder(bytes.NewReader(outBuffer.Bytes()))
-			dec.DisallowUnknownFields()
-			err = dec.Decode(&actual)
-			require.NoError(t, err, "Failed to unmarshal output into struct")
-
-			assert.Equal(t, expected, actual, "Expected structs differ from expected one")
-		})
-	}
-}
-
-func TestRunIssueDetailUsesOwnerFlag(t *testing.T) {
-	issueIndex := int64(12)
-	expectedOwner := "overrideOwner"
-	expectedRepo := "overrideRepo"
-	issue := &gitea.Issue{
-		ID:      99,
-		Index:   issueIndex,
-		Title:   "Owner override test",
-		State:   gitea.StateOpen,
-		Created: time.Date(2025, 11, 1, 10, 0, 0, 0, time.UTC),
-		Poster: &gitea.User{
-			UserName: "tester",
-		},
-		HTMLURL: "https://example.test/issues/12",
-	}
-
-	config.SetConfigForTesting(config.LocalConfig{
-		Logins: []config.Login{{
-			Name:    "testLogin",
-			URL:     "https://gitea.example.com",
-			Token:   "token",
-			User:    "loginUser",
-			Default: true,
-		}},
-	})
-
-	cmd := cli.Command{
-		Name: "issues",
-		Flags: []cli.Flag{
-			&flags.LoginFlag,
-			&flags.RepoFlag,
-			&flags.RemoteFlag,
-			&flags.OutputFlag,
-			&cli.StringFlag{Name: "owner"},
-			&cli.BoolFlag{Name: "comments"},
-		},
-	}
-	var outBuffer bytes.Buffer
-	var errBuffer bytes.Buffer
-	cmd.Writer = &outBuffer
-	cmd.ErrWriter = &errBuffer
-	require.NoError(t, cmd.Set("login", "testLogin"))
-	require.NoError(t, cmd.Set("repo", expectedRepo))
-	require.NoError(t, cmd.Set("owner", expectedOwner))
-	require.NoError(t, cmd.Set("comments", "false"))
-
-	teaCtx, idx, err := resolveIssueDetailContext(&cmd, fmt.Sprintf("%d", issueIndex))
-	require.NoError(t, err)
-
-	client := &fakeIssueDetailClient{
-		issue:     issue,
-		reactions: []*gitea.Reaction{},
-	}
-
-	err = runIssueDetailWithClient(t.Context(), teaCtx, idx, client)
-	require.NoError(t, err, "Expected runIssueDetail to succeed")
-	assert.Equal(t, expectedOwner, client.owner)
-	assert.Equal(t, expectedRepo, client.repo)
-	assert.Equal(t, issueIndex, client.index)
-}