feat!: rebuild tea on Cobra with explicit noun/verb commands (#1126)

- **switch tea to the Cobra command tree:** `internal/app` wires the packages from parts 1–4 into explicit noun/verb commands with `--repo`, `--json` / `--jq`, `--sudo` and `--debug`; `main.go` points at it. Build, release and docs tooling (`tools/cli-docs`, Makefile, goreleaser, snap, CI) and README / CONTRIBUTING are updated. - **remove the urfave/cli command tree:** deletes `cmd/`, `modules/`, the old integration tests, contrib completion scripts and the generated `docs/CLI.md`, and drops their dependencies. This commit only deletes. ## Breaking changes This is a breaking release. It requires Gitea 28 or newer; configuration moves to separate `config.yml` and `hosts.yml` files and requires fresh authentication, and command names, aliases, flags and output formats change. `docs/migration-1.0.md` maps every old command, flag and environment variable to its replacement. ## Issues fixes #1118 fixes #1116 fixes #1115 fixes #1094 fixes #1091 fixes #1073 fixes #1052 fixes #1032 fixes #1023 fixes #966 fixes #908 fixes #833 fixes #831 fixes #817 fixes #804 fixes #779 fixes #770 fixes #737 fixes #697 fixes #726 fixes #677 fixes #672 fixes #633 fixes #632 fixes #560 fixes #556 fixes #523 fixes #516 fixes #510 fixes #504 fixes #500 fixes #482 fixes #406 fixes #403 fixes #373 fixes #351 fixes #344 fixes #326 fixes #325 fixes #323 fixes #246 fixes #240 fixes #232 fixes #197 fixes #172 fixes #141 fixes #69 fixes #1110 fixes #569 fixes #480 fixes #666 fixes #670 fixes #457 fixes #643 fixes #498 fixes #490 fixes #1069 fixes #834 fixes #602 fixes #328 fixes #417 fixes #571 fixes #1029 fixes #489 fixes #1050 fixes #162 fixes #430 fixes #1087 fixes #683 Reviewed-on: https://gitea.com/gitea/tea/pulls/1126 Reviewed-by: TheFox0x7 <95654+thefox0x7@noreply.gitea.com>
2026-10-26 11:01:25 +01:00 · 2026-10-11 17:23:06 +00:00
1 parent 12e415a7a7
commit f02245449b
@@ -0,0 +1,142 @@
+// Copyright 2026 The Gitea Authors. All rights reserved.
+// SPDX-License-Identifier: MIT
+
+package app
+
+import (
+	"errors"
+	"fmt"
+	"strconv"
+	"strings"
+
+	"gitea.dev/tea/internal/clierr"
+	"gitea.dev/tea/internal/services"
+	"gitea.dev/tea/internal/terminal"
+	"github.com/spf13/cobra"
+)
+
+// validateBranch rejects invalid Git refs before making requests.
+func validateBranch(name string) error {
+	if name == "" || name == "@" || strings.HasPrefix(name, "-") || strings.HasPrefix(name, "/") || strings.HasSuffix(name, "/") || strings.HasSuffix(name, ".") || strings.Contains(name, "..") || strings.Contains(name, "@{") || strings.Contains(name, "//") || strings.ContainsAny(name, " ~^:?*[\\\t\r\n") {
+		return clierr.Wrap(clierr.Usage, errors.New("invalid branch name"))
+	}
+	for part := range strings.SplitSeq(name, "/") {
+		if strings.HasPrefix(part, ".") || strings.HasSuffix(part, ".lock") {
+			return clierr.Wrap(clierr.Usage, errors.New("invalid branch name"))
+		}
+	}
+	for _, r := range name {
+		if r < 32 || r == 127 {
+			return clierr.Wrap(clierr.Usage, errors.New("invalid branch name"))
+		}
+	}
+	return nil
+}
+
+func (a *application) branchCommand() *cobra.Command {
+	group := &cobra.Command{Use: "branch", Short: "Manage remote branches and protection rules"}
+	var limit, page int
+	list := &cobra.Command{Use: "list", Short: "List remote branches", Args: argsExact(0), RunE: func(cmd *cobra.Command, _ []string) error {
+		target, err := a.resolve(cmd.Context(), true)
+		if err != nil {
+			return err
+		}
+		items, err := (services.Branches{Client: target.client}).List(cmd.Context(), target.Repo, limit, page)
+		if err != nil {
+			return err
+		}
+		return writeList(a, cmd, items, branchRow)
+	}}
+	pageFlags(list, &limit, &page)
+	group.AddCommand(list)
+	for _, verb := range []string{"view", "create", "rename", "delete", "protect", "unprotect"} {
+		var source string
+		count := 1
+		use := verb + " <name>"
+		if verb == "rename" {
+			count = 2
+			use = "rename <old-name> <new-name>"
+		}
+		arguments := argsExact(count)
+		if verb == "protect" || verb == "unprotect" {
+			use = verb + " <name>..."
+			arguments = usageArgs(cobra.MinimumNArgs(1))
+		}
+		command := &cobra.Command{Use: use, Short: titleCase(verb) + " a remote branch", Args: arguments, RunE: func(cmd *cobra.Command, args []string) error {
+			for _, name := range args {
+				if err := validateBranch(name); err != nil {
+					return err
+				}
+			}
+			if source != "" {
+				if err := validateBranch(source); err != nil {
+					return err
+				}
+			}
+			if verb == "rename" && args[0] == args[1] {
+				return clierr.Wrap(clierr.Usage, errors.New("new branch name must differ from the current name"))
+			}
+			target, err := a.resolve(cmd.Context(), true)
+			if err != nil {
+				return err
+			}
+			service := services.Branches{Client: target.client}
+			if verb == "delete" || verb == "unprotect" {
+				if err := a.confirm(cmd, verb+" branches "+strings.Join(args, ", ")+" in "+target.Repo); err != nil {
+					return err
+				}
+			}
+			switch verb {
+			case "view":
+				item, err := service.View(cmd.Context(), target.Repo, args[0])
+				if err != nil {
+					return err
+				}
+				return writeItem(a, cmd, item, branchRow)
+			case "create":
+				item, err := service.Create(cmd.Context(), target.Repo, args[0], source)
+				if err != nil {
+					return err
+				}
+				return writeItem(a, cmd, item, branchRow)
+			case "rename":
+				return service.Rename(cmd.Context(), target.Repo, args[0], args[1])
+			case "delete":
+				return service.Delete(cmd.Context(), target.Repo, args[0])
+			case "protect", "unprotect":
+				var failures []error
+				for _, name := range args {
+					var err error
+					if verb == "protect" {
+						err = service.Protect(cmd.Context(), target.Repo, name)
+					} else {
+						err = service.Unprotect(cmd.Context(), target.Repo, name)
+					}
+					if err != nil {
+						failures = append(failures, fmt.Errorf("%s branch %s: %w", verb, name, err))
+						continue
+					}
+					if len(args) > 1 {
+						if _, err := fmt.Fprintf(cmd.ErrOrStderr(), "%s branch %s\n", verb, name); err != nil {
+							return err
+						}
+					}
+				}
+				return errors.Join(failures...)
+			}
+			return nil
+		}}
+		if verb == "create" {
+			command.Flags().StringVar(&source, "source", "", "Source branch (default: repository default branch)")
+		}
+		if verb != "view" && verb != "create" {
+			command.Annotations = textOutput("branch " + verb + " does not return a resource")
+		}
+		group.AddCommand(command)
+	}
+	return group
+}
+
+func branchRow(item services.Branch) []terminal.Cell {
+	return terminal.Row(item.Name, item.SHA, strconv.FormatBool(item.Protected))
+}