feat!: rebuild tea on Cobra with explicit noun/verb commands (#1126)

- **switch tea to the Cobra command tree:** `internal/app` wires the packages from parts 1–4 into explicit noun/verb commands with `--repo`, `--json` / `--jq`, `--sudo` and `--debug`; `main.go` points at it. Build, release and docs tooling (`tools/cli-docs`, Makefile, goreleaser, snap, CI) and README / CONTRIBUTING are updated. - **remove the urfave/cli command tree:** deletes `cmd/`, `modules/`, the old integration tests, contrib completion scripts and the generated `docs/CLI.md`, and drops their dependencies. This commit only deletes. ## Breaking changes This is a breaking release. It requires Gitea 28 or newer; configuration moves to separate `config.yml` and `hosts.yml` files and requires fresh authentication, and command names, aliases, flags and output formats change. `docs/migration-1.0.md` maps every old command, flag and environment variable to its replacement. ## Issues fixes #1118 fixes #1116 fixes #1115 fixes #1094 fixes #1091 fixes #1073 fixes #1052 fixes #1032 fixes #1023 fixes #966 fixes #908 fixes #833 fixes #831 fixes #817 fixes #804 fixes #779 fixes #770 fixes #737 fixes #697 fixes #726 fixes #677 fixes #672 fixes #633 fixes #632 fixes #560 fixes #556 fixes #523 fixes #516 fixes #510 fixes #504 fixes #500 fixes #482 fixes #406 fixes #403 fixes #373 fixes #351 fixes #344 fixes #326 fixes #325 fixes #323 fixes #246 fixes #240 fixes #232 fixes #197 fixes #172 fixes #141 fixes #69 fixes #1110 fixes #569 fixes #480 fixes #666 fixes #670 fixes #457 fixes #643 fixes #498 fixes #490 fixes #1069 fixes #834 fixes #602 fixes #328 fixes #417 fixes #571 fixes #1029 fixes #489 fixes #1050 fixes #162 fixes #430 fixes #1087 fixes #683 Reviewed-on: https://gitea.com/gitea/tea/pulls/1126 Reviewed-by: TheFox0x7 <95654+thefox0x7@noreply.gitea.com>
2026-10-26 11:01:25 +01:00 · 2026-10-11 17:23:06 +00:00
1 parent 12e415a7a7
commit f02245449b
@@ -0,0 +1,86 @@
+// Copyright 2026 The Gitea Authors. All rights reserved.
+// SPDX-License-Identifier: MIT
+
+package app
+
+import (
+	"context"
+	"net/http"
+	"testing"
+
+	"gitea.dev/tea/internal/clierr"
+	"github.com/stretchr/testify/require"
+)
+
+func TestChecksUseLatestContextAcrossPagesAndReturnFailureWithCleanJSON(t *testing.T) {
+	state := "success"
+	server := newAuthenticatedServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
+		require.Equal(t, http.MethodGet, r.Method)
+		if r.URL.Path == "/api/v1/repos/owner/repo/pulls/7" {
+			_, _ = w.Write([]byte(`{"head":{"sha":"abc123"}}`))
+			return
+		}
+		require.Equal(t, "/api/v1/repos/owner/repo/statuses/abc123", r.URL.Path)
+		switch r.URL.Query().Get("page") {
+		case "1":
+			_, _ = w.Write([]byte(`[{"id":1,"context":"build","status":"failure"}]`))
+		case "2":
+			_, _ = w.Write([]byte(`[{"id":2,"context":"build","status":"` + state + `","creator":{"login":"excluded"}}]`))
+		default:
+			_, _ = w.Write([]byte(`[]`))
+		}
+	}))
+	defer server.Close()
+	deps, out, diagnostics := serverDeps(t, server.URL)
+	args := []string{"pr", "checks", "7", "-R", "owner/repo", "--json=id,name,state"}
+	require.NoError(t, Execute(context.Background(), deps, args))
+	require.JSONEq(t, `[{"id":2,"name":"build","state":"success"}]`, out.String())
+	out.Reset()
+	state = "pending"
+	err := Execute(context.Background(), deps, args)
+	require.ErrorContains(t, err, "not all succeeded")
+	require.JSONEq(t, `[{"id":2,"name":"build","state":"pending"}]`, out.String())
+	out.Reset()
+	state = "skipped"
+	require.NoError(t, Execute(context.Background(), deps, args))
+	require.Empty(t, diagnostics.String())
+}
+
+func TestChecksWatchWaitsForRegistrationAndEmitsOneJSONResult(t *testing.T) {
+	polls := 0
+	keepPending := false
+	server := newAuthenticatedServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
+		if r.URL.Path == "/api/v1/repos/owner/repo/pulls/7" {
+			polls++
+			_, _ = w.Write([]byte(`{"head":{"sha":"abc123"}}`))
+			return
+		}
+		if r.URL.Query().Get("page") != "1" || polls == 1 {
+			_, _ = w.Write([]byte(`[]`))
+			return
+		}
+		state := "pending"
+		if polls >= 3 && !keepPending {
+			state = "success"
+		}
+		_, _ = w.Write([]byte(`[{"id":2,"context":"build","status":"` + state + `"}]`))
+	}))
+	defer server.Close()
+	deps, out, diagnostics := serverDeps(t, server.URL)
+	require.NoError(t, Execute(context.Background(), deps, []string{"pr", "checks", "7", "-R", "owner/repo", "--watch", "--interval=1ms", "--timeout=1s", "--json=name,state"}))
+	require.Equal(t, 4, polls)
+	require.JSONEq(t, `[{"name":"build","state":"success"}]`, out.String())
+	require.Contains(t, diagnostics.String(), "1 pending")
+	keepPending = true
+	out.Reset()
+	diagnostics.Reset()
+	err := Execute(context.Background(), deps, []string{"pr", "checks", "7", "-R", "owner/repo", "--watch", "--interval=1ms", "--timeout=20ms", "--json"})
+	require.ErrorIs(t, err, context.DeadlineExceeded)
+	require.Equal(t, clierr.Canceled, clierr.ExitCode(err))
+	require.Empty(t, out.String())
+	ctx, cancel := context.WithCancel(context.Background())
+	cancel()
+	err = Execute(ctx, deps, []string{"pr", "checks", "7", "-R", "owner/repo", "--watch"})
+	require.ErrorIs(t, err, context.Canceled)
+	require.Equal(t, clierr.Canceled, clierr.ExitCode(err))
+}