feat!: rebuild tea on Cobra with explicit noun/verb commands (#1126)

- **switch tea to the Cobra command tree:** `internal/app` wires the packages from parts 1–4 into explicit noun/verb commands with `--repo`, `--json` / `--jq`, `--sudo` and `--debug`; `main.go` points at it. Build, release and docs tooling (`tools/cli-docs`, Makefile, goreleaser, snap, CI) and README / CONTRIBUTING are updated. - **remove the urfave/cli command tree:** deletes `cmd/`, `modules/`, the old integration tests, contrib completion scripts and the generated `docs/CLI.md`, and drops their dependencies. This commit only deletes. ## Breaking changes This is a breaking release. It requires Gitea 28 or newer; configuration moves to separate `config.yml` and `hosts.yml` files and requires fresh authentication, and command names, aliases, flags and output formats change. `docs/migration-1.0.md` maps every old command, flag and environment variable to its replacement. ## Issues fixes #1118 fixes #1116 fixes #1115 fixes #1094 fixes #1091 fixes #1073 fixes #1052 fixes #1032 fixes #1023 fixes #966 fixes #908 fixes #833 fixes #831 fixes #817 fixes #804 fixes #779 fixes #770 fixes #737 fixes #697 fixes #726 fixes #677 fixes #672 fixes #633 fixes #632 fixes #560 fixes #556 fixes #523 fixes #516 fixes #510 fixes #504 fixes #500 fixes #482 fixes #406 fixes #403 fixes #373 fixes #351 fixes #344 fixes #326 fixes #325 fixes #323 fixes #246 fixes #240 fixes #232 fixes #197 fixes #172 fixes #141 fixes #69 fixes #1110 fixes #569 fixes #480 fixes #666 fixes #670 fixes #457 fixes #643 fixes #498 fixes #490 fixes #1069 fixes #834 fixes #602 fixes #328 fixes #417 fixes #571 fixes #1029 fixes #489 fixes #1050 fixes #162 fixes #430 fixes #1087 fixes #683 Reviewed-on: https://gitea.com/gitea/tea/pulls/1126 Reviewed-by: TheFox0x7 <95654+thefox0x7@noreply.gitea.com>
2026-10-26 11:01:25 +01:00 · 2026-10-11 17:23:06 +00:00
1 parent 12e415a7a7
commit f02245449b
@@ -0,0 +1,156 @@
+// Copyright 2026 The Gitea Authors. All rights reserved.
+// SPDX-License-Identifier: MIT
+
+package app
+
+import (
+	"errors"
+	"fmt"
+	"path/filepath"
+	"strconv"
+	"strings"
+
+	"gitea.dev/tea/internal/clierr"
+	"gitea.dev/tea/internal/services"
+	"gitea.dev/tea/internal/terminal"
+	"github.com/spf13/cobra"
+)
+
+func (a *application) issueAttachmentCommand() *cobra.Command {
+	group := &cobra.Command{Use: "attachment", Short: "Inspect issue or pull request attachments"}
+	var limit, page int
+	list := &cobra.Command{Use: "list <number>", Short: "List attachments", Args: argsExact(1), RunE: func(cmd *cobra.Command, args []string) error {
+		n, err := number(args[0])
+		if err != nil {
+			return err
+		}
+		target, err := a.resolve(cmd.Context(), true)
+		if err != nil {
+			return err
+		}
+		items, err := (services.Issues{Client: target.client, Repository: target.Repo}).Attachments(cmd.Context(), n, limit, page)
+		if err != nil {
+			return err
+		}
+		return writeList(a, cmd, items, attachmentRow)
+	}}
+	pageFlags(list, &limit, &page)
+	view := &cobra.Command{Use: "view <number> <attachment-id>", Short: "View attachment metadata", Args: argsExact(2), RunE: func(cmd *cobra.Command, args []string) error {
+		n, err := number(args[0])
+		if err != nil {
+			return err
+		}
+		id, err := number(args[1])
+		if err != nil {
+			return err
+		}
+		target, err := a.resolve(cmd.Context(), true)
+		if err != nil {
+			return err
+		}
+		item, err := (services.Issues{Client: target.client, Repository: target.Repo}).Attachment(cmd.Context(), n, id)
+		if err != nil {
+			return err
+		}
+		return writeItem(a, cmd, item, attachmentRow)
+	}}
+	for _, verb := range []string{"edit", "delete"} {
+		var name string
+		command := &cobra.Command{Use: verb + " <number> <attachment-id>", Short: titleCase(verb) + " an attachment", Args: argsExact(2), RunE: func(cmd *cobra.Command, args []string) error {
+			n, err := number(args[0])
+			if err != nil {
+				return err
+			}
+			id, err := number(args[1])
+			if err != nil {
+				return err
+			}
+			if verb == "edit" && strings.TrimSpace(name) == "" {
+				return clierr.Wrap(clierr.Usage, errors.New("supply a nonempty --name"))
+			}
+			target, err := a.resolve(cmd.Context(), true)
+			if err != nil {
+				return err
+			}
+			service := services.Issues{Client: target.client, Repository: target.Repo}
+			if verb == "delete" {
+				if err := a.confirm(cmd, fmt.Sprintf("Delete attachment %d on %s#%d", id, target.Repo, n)); err != nil {
+					return err
+				}
+				return service.DeleteAttachment(cmd.Context(), n, id)
+			}
+			item, err := service.RenameAttachment(cmd.Context(), n, id, name)
+			if err != nil {
+				return err
+			}
+			return writeItem(a, cmd, item, attachmentRow)
+		}}
+		if verb == "edit" {
+			command.Flags().StringVar(&name, "name", "", "New attachment filename")
+		}
+		if verb == "delete" {
+			command.Annotations = textOutput("attachment deletion does not return a resource")
+		}
+		group.AddCommand(command)
+	}
+	var uploadName string
+	upload := &cobra.Command{Use: "upload <number> <file>", Short: "Upload one attachment", Args: argsExact(2), RunE: func(cmd *cobra.Command, args []string) error {
+		n, err := number(args[0])
+		if err != nil {
+			return err
+		}
+		name := uploadName
+		if cmd.Flags().Changed("name") && strings.TrimSpace(name) == "" {
+			return clierr.Wrap(clierr.Usage, errors.New("--name cannot be empty"))
+		}
+		if name == "" {
+			name = filepath.Base(args[1])
+		}
+		files, err := openRegularFiles(args[1:])
+		defer closeFiles(files)
+		if err != nil {
+			return err
+		}
+		target, err := a.resolve(cmd.Context(), true)
+		if err != nil {
+			return err
+		}
+		item, err := (services.Issues{Client: target.client, Repository: target.Repo}).UploadAttachment(cmd.Context(), n, name, files[0])
+		if err != nil {
+			return err
+		}
+		return writeItem(a, cmd, item, attachmentRow)
+	}}
+	upload.Flags().StringVar(&uploadName, "name", "", "Uploaded filename (default: local filename)")
+	var output string
+	download := &cobra.Command{Use: "download <number> <attachment-id>", Short: "Download an attachment to a file or stdout", Annotations: textOutput("attachment downloads are binary"), Args: argsExact(2), RunE: func(cmd *cobra.Command, args []string) error {
+		n, err := number(args[0])
+		if err != nil {
+			return err
+		}
+		id, err := number(args[1])
+		if err != nil {
+			return err
+		}
+		if err := validateDownloadDestination(output); err != nil {
+			return err
+		}
+		target, err := a.resolve(cmd.Context(), true)
+		if err != nil {
+			return err
+		}
+		body, err := (services.Issues{Client: target.client, Repository: target.Repo}).DownloadAttachment(cmd.Context(), n, id)
+		if err != nil {
+			return err
+		}
+		defer body.Close()
+		return writeDownload(cmd, body, output)
+	}}
+	download.Flags().StringVar(&output, "output-file", "", "Destination file (must not exist), or - for stdout")
+	group.AddCommand(list, view, upload, download)
+	return group
+}
+
+func attachmentRow(item services.IssueAttachment) []terminal.Cell {
+	return terminal.Row(strconv.FormatInt(item.ID, 10), item.Name, strconv.FormatInt(item.Size, 10), item.URL)
+}