mirror of
https://gitea.com/gitea/tea.git
synced 2026-10-26 11:01:25 +01:00
feat!: rebuild tea on Cobra with explicit noun/verb commands (#1126)
- **switch tea to the Cobra command tree:** `internal/app` wires the packages from parts 1–4 into explicit noun/verb commands with `--repo`, `--json` / `--jq`, `--sudo` and `--debug`; `main.go` points at it. Build, release and docs tooling (`tools/cli-docs`, Makefile, goreleaser, snap, CI) and README / CONTRIBUTING are updated. - **remove the urfave/cli command tree:** deletes `cmd/`, `modules/`, the old integration tests, contrib completion scripts and the generated `docs/CLI.md`, and drops their dependencies. This commit only deletes. ## Breaking changes This is a breaking release. It requires Gitea 28 or newer; configuration moves to separate `config.yml` and `hosts.yml` files and requires fresh authentication, and command names, aliases, flags and output formats change. `docs/migration-1.0.md` maps every old command, flag and environment variable to its replacement. ## Issues fixes #1118 fixes #1116 fixes #1115 fixes #1094 fixes #1091 fixes #1073 fixes #1052 fixes #1032 fixes #1023 fixes #966 fixes #908 fixes #833 fixes #831 fixes #817 fixes #804 fixes #779 fixes #770 fixes #737 fixes #697 fixes #726 fixes #677 fixes #672 fixes #633 fixes #632 fixes #560 fixes #556 fixes #523 fixes #516 fixes #510 fixes #504 fixes #500 fixes #482 fixes #406 fixes #403 fixes #373 fixes #351 fixes #344 fixes #326 fixes #325 fixes #323 fixes #246 fixes #240 fixes #232 fixes #197 fixes #172 fixes #141 fixes #69 fixes #1110 fixes #569 fixes #480 fixes #666 fixes #670 fixes #457 fixes #643 fixes #498 fixes #490 fixes #1069 fixes #834 fixes #602 fixes #328 fixes #417 fixes #571 fixes #1029 fixes #489 fixes #1050 fixes #162 fixes #430 fixes #1087 fixes #683 Reviewed-on: https://gitea.com/gitea/tea/pulls/1126 Reviewed-by: TheFox0x7 <95654+thefox0x7@noreply.gitea.com>
This commit is contained in:
1 parent
12e415a7a7
commit
f02245449b
456 files changed
+18892
-34015
No files matched your search
@@ -0,0 +1,179 @@
|
||||
// Copyright 2026 The Gitea Authors. All rights reserved.
|
||||
// SPDX-License-Identifier: MIT
|
||||
|
||||
package app
|
||||
|
||||
import (
|
||||
"errors"
|
||||
"fmt"
|
||||
"strings"
|
||||
"time"
|
||||
|
||||
"gitea.dev/tea/internal/clierr"
|
||||
"gitea.dev/tea/internal/services"
|
||||
"gitea.dev/tea/internal/terminal"
|
||||
"github.com/spf13/cobra"
|
||||
)
|
||||
|
||||
func (a *application) issueEditCommand() *cobra.Command {
|
||||
var title, body, file string
|
||||
var useEditor bool
|
||||
var deadline string
|
||||
var ref string
|
||||
var milestone int64
|
||||
var milestoneName string
|
||||
var metadata metadataFlags
|
||||
cmd := &cobra.Command{Use: "edit <number>...", Short: "Edit issue content, assignees, and milestone", Args: usageArgs(cobra.MinimumNArgs(1)), RunE: func(cmd *cobra.Command, args []string) (runErr error) {
|
||||
var draft terminal.Draft
|
||||
defer finishDraft(&draft, &runErr)
|
||||
if err := validateBodySources(cmd); err != nil {
|
||||
return err
|
||||
}
|
||||
numbers, err := resourceNumbers(args)
|
||||
if err != nil {
|
||||
return err
|
||||
}
|
||||
snapshot, err := a.deps.Settings.Load()
|
||||
if err != nil {
|
||||
return err
|
||||
}
|
||||
if !localFlagsChanged(cmd) {
|
||||
if a.policy(snapshot).CanPrompt(a.deps.Streams) && a.deps.IssueEditForm != nil {
|
||||
return a.editIssuesInteractively(cmd, numbers)
|
||||
}
|
||||
return clierr.Wrap(clierr.Usage, errors.New("supply an edit flag; see tea issue edit --help"))
|
||||
}
|
||||
if useEditor && len(numbers) != 1 {
|
||||
return clierr.Wrap(clierr.Usage, errors.New("--editor requires one issue"))
|
||||
}
|
||||
if err := validateMilestoneFlags(cmd, milestoneName, milestone); err != nil {
|
||||
return err
|
||||
}
|
||||
opts := services.IssueEdit{}
|
||||
if cmd.Flags().Changed("ref") {
|
||||
opts.Ref = &ref
|
||||
}
|
||||
if cmd.Flags().Changed("deadline") {
|
||||
opts.Deadline, opts.RemoveDeadline, err = parseDeadline(deadline)
|
||||
if err != nil {
|
||||
return err
|
||||
}
|
||||
}
|
||||
if cmd.Flags().Changed("title") {
|
||||
if strings.TrimSpace(title) == "" {
|
||||
return clierr.Wrap(clierr.Usage, errors.New("issue title cannot be empty"))
|
||||
}
|
||||
opts.Title = &title
|
||||
}
|
||||
if cmd.Flags().Changed("body") || cmd.Flags().Changed("body-file") {
|
||||
body, err = a.readBody(cmd, body, file)
|
||||
if err != nil {
|
||||
return err
|
||||
}
|
||||
opts.Body = &body
|
||||
}
|
||||
if cmd.Flags().Changed("milestone") {
|
||||
opts.Milestone = &milestone
|
||||
}
|
||||
if err := metadata.validate(cmd); err != nil {
|
||||
return err
|
||||
}
|
||||
if opts == (services.IssueEdit{}) && !useEditor && !metadata.changed(cmd) && !cmd.Flags().Changed("milestone-name") {
|
||||
return clierr.Wrap(clierr.Usage, errors.New("supply an edit flag; see tea issue edit --help"))
|
||||
}
|
||||
target, err := a.resolve(cmd.Context(), true)
|
||||
if err != nil {
|
||||
return err
|
||||
}
|
||||
if cmd.Flags().Changed("milestone-name") {
|
||||
milestone, err = (services.Milestones{Client: target.client, Repository: target.Repo}).ResolveName(cmd.Context(), milestoneName)
|
||||
if err != nil {
|
||||
return err
|
||||
}
|
||||
opts.Milestone = &milestone
|
||||
}
|
||||
if opts.Labels, opts.Assignees, opts.Changes, err = metadata.resolve(cmd, target); err != nil {
|
||||
return err
|
||||
}
|
||||
service := services.Issues{Client: target.client, Repository: target.Repo}
|
||||
if useEditor {
|
||||
current, err := service.View(cmd.Context(), numbers[0])
|
||||
if err != nil {
|
||||
return err
|
||||
}
|
||||
draft, err = a.editDraft(cmd, current.Body)
|
||||
if err != nil {
|
||||
return err
|
||||
}
|
||||
opts.Body = &draft.Body
|
||||
}
|
||||
return batch(a, cmd, numbers, issueLabel, func(n int64) (services.Issue, error) {
|
||||
return service.Edit(cmd.Context(), n, opts)
|
||||
}, issueRow)
|
||||
}}
|
||||
cmd.Flags().StringVar(&title, "title", "", "Issue title")
|
||||
cmd.Flags().StringVar(&ref, "ref", "", "Referenced branch or tag; empty clears")
|
||||
cmd.Flags().StringVar(&deadline, "deadline", "", "Due date: YYYY-MM-DD, RFC3339, or Unix timestamp; empty clears")
|
||||
cmd.Flags().StringVar(&body, "body", "", "Issue body (empty clears)")
|
||||
cmd.Flags().StringVar(&file, "body-file", "", "Read body from file, or - for stdin")
|
||||
cmd.Flags().BoolVar(&useEditor, "editor", false, "Edit the current issue body in the configured editor")
|
||||
cmd.Flags().StringVar(&milestoneName, "milestone-name", "", "Milestone by exact title; conflicts with --milestone")
|
||||
cmd.Flags().Int64Var(&milestone, "milestone", 0, "Milestone ID; 0 clears")
|
||||
metadata.register(cmd)
|
||||
return cmd
|
||||
}
|
||||
|
||||
func (a *application) editIssuesInteractively(cmd *cobra.Command, numbers []int64) error {
|
||||
target, err := a.resolve(cmd.Context(), true)
|
||||
if err != nil {
|
||||
return err
|
||||
}
|
||||
service := services.Issues{Client: target.client, Repository: target.Repo}
|
||||
selectables, err := service.CreateSelectables(cmd.Context())
|
||||
if err != nil {
|
||||
return err
|
||||
}
|
||||
milestones, labels := milestoneChoices(selectables.Milestones), labelChoices(selectables.Labels)
|
||||
return batch(a, cmd, numbers, issueLabel, func(n int64) (item services.Issue, err error) {
|
||||
current, err := service.View(cmd.Context(), n)
|
||||
if err != nil {
|
||||
return item, err
|
||||
}
|
||||
choices := terminal.IssueEditFormChoices{
|
||||
Title: current.Title, Body: current.Body, Assignees: current.Assignees,
|
||||
CanPush: selectables.CanPush, AvailableAssignees: selectables.Assignees, Milestones: milestones, AvailableLabels: labels,
|
||||
EditBody: a.bodyEditor(cmd),
|
||||
}
|
||||
if current.Milestone != nil {
|
||||
choices.Milestone = &terminal.IssueMilestoneChoice{Title: current.Milestone.Title, ID: current.Milestone.ID}
|
||||
}
|
||||
choices.Labels = labelChoices(current.Labels)
|
||||
if current.Deadline != nil {
|
||||
if parsed, err := time.Parse(time.RFC3339, *current.Deadline); err == nil {
|
||||
choices.Deadline = &parsed
|
||||
}
|
||||
}
|
||||
values, err := a.deps.IssueEditForm.EditIssue(cmd.Context(), choices)
|
||||
defer finishDraft(&values.Draft, &err)
|
||||
if err != nil {
|
||||
return item, abortBatch{err}
|
||||
}
|
||||
if err := a.confirm(cmd, fmt.Sprintf("Edit issue %s#%d: %s", target.Repo, n, values.Title)); err != nil {
|
||||
return item, abortBatch{err}
|
||||
}
|
||||
opts := services.IssueEdit{Title: &values.Title, Body: &values.Body}
|
||||
if selectables.CanPush {
|
||||
// Non-nil slices: an empty selection must clear rather than be omitted.
|
||||
assignees, labels := append([]string{}, values.Assignees...), append([]int64{}, values.Labels...)
|
||||
opts.Assignees, opts.Labels = &assignees, &labels
|
||||
if values.ClearMilestone || values.Milestone != 0 {
|
||||
opts.Milestone = &values.Milestone
|
||||
}
|
||||
opts.Deadline = values.Deadline
|
||||
if values.ClearDeadline {
|
||||
opts.RemoveDeadline = &values.ClearDeadline
|
||||
}
|
||||
}
|
||||
return service.Edit(cmd.Context(), n, opts)
|
||||
}, issueRow)
|
||||
}
|
||||
Reference in new issue
Block a user