feat!: rebuild tea on Cobra with explicit noun/verb commands (#1126)

- **switch tea to the Cobra command tree:** `internal/app` wires the packages from parts 1–4 into explicit noun/verb commands with `--repo`, `--json` / `--jq`, `--sudo` and `--debug`; `main.go` points at it. Build, release and docs tooling (`tools/cli-docs`, Makefile, goreleaser, snap, CI) and README / CONTRIBUTING are updated. - **remove the urfave/cli command tree:** deletes `cmd/`, `modules/`, the old integration tests, contrib completion scripts and the generated `docs/CLI.md`, and drops their dependencies. This commit only deletes. ## Breaking changes This is a breaking release. It requires Gitea 28 or newer; configuration moves to separate `config.yml` and `hosts.yml` files and requires fresh authentication, and command names, aliases, flags and output formats change. `docs/migration-1.0.md` maps every old command, flag and environment variable to its replacement. ## Issues fixes #1118 fixes #1116 fixes #1115 fixes #1094 fixes #1091 fixes #1073 fixes #1052 fixes #1032 fixes #1023 fixes #966 fixes #908 fixes #833 fixes #831 fixes #817 fixes #804 fixes #779 fixes #770 fixes #737 fixes #697 fixes #726 fixes #677 fixes #672 fixes #633 fixes #632 fixes #560 fixes #556 fixes #523 fixes #516 fixes #510 fixes #504 fixes #500 fixes #482 fixes #406 fixes #403 fixes #373 fixes #351 fixes #344 fixes #326 fixes #325 fixes #323 fixes #246 fixes #240 fixes #232 fixes #197 fixes #172 fixes #141 fixes #69 fixes #1110 fixes #569 fixes #480 fixes #666 fixes #670 fixes #457 fixes #643 fixes #498 fixes #490 fixes #1069 fixes #834 fixes #602 fixes #328 fixes #417 fixes #571 fixes #1029 fixes #489 fixes #1050 fixes #162 fixes #430 fixes #1087 fixes #683 Reviewed-on: https://gitea.com/gitea/tea/pulls/1126 Reviewed-by: TheFox0x7 <95654+thefox0x7@noreply.gitea.com>
2026-10-26 11:01:25 +01:00 · 2026-10-11 17:23:06 +00:00
1 parent 12e415a7a7
commit f02245449b
@@ -0,0 +1,106 @@
+// Copyright 2026 The Gitea Authors. All rights reserved.
+// SPDX-License-Identifier: MIT
+
+package app
+
+import (
+	"context"
+	"errors"
+	"strconv"
+	"strings"
+
+	"gitea.dev/tea/internal/clierr"
+	"gitea.dev/tea/internal/services"
+	"github.com/spf13/cobra"
+)
+
+// milestoneSelector validates a milestone ID or, with byName, a title before any request.
+func milestoneSelector(selector string, byName bool) (int64, error) {
+	if byName {
+		if strings.TrimSpace(selector) == "" {
+			return 0, clierr.Wrap(clierr.Usage, errors.New("milestone name cannot be empty"))
+		}
+		return 0, nil
+	}
+	return number(selector)
+}
+
+// existingMilestone resolves a title, or confirms that an ID exists.
+func existingMilestone(ctx context.Context, milestones services.Milestones, selector string, id int64, byName bool) (int64, error) {
+	if byName {
+		return milestones.ResolveName(ctx, selector)
+	}
+	_, err := milestones.View(ctx, id)
+	return id, err
+}
+
+func (a *application) milestoneIssueCommand() *cobra.Command {
+	group := &cobra.Command{Use: "issue", Short: "Manage milestone issues and pull requests"}
+	opts := services.ListOptions{}
+	var byName bool
+	list := &cobra.Command{Use: "list <id-or-name>", Short: "List issues and pull requests in a milestone", Args: argsExact(1), RunE: func(cmd *cobra.Command, args []string) error {
+		id, err := milestoneSelector(args[0], byName)
+		if err != nil {
+			return err
+		}
+		if err := oneOf("state", opts.State, "open", "closed", "all"); err != nil {
+			return err
+		}
+		if err := oneOf("kind", opts.Kind, "all", "issues", "pulls"); err != nil {
+			return err
+		}
+		target, err := a.resolve(cmd.Context(), true)
+		if err != nil {
+			return err
+		}
+		id, err = existingMilestone(cmd.Context(), services.Milestones{Client: target.client, Repository: target.Repo}, args[0], id, byName)
+		if err != nil {
+			return err
+		}
+		opts.Milestones = strconv.FormatInt(id, 10)
+		items, more, err := (services.Issues{Client: target.client, Repository: target.Repo}).List(cmd.Context(), opts)
+		if err != nil {
+			return err
+		}
+		if err := writeList(a, cmd, items, issueRow); err != nil {
+			return err
+		}
+		return a.morePagesHint(cmd, more, opts.Page)
+	}}
+	pageFlags(list, &opts.Limit, &opts.Page)
+	list.Flags().StringVar(&opts.State, "state", "open", "open, closed, or all")
+	list.Flags().StringVar(&opts.Kind, "kind", "all", "all, issues, or pulls")
+	list.Flags().BoolVar(&byName, "by-name", false, "Select by exact milestone title instead of ID")
+	group.AddCommand(list)
+	for _, verb := range []string{"add", "remove"} {
+		var byName bool
+		command := &cobra.Command{Use: verb + " <id-or-name> <number>...", Short: titleCase(verb) + " issues or pull requests in a milestone", Args: usageArgs(cobra.MinimumNArgs(2)), RunE: func(cmd *cobra.Command, args []string) error {
+			id, err := milestoneSelector(args[0], byName)
+			if err != nil {
+				return err
+			}
+			numbers, err := resourceNumbers(args[1:])
+			if err != nil {
+				return err
+			}
+			target, err := a.resolve(cmd.Context(), true)
+			if err != nil {
+				return err
+			}
+			id, err = existingMilestone(cmd.Context(), services.Milestones{Client: target.client, Repository: target.Repo}, args[0], id, byName)
+			if err != nil {
+				return err
+			}
+			service := services.Issues{Client: target.client, Repository: target.Repo}
+			return batch(a, cmd, numbers, issueLabel, func(n int64) (services.Issue, error) {
+				if verb == "remove" {
+					return service.RemoveMilestone(cmd.Context(), n, id)
+				}
+				return service.Edit(cmd.Context(), n, services.IssueEdit{Milestone: &id})
+			}, issueRow)
+		}}
+		command.Flags().BoolVar(&byName, "by-name", false, "Select by exact milestone title instead of ID")
+		group.AddCommand(command)
+	}
+	return group
+}