mirror of
https://gitea.com/gitea/tea.git
synced 2026-10-26 19:11:25 +01:00
feat!: rebuild tea on Cobra with explicit noun/verb commands (#1126)
- **switch tea to the Cobra command tree:** `internal/app` wires the packages from parts 1–4 into explicit noun/verb commands with `--repo`, `--json` / `--jq`, `--sudo` and `--debug`; `main.go` points at it. Build, release and docs tooling (`tools/cli-docs`, Makefile, goreleaser, snap, CI) and README / CONTRIBUTING are updated. - **remove the urfave/cli command tree:** deletes `cmd/`, `modules/`, the old integration tests, contrib completion scripts and the generated `docs/CLI.md`, and drops their dependencies. This commit only deletes. ## Breaking changes This is a breaking release. It requires Gitea 28 or newer; configuration moves to separate `config.yml` and `hosts.yml` files and requires fresh authentication, and command names, aliases, flags and output formats change. `docs/migration-1.0.md` maps every old command, flag and environment variable to its replacement. ## Issues fixes #1118 fixes #1116 fixes #1115 fixes #1094 fixes #1091 fixes #1073 fixes #1052 fixes #1032 fixes #1023 fixes #966 fixes #908 fixes #833 fixes #831 fixes #817 fixes #804 fixes #779 fixes #770 fixes #737 fixes #697 fixes #726 fixes #677 fixes #672 fixes #633 fixes #632 fixes #560 fixes #556 fixes #523 fixes #516 fixes #510 fixes #504 fixes #500 fixes #482 fixes #406 fixes #403 fixes #373 fixes #351 fixes #344 fixes #326 fixes #325 fixes #323 fixes #246 fixes #240 fixes #232 fixes #197 fixes #172 fixes #141 fixes #69 fixes #1110 fixes #569 fixes #480 fixes #666 fixes #670 fixes #457 fixes #643 fixes #498 fixes #490 fixes #1069 fixes #834 fixes #602 fixes #328 fixes #417 fixes #571 fixes #1029 fixes #489 fixes #1050 fixes #162 fixes #430 fixes #1087 fixes #683 Reviewed-on: https://gitea.com/gitea/tea/pulls/1126 Reviewed-by: TheFox0x7 <95654+thefox0x7@noreply.gitea.com>
This commit is contained in:
bircni committed
1 parent
12e415a7a7
commit
f02245449b
456 files changed
+18892
-34015
No files matched your search
@@ -0,0 +1,301 @@
|
||||
// Copyright 2026 The Gitea Authors. All rights reserved.
|
||||
// SPDX-License-Identifier: MIT
|
||||
|
||||
package app
|
||||
|
||||
import (
|
||||
"context"
|
||||
"encoding/json"
|
||||
"net/http"
|
||||
"os"
|
||||
"path/filepath"
|
||||
"strings"
|
||||
"testing"
|
||||
|
||||
"gitea.dev/tea/internal/clierr"
|
||||
"gitea.dev/tea/internal/terminal"
|
||||
"github.com/stretchr/testify/require"
|
||||
)
|
||||
|
||||
func publishCreateEnv(t *testing.T, creates *int) (Dependencies, *fakeGit, string) {
|
||||
t.Helper()
|
||||
server := newAuthenticatedServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
|
||||
require.Equal(t, http.MethodPost, r.Method)
|
||||
require.Equal(t, "/api/v1/repos/alice/project/pulls", r.URL.Path)
|
||||
*creates++
|
||||
var payload map[string]any
|
||||
require.NoError(t, json.NewDecoder(r.Body).Decode(&payload))
|
||||
require.Equal(t, "feature", payload["head"])
|
||||
_, _ = w.Write([]byte(`{"number":7,"title":"PR","html_url":"https://example.test/pulls/7"}`))
|
||||
}))
|
||||
t.Cleanup(server.Close)
|
||||
deps, _, _ := serverDeps(t, server.URL)
|
||||
pushKey := credentialCall(t, deps, server.URL, "alice", "push", "--", "origin", "refs/heads/feature")
|
||||
runner := &fakeGit{results: map[string]string{
|
||||
"rev-parse --is-inside-work-tree": "true",
|
||||
"rev-parse --verify refs/heads/feature^{commit}": "localsha",
|
||||
"remote": "origin",
|
||||
"remote get-url origin": server.URL + "/alice/project.git",
|
||||
"config --get branch.feature.remote": "origin",
|
||||
pushKey: "",
|
||||
}}
|
||||
deps.Git = runner
|
||||
return deps, runner, pushKey
|
||||
}
|
||||
|
||||
func TestPullCreateAgitPushesToMatchingRemoteWithoutRemoteFlag(t *testing.T) {
|
||||
server := newAuthenticatedServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
|
||||
switch {
|
||||
case r.URL.Path == "/api/v1/repos/alice/project":
|
||||
_, _ = w.Write([]byte(`{"full_name":"alice/project","default_branch":"main","permissions":{"push":true}}`))
|
||||
case strings.HasPrefix(r.URL.Path, "/api/v1/repos/alice/project/raw/"):
|
||||
w.WriteHeader(http.StatusNotFound)
|
||||
case r.Method == http.MethodGet:
|
||||
_, _ = w.Write([]byte(`[]`))
|
||||
default:
|
||||
t.Errorf("unexpected %s %s", r.Method, r.URL.Path)
|
||||
w.WriteHeader(http.StatusNotFound)
|
||||
}
|
||||
}))
|
||||
defer server.Close()
|
||||
deps, _, _ := serverDeps(t, server.URL)
|
||||
pushKey := credentialCall(t, deps, server.URL, "alice", "push", "-o", "title=Title", "--", "gitea", "refs/heads/feature:refs/for/main/feature")
|
||||
runner := &fakeGit{results: map[string]string{
|
||||
"remote": "origin gitea",
|
||||
"remote get-url origin": server.URL + "/bob/project.git",
|
||||
"remote get-url gitea": server.URL + "/alice/project.git",
|
||||
"rev-parse --is-inside-work-tree": "true",
|
||||
pushKey: "",
|
||||
}}
|
||||
deps.Git = runner
|
||||
deps.Prompter = &scriptedPrompter{accept: true}
|
||||
deps.PullForm = &recordingPullForm{values: terminal.PullFormValues{
|
||||
IssueFormValues: terminal.IssueFormValues{Title: "Title"}, Agit: true, Base: "main", Head: "feature",
|
||||
}}
|
||||
require.NoError(t, Execute(context.Background(), deps, []string{"pr", "create", "--agit", "-R", "alice/project", "--title", "Title", "--head", "feature", "--base", "main", "--no-input"}))
|
||||
deps.Streams.InTTY, deps.Streams.ErrTTY = true, true
|
||||
require.NoError(t, Execute(context.Background(), deps, []string{"pr", "create", "-R", "alice/project", "--interactive"}))
|
||||
pushes := 0
|
||||
for _, call := range runner.calls {
|
||||
if strings.Contains(call, " push ") {
|
||||
require.Equal(t, pushKey, call)
|
||||
pushes++
|
||||
}
|
||||
}
|
||||
require.Equal(t, 2, pushes)
|
||||
runner.results["remote"] = "one two"
|
||||
runner.results["remote get-url one"], runner.results["remote get-url two"] = server.URL+"/alice/project.git", server.URL+"/alice/project.git"
|
||||
err := Execute(context.Background(), deps, []string{"pr", "create", "--agit", "-R", "alice/project", "--title", "Title", "--head", "feature", "--base", "main", "--no-input"})
|
||||
require.Equal(t, clierr.Usage, clierr.ExitCode(err))
|
||||
require.ErrorContains(t, err, "select --remote")
|
||||
}
|
||||
|
||||
func TestPullCreateSkipsPushWhenHeadAlreadyPublished(t *testing.T) {
|
||||
creates := 0
|
||||
deps, runner, pushKey := publishCreateEnv(t, &creates)
|
||||
runner.results["for-each-ref --format=%(objectname) refs/remotes/origin/feature"] = "localsha"
|
||||
require.NoError(t, Execute(context.Background(), deps, []string{"pr", "create", "-R", "alice/project", "--title", "PR", "--head", "feature", "--base", "main", "--json=number", "--no-input"}))
|
||||
require.Equal(t, 1, creates)
|
||||
require.NotContains(t, runner.calls, pushKey)
|
||||
for _, call := range runner.calls {
|
||||
require.NotContains(t, call, "push --")
|
||||
}
|
||||
}
|
||||
|
||||
func TestPullCreatePushesWithYesWhenHeadUnpublished(t *testing.T) {
|
||||
creates := 0
|
||||
deps, runner, pushKey := publishCreateEnv(t, &creates)
|
||||
require.NoError(t, Execute(context.Background(), deps, []string{"pr", "create", "-R", "alice/project", "--title", "PR", "--head", "feature", "--base", "main", "--json=number", "--no-input", "--yes"}))
|
||||
require.Equal(t, 1, creates)
|
||||
require.Contains(t, runner.calls, pushKey)
|
||||
}
|
||||
|
||||
func TestPullCreateRequiresYesWhenHeadUnpublishedWithoutInput(t *testing.T) {
|
||||
creates := 0
|
||||
deps, runner, pushKey := publishCreateEnv(t, &creates)
|
||||
err := Execute(context.Background(), deps, []string{"pr", "create", "-R", "alice/project", "--title", "PR", "--head", "feature", "--base", "main", "--json=number", "--no-input"})
|
||||
require.Equal(t, clierr.Usage, clierr.ExitCode(err))
|
||||
require.ErrorContains(t, err, "--yes")
|
||||
require.Zero(t, creates)
|
||||
require.NotContains(t, runner.calls, pushKey)
|
||||
}
|
||||
|
||||
func TestPullCreateCanceledWhenPublishDeclined(t *testing.T) {
|
||||
creates := 0
|
||||
deps, runner, pushKey := publishCreateEnv(t, &creates)
|
||||
prompt := &scriptedPrompter{accept: false}
|
||||
deps.Prompter = prompt
|
||||
deps.Streams.InTTY, deps.Streams.ErrTTY = true, true
|
||||
err := Execute(context.Background(), deps, []string{"pr", "create", "-R", "alice/project", "--title", "PR", "--head", "feature", "--base", "main"})
|
||||
require.Equal(t, clierr.Canceled, clierr.ExitCode(err))
|
||||
require.Len(t, prompt.confirmations, 1)
|
||||
require.Zero(t, creates)
|
||||
require.NotContains(t, runner.calls, pushKey)
|
||||
}
|
||||
|
||||
func TestPullCreateAllowMaintainerEditsDefaultAndOverride(t *testing.T) {
|
||||
for _, tc := range []struct {
|
||||
name string
|
||||
flags []string
|
||||
want bool
|
||||
}{
|
||||
{"default true", nil, true},
|
||||
{"explicit false", []string{"--allow-maintainer-edits=false"}, false},
|
||||
{"edits alias", []string{"--edits=false"}, false},
|
||||
} {
|
||||
t.Run(tc.name, func(t *testing.T) {
|
||||
var payload map[string]any
|
||||
server := newAuthenticatedServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
|
||||
require.Equal(t, "/api/v1/repos/alice/project/pulls", r.URL.Path)
|
||||
require.NoError(t, json.NewDecoder(r.Body).Decode(&payload))
|
||||
_, _ = w.Write([]byte(`{"number":7,"title":"PR"}`))
|
||||
}))
|
||||
defer server.Close()
|
||||
deps, _, _ := serverDeps(t, server.URL)
|
||||
args := append([]string{"pr", "create", "-R", "alice/project", "--title", "PR", "--head", "feature", "--base", "main", "--json=number", "--no-input"}, tc.flags...)
|
||||
require.NoError(t, Execute(context.Background(), deps, args))
|
||||
require.Equal(t, tc.want, payload["allow_maintainer_edit"])
|
||||
})
|
||||
}
|
||||
}
|
||||
|
||||
func TestPullCreateRequestsReviewsAndUploadsAttachments(t *testing.T) {
|
||||
var reviewPayload map[string]any
|
||||
var uploaded []string
|
||||
server := newAuthenticatedServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
|
||||
switch {
|
||||
case r.URL.Path == "/api/v1/orgs/alice":
|
||||
_, _ = w.Write([]byte(`{"id":1}`))
|
||||
case r.URL.Path == "/api/v1/orgs/alice/teams" && r.URL.Query().Get("page") == "1":
|
||||
_, _ = w.Write([]byte(`[{"id":2,"name":"core"}]`))
|
||||
case r.URL.Path == "/api/v1/orgs/alice/teams":
|
||||
_, _ = w.Write([]byte(`[]`))
|
||||
case r.Method == http.MethodPost && r.URL.Path == "/api/v1/repos/alice/project/pulls":
|
||||
_, _ = w.Write([]byte(`{"number":7,"title":"PR","html_url":"https://example.test/pulls/7"}`))
|
||||
case r.Method == http.MethodPost && r.URL.Path == "/api/v1/repos/alice/project/pulls/7/requested_reviewers":
|
||||
require.NoError(t, json.NewDecoder(r.Body).Decode(&reviewPayload))
|
||||
w.WriteHeader(http.StatusCreated)
|
||||
case r.Method == http.MethodGet && r.URL.Path == "/api/v1/repos/alice/project/pulls/7":
|
||||
_, _ = w.Write([]byte(`{"number":7,"title":"PR","requested_reviewers":[{"login":"bob"},{"login":"carol"}],"requested_reviewers_teams":[{"name":"core"}]}`))
|
||||
case r.Method == http.MethodPost && r.URL.Path == "/api/v1/repos/alice/project/issues/7/assets":
|
||||
file, header, err := r.FormFile("attachment")
|
||||
require.NoError(t, err)
|
||||
_ = file.Close()
|
||||
uploaded = append(uploaded, header.Filename)
|
||||
if header.Filename == "broken.txt" {
|
||||
w.WriteHeader(http.StatusInternalServerError)
|
||||
return
|
||||
}
|
||||
_, _ = w.Write([]byte(`{"id":1,"name":"` + header.Filename + `"}`))
|
||||
default:
|
||||
t.Errorf("unexpected %s %s", r.Method, r.URL.Path)
|
||||
w.WriteHeader(http.StatusNotFound)
|
||||
}
|
||||
}))
|
||||
defer server.Close()
|
||||
dir := t.TempDir()
|
||||
for _, name := range []string{"log.txt", "broken.txt"} {
|
||||
require.NoError(t, os.WriteFile(filepath.Join(dir, name), []byte(name), 0o600))
|
||||
}
|
||||
deps, out, _ := serverDeps(t, server.URL)
|
||||
err := Execute(context.Background(), deps, []string{
|
||||
"pr", "create", "-R", "alice/project", "--title", "PR", "--head", "feature", "--base", "main", "--json=number,reviewers,reviewer_teams", "--no-input",
|
||||
"--reviewer", "bob,carol", "--reviewer-team", "core", "--attachment", filepath.Join(dir, "log.txt"), "--attachment", filepath.Join(dir, "broken.txt"),
|
||||
})
|
||||
require.ErrorContains(t, err, "pull request #7 was created")
|
||||
require.ErrorContains(t, err, "broken.txt")
|
||||
require.Equal(t, map[string]any{"reviewers": []any{"bob", "carol"}, "team_reviewers": []any{"core"}}, reviewPayload)
|
||||
require.Equal(t, []string{"log.txt", "broken.txt"}, uploaded)
|
||||
require.JSONEq(t, `{"number":7,"reviewers":["bob","carol"],"reviewer_teams":["core"]}`, out.String())
|
||||
}
|
||||
|
||||
func TestPullCreateRejectsUnknownReviewerTeamBeforeCreating(t *testing.T) {
|
||||
server := newAuthenticatedServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
|
||||
switch r.URL.Path {
|
||||
case "/api/v1/orgs/alice":
|
||||
_, _ = w.Write([]byte(`{"id":1}`))
|
||||
case "/api/v1/orgs/alice/teams":
|
||||
_, _ = w.Write([]byte(`[]`))
|
||||
default:
|
||||
t.Errorf("unexpected %s %s", r.Method, r.URL.Path)
|
||||
w.WriteHeader(http.StatusNotFound)
|
||||
}
|
||||
}))
|
||||
defer server.Close()
|
||||
deps, _, _ := serverDeps(t, server.URL)
|
||||
err := Execute(context.Background(), deps, []string{"pr", "create", "-R", "alice/project", "--title", "PR", "--head", "feature", "--base", "main", "--no-input", "--reviewer-team", "ghost"})
|
||||
require.ErrorContains(t, err, `team "ghost" is unavailable`)
|
||||
}
|
||||
|
||||
func TestPullCreateDerivesTitleAndBodyFromSingleCommit(t *testing.T) {
|
||||
message := "Add login form\n\nExplains why."
|
||||
for _, tc := range []struct {
|
||||
name, title, body string
|
||||
results map[string]string
|
||||
flags []string
|
||||
}{
|
||||
{"single commit", "Add login form", "Explains why.", map[string]string{"rev-list --count origin/main..feature": "1", "log -1 --format=%s%n%n%b feature": message}, nil},
|
||||
{"base remote", "Add login form", "Explains why.", map[string]string{"rev-list --count upstream/main..feature": "1", "log -1 --format=%s%n%n%b feature": message}, nil},
|
||||
{"local base", "Add login form", "", map[string]string{"rev-list --count main..feature": "1", "log -1 --format=%s%n%n%b feature": "Add login form"}, nil},
|
||||
{"explicit body kept", "Add login form", "Mine", map[string]string{"rev-list --count origin/main..feature": "1", "log -1 --format=%s%n%n%b feature": message}, []string{"--body", "Mine"}},
|
||||
{"explicit title kept", "Mine", "", map[string]string{"rev-list --count origin/main..feature": "1", "log -1 --format=%s%n%n%b feature": message}, []string{"--title", "Mine"}},
|
||||
{"several commits", "Feature", "", map[string]string{"rev-list --count origin/main..feature": "2", "log -1 --format=%s%n%n%b feature": message}, nil},
|
||||
{"git failure", "Feature", "", nil, nil},
|
||||
} {
|
||||
t.Run(tc.name, func(t *testing.T) {
|
||||
var payload map[string]any
|
||||
server := newAuthenticatedServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
|
||||
require.Equal(t, "/api/v1/repos/alice/project/pulls", r.URL.Path)
|
||||
require.NoError(t, json.NewDecoder(r.Body).Decode(&payload))
|
||||
_, _ = w.Write([]byte(`{"number":7}`))
|
||||
}))
|
||||
defer server.Close()
|
||||
deps, _, diagnostics := serverDeps(t, server.URL)
|
||||
deps.Git = &fakeGit{results: tc.results}
|
||||
args := append([]string{"pr", "create", "-R", "alice/project", "--head", "feature", "--base", "main", "--json=number", "--no-input"}, tc.flags...)
|
||||
require.NoError(t, Execute(context.Background(), deps, args))
|
||||
require.Equal(t, tc.title, payload["title"])
|
||||
require.Equal(t, tc.body, payload["body"])
|
||||
require.Empty(t, diagnostics.String())
|
||||
})
|
||||
}
|
||||
}
|
||||
|
||||
func TestPullCreateEditorSeedsPullRequestTemplate(t *testing.T) {
|
||||
var payload map[string]any
|
||||
var templateRequests []string
|
||||
server := newAuthenticatedServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
|
||||
switch {
|
||||
case strings.HasPrefix(r.URL.Path, "/api/v1/repos/alice/project/raw/"):
|
||||
require.Equal(t, "main", r.URL.Query().Get("ref"))
|
||||
templateRequests = append(templateRequests, strings.TrimPrefix(r.URL.Path, "/api/v1/repos/alice/project/raw/"))
|
||||
if r.URL.Path != "/api/v1/repos/alice/project/raw/.gitea/PULL_REQUEST_TEMPLATE.md" {
|
||||
w.WriteHeader(http.StatusNotFound)
|
||||
return
|
||||
}
|
||||
_, _ = w.Write([]byte("## Checklist\n"))
|
||||
case r.Method == http.MethodPost && r.URL.Path == "/api/v1/repos/alice/project/pulls":
|
||||
require.NoError(t, json.NewDecoder(r.Body).Decode(&payload))
|
||||
_, _ = w.Write([]byte(`{"number":7}`))
|
||||
default:
|
||||
t.Errorf("unexpected %s %s", r.Method, r.URL.Path)
|
||||
w.WriteHeader(http.StatusNotFound)
|
||||
}
|
||||
}))
|
||||
defer server.Close()
|
||||
deps, _, _ := testDeps(t)
|
||||
editor, _ := newDraftEditor(t, "filled")
|
||||
deps.Editor = editor
|
||||
deps.Getenv = serverEnv(server.URL, map[string]string{"EDITOR": "editor"})
|
||||
require.NoError(t, Execute(context.Background(), deps, []string{"pr", "create", "-R", "alice/project", "--title", "PR", "--head", "feature", "--base", "main", "--editor", "--json=number", "--no-input"}))
|
||||
require.Equal(t, "## Checklist\n", editor.initial)
|
||||
require.Equal(t, []string{"PULL_REQUEST_TEMPLATE.md", "pull_request_template.md", ".gitea/PULL_REQUEST_TEMPLATE.md"}, templateRequests)
|
||||
require.Equal(t, "filled", payload["body"])
|
||||
}
|
||||
|
||||
func TestPullCreateHelpListsDefaultsOnce(t *testing.T) {
|
||||
deps, out, _ := testDeps(t)
|
||||
require.NoError(t, Execute(context.Background(), deps, []string{"pr", "create", "--help"}))
|
||||
require.Contains(t, out.String(), "(default true)")
|
||||
require.NotContains(t, out.String(), "(default true) (default true)")
|
||||
}
|
||||
Reference in new issue
Block a user