feat!: rebuild tea on Cobra with explicit noun/verb commands (#1126)

- **switch tea to the Cobra command tree:** `internal/app` wires the packages from parts 1–4 into explicit noun/verb commands with `--repo`, `--json` / `--jq`, `--sudo` and `--debug`; `main.go` points at it. Build, release and docs tooling (`tools/cli-docs`, Makefile, goreleaser, snap, CI) and README / CONTRIBUTING are updated. - **remove the urfave/cli command tree:** deletes `cmd/`, `modules/`, the old integration tests, contrib completion scripts and the generated `docs/CLI.md`, and drops their dependencies. This commit only deletes. ## Breaking changes This is a breaking release. It requires Gitea 28 or newer; configuration moves to separate `config.yml` and `hosts.yml` files and requires fresh authentication, and command names, aliases, flags and output formats change. `docs/migration-1.0.md` maps every old command, flag and environment variable to its replacement. ## Issues fixes #1118 fixes #1116 fixes #1115 fixes #1094 fixes #1091 fixes #1073 fixes #1052 fixes #1032 fixes #1023 fixes #966 fixes #908 fixes #833 fixes #831 fixes #817 fixes #804 fixes #779 fixes #770 fixes #737 fixes #697 fixes #726 fixes #677 fixes #672 fixes #633 fixes #632 fixes #560 fixes #556 fixes #523 fixes #516 fixes #510 fixes #504 fixes #500 fixes #482 fixes #406 fixes #403 fixes #373 fixes #351 fixes #344 fixes #326 fixes #325 fixes #323 fixes #246 fixes #240 fixes #232 fixes #197 fixes #172 fixes #141 fixes #69 fixes #1110 fixes #569 fixes #480 fixes #666 fixes #670 fixes #457 fixes #643 fixes #498 fixes #490 fixes #1069 fixes #834 fixes #602 fixes #328 fixes #417 fixes #571 fixes #1029 fixes #489 fixes #1050 fixes #162 fixes #430 fixes #1087 fixes #683 Reviewed-on: https://gitea.com/gitea/tea/pulls/1126 Reviewed-by: TheFox0x7 <95654+thefox0x7@noreply.gitea.com>
2026-10-26 19:11:25 +01:00 · 2026-10-11 17:23:06 +00:00
1 parent 12e415a7a7
commit f02245449b
@@ -0,0 +1,153 @@
+// Copyright 2026 The Gitea Authors. All rights reserved.
+// SPDX-License-Identifier: MIT
+
+package app
+
+import (
+	"errors"
+	"strings"
+
+	"gitea.dev/tea/internal/clierr"
+	"gitea.dev/tea/internal/services"
+	"gitea.dev/tea/internal/terminal"
+	"github.com/spf13/cobra"
+)
+
+func (a *application) pullEditCommand() *cobra.Command {
+	var title, body, file, base string
+	var deadline string
+	var draft, ready, maintainer bool
+	var useEditor bool
+	var milestone int64
+	var milestoneName string
+	var metadata metadataFlags
+	var reviewers services.ReviewRequestChanges
+	cmd := &cobra.Command{Use: "edit <number>", Short: "Edit pull request content, base, and draft state", Args: argsExact(1), RunE: func(cmd *cobra.Command, args []string) (runErr error) {
+		var editorDraft terminal.Draft
+		defer finishDraft(&editorDraft, &runErr)
+		if err := validateBodySources(cmd); err != nil {
+			return err
+		}
+		n, err := number(args[0])
+		if err != nil {
+			return err
+		}
+		if draft && ready {
+			return clierr.Wrap(clierr.Usage, errors.New("--draft and --ready are mutually exclusive"))
+		}
+		if err := validateMilestoneFlags(cmd, milestoneName, milestone); err != nil {
+			return err
+		}
+		opts := services.PullEdit{}
+		if cmd.Flags().Changed("deadline") {
+			opts.Deadline, opts.RemoveDeadline, err = parseDeadline(deadline)
+			if err != nil {
+				return err
+			}
+		}
+		if cmd.Flags().Changed("add-reviewers") || cmd.Flags().Changed("remove-reviewers") || cmd.Flags().Changed("add-reviewer-teams") || cmd.Flags().Changed("remove-reviewer-teams") {
+			trimNames(reviewers.Add.Users, reviewers.Remove.Users, reviewers.Add.Teams, reviewers.Remove.Teams)
+			if err := reviewers.Validate(); err != nil {
+				return clierr.Wrap(clierr.Usage, err)
+			}
+			opts.ReviewerChanges = &reviewers
+		}
+		if cmd.Flags().Changed("milestone") {
+			opts.Milestone = &milestone
+		}
+		if err := metadata.validate(cmd); err != nil {
+			return err
+		}
+		if cmd.Flags().Changed("title") {
+			if strings.TrimSpace(title) == "" {
+				return clierr.Wrap(clierr.Usage, errors.New("pull request title cannot be empty"))
+			}
+			opts.Title = &title
+		}
+		if cmd.Flags().Changed("body") || cmd.Flags().Changed("body-file") {
+			body, err = a.readBody(cmd, body, file)
+			if err != nil {
+				return err
+			}
+			opts.Body = &body
+		}
+		if cmd.Flags().Changed("base") {
+			if strings.TrimSpace(base) == "" {
+				return clierr.Wrap(clierr.Usage, errors.New("--base cannot be empty"))
+			}
+			opts.Base = &base
+		}
+		if cmd.Flags().Changed("allow-maintainer-edit") {
+			opts.AllowMaintainerEdit = &maintainer
+		}
+		if opts == (services.PullEdit{}) && !useEditor && !draft && !ready && !metadata.changed(cmd) && !cmd.Flags().Changed("milestone-name") {
+			return clierr.Wrap(clierr.Usage, errors.New("supply an edit flag; see tea pr edit --help"))
+		}
+		target, err := a.resolve(cmd.Context(), true)
+		if err != nil {
+			return err
+		}
+		if cmd.Flags().Changed("milestone-name") {
+			milestone, err = (services.Milestones{Client: target.client, Repository: target.Repo}).ResolveName(cmd.Context(), milestoneName)
+			if err != nil {
+				return err
+			}
+			opts.Milestone = &milestone
+		}
+		if opts.Labels, opts.Assignees, opts.Changes, err = metadata.resolve(cmd, target); err != nil {
+			return err
+		}
+		service := services.Pulls{Client: target.client, Repository: target.Repo}
+		if draft || ready {
+			if opts.Title == nil {
+				current, err := service.View(cmd.Context(), n)
+				if err != nil {
+					return err
+				}
+				title = current.Title
+			}
+			if draft {
+				title = services.AddDraftPrefix(title)
+			} else {
+				title = services.StripDraftPrefix(title)
+			}
+			if strings.TrimSpace(title) == "" {
+				return clierr.Wrap(clierr.Usage, errors.New("draft marker removal leaves an empty title; supply --title"))
+			}
+			opts.Title = &title
+		}
+		if useEditor {
+			current, err := service.View(cmd.Context(), n)
+			if err != nil {
+				return err
+			}
+			editorDraft, err = a.editDraft(cmd, current.Body)
+			if err != nil {
+				return err
+			}
+			opts.Body = &editorDraft.Body
+		}
+		item, err := service.Edit(cmd.Context(), n, opts)
+		if err != nil {
+			return err
+		}
+		return writeRecord(a, cmd, item, pullRecord)
+	}}
+	cmd.Flags().StringVar(&title, "title", "", "Pull request title")
+	cmd.Flags().StringVar(&deadline, "deadline", "", "Due date: YYYY-MM-DD, RFC3339, or Unix timestamp; empty clears")
+	cmd.Flags().StringVar(&body, "body", "", "Pull request body (empty clears)")
+	cmd.Flags().StringVar(&file, "body-file", "", "Read body from file, or - for stdin")
+	cmd.Flags().BoolVar(&useEditor, "editor", false, "Edit the current pull request body in the configured editor")
+	cmd.Flags().StringVar(&base, "base", "", "Target branch")
+	cmd.Flags().BoolVar(&draft, "draft", false, "Mark the pull request as a draft")
+	cmd.Flags().BoolVar(&ready, "ready", false, "Remove the draft title marker")
+	cmd.Flags().BoolVar(&maintainer, "allow-maintainer-edit", false, "Allow maintainers to modify the head branch")
+	cmd.Flags().StringVar(&milestoneName, "milestone-name", "", "Milestone by exact title; conflicts with --milestone")
+	cmd.Flags().Int64Var(&milestone, "milestone", 0, "Milestone ID; 0 clears")
+	metadata.register(cmd)
+	cmd.Flags().StringSliceVar(&reviewers.Add.Users, "add-reviewers", nil, "Request reviews from users")
+	cmd.Flags().StringSliceVar(&reviewers.Remove.Users, "remove-reviewers", nil, "Remove requests for users")
+	cmd.Flags().StringSliceVar(&reviewers.Add.Teams, "add-reviewer-teams", nil, "Request reviews from organization teams")
+	cmd.Flags().StringSliceVar(&reviewers.Remove.Teams, "remove-reviewer-teams", nil, "Remove requests for organization teams")
+	return cmd
+}