feat!: rebuild tea on Cobra with explicit noun/verb commands (#1126)

- **switch tea to the Cobra command tree:** `internal/app` wires the packages from parts 1–4 into explicit noun/verb commands with `--repo`, `--json` / `--jq`, `--sudo` and `--debug`; `main.go` points at it. Build, release and docs tooling (`tools/cli-docs`, Makefile, goreleaser, snap, CI) and README / CONTRIBUTING are updated. - **remove the urfave/cli command tree:** deletes `cmd/`, `modules/`, the old integration tests, contrib completion scripts and the generated `docs/CLI.md`, and drops their dependencies. This commit only deletes. ## Breaking changes This is a breaking release. It requires Gitea 28 or newer; configuration moves to separate `config.yml` and `hosts.yml` files and requires fresh authentication, and command names, aliases, flags and output formats change. `docs/migration-1.0.md` maps every old command, flag and environment variable to its replacement. ## Issues fixes #1118 fixes #1116 fixes #1115 fixes #1094 fixes #1091 fixes #1073 fixes #1052 fixes #1032 fixes #1023 fixes #966 fixes #908 fixes #833 fixes #831 fixes #817 fixes #804 fixes #779 fixes #770 fixes #737 fixes #697 fixes #726 fixes #677 fixes #672 fixes #633 fixes #632 fixes #560 fixes #556 fixes #523 fixes #516 fixes #510 fixes #504 fixes #500 fixes #482 fixes #406 fixes #403 fixes #373 fixes #351 fixes #344 fixes #326 fixes #325 fixes #323 fixes #246 fixes #240 fixes #232 fixes #197 fixes #172 fixes #141 fixes #69 fixes #1110 fixes #569 fixes #480 fixes #666 fixes #670 fixes #457 fixes #643 fixes #498 fixes #490 fixes #1069 fixes #834 fixes #602 fixes #328 fixes #417 fixes #571 fixes #1029 fixes #489 fixes #1050 fixes #162 fixes #430 fixes #1087 fixes #683 Reviewed-on: https://gitea.com/gitea/tea/pulls/1126 Reviewed-by: TheFox0x7 <95654+thefox0x7@noreply.gitea.com>
2026-10-26 19:11:25 +01:00 · 2026-10-11 17:23:06 +00:00
1 parent 12e415a7a7
commit f02245449b
@@ -0,0 +1,223 @@
+// Copyright 2026 The Gitea Authors. All rights reserved.
+// SPDX-License-Identifier: MIT
+
+package app
+
+import (
+	"errors"
+	"fmt"
+	"path/filepath"
+	"strings"
+
+	"gitea.dev/tea/internal/clierr"
+	"gitea.dev/tea/internal/services"
+	"gitea.dev/tea/internal/terminal"
+	"github.com/spf13/cobra"
+)
+
+func releaseRecord(item services.Release) terminal.Record {
+	return terminal.Record{Heading: terminal.Row(item.Tag, item.Title), Lines: []string{item.URL}}
+}
+
+func releaseRow(item services.Release) []terminal.Cell {
+	status := "released"
+	switch {
+	case item.Draft:
+		status = "draft"
+	case item.Prerelease:
+		status = "prerelease"
+	}
+	return []terminal.Cell{{Text: item.Tag, Link: item.URL}, {Text: item.Title}, {Text: status}}
+}
+
+func (a *application) releaseCommand() *cobra.Command {
+	group := &cobra.Command{Use: "release", Short: "Manage repository releases"}
+	var limit, page int
+	list := &cobra.Command{Use: "list", Short: "List releases", Args: argsExact(0), RunE: func(cmd *cobra.Command, _ []string) error {
+		target, err := a.resolve(cmd.Context(), true)
+		if err != nil {
+			return err
+		}
+		items, err := (services.Releases{Client: target.client, Repository: target.Repo}).List(cmd.Context(), limit, page)
+		if err != nil {
+			return err
+		}
+		return writeList(a, cmd, items, releaseRow)
+	}}
+	pageFlags(list, &limit, &page)
+	group.AddCommand(list)
+	for _, verb := range []string{"view", "create", "edit", "publish", "delete"} {
+		var tag, title, body, file, targetName string
+		var draft, prerelease, deleteTag, useEditor bool
+		var assetPaths []string
+		command := &cobra.Command{Use: verb + " <tag>", Short: titleCase(verb) + " repository releases", Args: argsExact(1)}
+		if verb == "edit" || verb == "delete" || verb == "publish" {
+			command.Use = verb + " <tag>..."
+			command.Args = usageArgs(cobra.MinimumNArgs(1))
+		}
+		if verb == "create" {
+			command.Use = "create [tag]"
+			command.Args = usageArgs(cobra.MaximumNArgs(1))
+			command.Flags().StringVar(&tag, "tag", "", "Release tag")
+			command.Flags().StringSliceVar(&assetPaths, "asset", nil, "Asset file to upload after creation (repeatable)")
+		}
+		if verb == "create" || verb == "edit" {
+			if verb == "edit" {
+				command.Flags().StringVar(&tag, "tag", "", "Change the release tag (one release only)")
+			}
+			command.Flags().StringVar(&title, "title", "", "Release title (creation defaults to tag)")
+			command.Flags().BoolVar(&useEditor, "editor", false, "Edit release notes in an editor")
+			command.Flags().StringVar(&body, "body", "", "Release notes")
+			command.Flags().StringVar(&file, "body-file", "", "Read notes from file, or - for stdin")
+			command.Flags().StringVar(&targetName, "target", "", "Target branch or commit for the tag")
+			command.Flags().BoolVar(&draft, "draft", false, "Draft release")
+			command.Flags().BoolVar(&prerelease, "prerelease", false, "Prerelease")
+		}
+		if verb == "delete" {
+			command.Flags().BoolVar(&deleteTag, "delete-tag", false, "Delete the associated Git tag too")
+		}
+		command.RunE = func(cmd *cobra.Command, args []string) (runErr error) {
+			var editorDraft terminal.Draft
+			defer finishDraft(&editorDraft, &runErr)
+			if err := validateBodySources(cmd); err != nil {
+				return err
+			}
+			if useEditor && verb == "edit" && len(args) != 1 {
+				return clierr.Wrap(clierr.Usage, errors.New("--editor requires one release"))
+			}
+			opts := services.ReleaseOptions{}
+			files, err := openRegularFiles(assetPaths)
+			defer closeFiles(files)
+			if err != nil {
+				return err
+			}
+			prompted := false
+			if verb == "create" {
+				if len(args) > 0 {
+					if cmd.Flags().Changed("tag") {
+						return clierr.Wrap(clierr.Usage, errors.New("supply a tag argument or --tag, not both"))
+					}
+					tag = args[0]
+				}
+				if tag == "" && file == "-" {
+					return clierr.Wrap(clierr.Usage, errors.New("--body-file - requires a tag; stdin cannot also supply a prompt"))
+				}
+				prompted, err = a.require(cmd, &tag, "tag")
+				if err != nil {
+					return err
+				}
+				if title == "" && !cmd.Flags().Changed("title") {
+					title = tag
+				}
+				opts.Tag = &tag
+				opts.Title = &title
+				opts.Draft = &draft
+				opts.Prerelease = &prerelease
+			}
+			if verb == "create" || verb == "edit" {
+				if verb == "edit" && cmd.Flags().Changed("tag") {
+					if len(args) != 1 || strings.TrimSpace(tag) == "" {
+						return clierr.Wrap(clierr.Usage, errors.New("--tag requires one release and a nonempty new tag"))
+					}
+					opts.Tag = &tag
+				}
+				if cmd.Flags().Changed("title") {
+					if strings.TrimSpace(title) == "" {
+						return clierr.Wrap(clierr.Usage, errors.New("release title cannot be empty"))
+					}
+					opts.Title = &title
+				}
+				if cmd.Flags().Changed("body") || cmd.Flags().Changed("body-file") {
+					var err error
+					body, err = a.readBody(cmd, body, file)
+					if err != nil {
+						return err
+					}
+					opts.Body = &body
+				}
+				if cmd.Flags().Changed("target") {
+					opts.Target = &targetName
+				}
+				if cmd.Flags().Changed("draft") {
+					opts.Draft = &draft
+				}
+				if cmd.Flags().Changed("prerelease") {
+					opts.Prerelease = &prerelease
+				}
+				if verb == "edit" && !useEditor && opts == (services.ReleaseOptions{}) {
+					return clierr.Wrap(clierr.Usage, errors.New("supply release fields to edit"))
+				}
+			}
+			target, err := a.resolve(cmd.Context(), true)
+			if err != nil {
+				return err
+			}
+			service := services.Releases{Client: target.client, Repository: target.Repo}
+			if useEditor {
+				initial := ""
+				if verb == "edit" {
+					item, err := service.View(cmd.Context(), args[0])
+					if err != nil {
+						return err
+					}
+					initial = item.Body
+				}
+				editorDraft, err = a.editDraft(cmd, initial)
+				if err != nil {
+					return err
+				}
+				opts.Body = &editorDraft.Body
+			}
+			if verb == "delete" || prompted {
+				subject := strings.Join(args, " ")
+				if verb == "create" {
+					subject = tag
+				}
+				if err := a.confirm(cmd, fmt.Sprintf("%s release %s on %s", verb, subject, target.Repo)); err != nil {
+					return err
+				}
+			}
+			if verb == "create" {
+				item, err := service.Create(cmd.Context(), opts)
+				if err != nil {
+					return err
+				}
+				var failures []error
+				for _, file := range files {
+					if _, err := service.UploadAsset(cmd.Context(), item.ID, filepath.Base(file.Name()), file); err != nil {
+						failures = append(failures, fmt.Errorf("release %s created; asset %s upload failed: %w", item.Tag, filepath.Base(file.Name()), err))
+					}
+				}
+				if err := writeRecord(a, cmd, item, releaseRecord); err != nil {
+					return err
+				}
+				return errors.Join(failures...)
+			}
+			if verb == "view" {
+				item, err := service.View(cmd.Context(), args[0])
+				if err != nil {
+					return err
+				}
+				return writeRecord(a, cmd, item, releaseRecord)
+			}
+			return batch(a, cmd, args, func(name string) string { return "release " + name }, func(name string) (services.Release, error) {
+				item, err := service.View(cmd.Context(), name)
+				if err == nil {
+					switch verb {
+					case "edit":
+						item, err = service.Edit(cmd.Context(), item.ID, opts)
+					case "publish":
+						published := false
+						item, err = service.Edit(cmd.Context(), item.ID, services.ReleaseOptions{Draft: &published})
+					case "delete":
+						err = service.Delete(cmd.Context(), item, deleteTag)
+					}
+				}
+				return item, err
+			}, releaseRow)
+		}
+		group.AddCommand(command)
+	}
+	group.AddCommand(a.releaseAssetCommand())
+	return group
+}