feat!: rebuild tea on Cobra with explicit noun/verb commands (#1126)

- **switch tea to the Cobra command tree:** `internal/app` wires the packages from parts 1–4 into explicit noun/verb commands with `--repo`, `--json` / `--jq`, `--sudo` and `--debug`; `main.go` points at it. Build, release and docs tooling (`tools/cli-docs`, Makefile, goreleaser, snap, CI) and README / CONTRIBUTING are updated. - **remove the urfave/cli command tree:** deletes `cmd/`, `modules/`, the old integration tests, contrib completion scripts and the generated `docs/CLI.md`, and drops their dependencies. This commit only deletes. ## Breaking changes This is a breaking release. It requires Gitea 28 or newer; configuration moves to separate `config.yml` and `hosts.yml` files and requires fresh authentication, and command names, aliases, flags and output formats change. `docs/migration-1.0.md` maps every old command, flag and environment variable to its replacement. ## Issues fixes #1118 fixes #1116 fixes #1115 fixes #1094 fixes #1091 fixes #1073 fixes #1052 fixes #1032 fixes #1023 fixes #966 fixes #908 fixes #833 fixes #831 fixes #817 fixes #804 fixes #779 fixes #770 fixes #737 fixes #697 fixes #726 fixes #677 fixes #672 fixes #633 fixes #632 fixes #560 fixes #556 fixes #523 fixes #516 fixes #510 fixes #504 fixes #500 fixes #482 fixes #406 fixes #403 fixes #373 fixes #351 fixes #344 fixes #326 fixes #325 fixes #323 fixes #246 fixes #240 fixes #232 fixes #197 fixes #172 fixes #141 fixes #69 fixes #1110 fixes #569 fixes #480 fixes #666 fixes #670 fixes #457 fixes #643 fixes #498 fixes #490 fixes #1069 fixes #834 fixes #602 fixes #328 fixes #417 fixes #571 fixes #1029 fixes #489 fixes #1050 fixes #162 fixes #430 fixes #1087 fixes #683 Reviewed-on: https://gitea.com/gitea/tea/pulls/1126 Reviewed-by: TheFox0x7 <95654+thefox0x7@noreply.gitea.com>
2026-10-26 11:01:25 +01:00 · 2026-10-11 17:23:06 +00:00
1 parent 12e415a7a7
commit f02245449b
@@ -1,157 +0,0 @@
-// Copyright 2020 The Gitea Authors. All rights reserved.
-// SPDX-License-Identifier: MIT
-
-package config
-
-import (
-	"fmt"
-	"os"
-	"path/filepath"
-	"sync"
-
-	"gitea.dev/tea/modules/utils"
-
-	"github.com/adrg/xdg"
-	"gopkg.in/yaml.v3"
-)
-
-// FlagDefaults defines all flags that can be overridden with a default value
-// via the config file
-type FlagDefaults struct {
-	// Prefer a specific git remote to use for selecting a repository on gitea,
-	// instead of relying on the remote associated with main/master/trunk branch.
-	// The --remote flag still has precedence over this value.
-	Remote string `yaml:"remote"`
-}
-
-// Preferences that are stored in and read from the config file
-type Preferences struct {
-	// Prefer using an external text editor over inline multiline prompts
-	Editor       bool         `yaml:"editor"`
-	FlagDefaults FlagDefaults `yaml:"flag_defaults"`
-}
-
-// LocalConfig represents local configurations
-type LocalConfig struct {
-	Logins []Login     `yaml:"logins"`
-	Prefs  Preferences `yaml:"preferences"`
-}
-
-var (
-	// config contain if loaded local tea config
-	config                 LocalConfig
-	loadConfigOnce         sync.Once
-	configPathMu           sync.Mutex
-	configPathTestOverride string
-)
-
-// GetConfigPath return path to tea config file
-func GetConfigPath() string {
-	configPathMu.Lock()
-	override := configPathTestOverride
-	configPathMu.Unlock()
-	if override != "" {
-		return override
-	}
-
-	configFilePath, err := xdg.ConfigFile("tea/config.yml")
-
-	var exists bool
-	if err != nil {
-		exists = false
-	} else {
-		exists, _ = utils.PathExists(configFilePath)
-	}
-
-	// fallback to old config if no new one exists
-	if !exists {
-		file := filepath.Join(xdg.Home, ".tea", "tea.yml")
-		exists, _ = utils.PathExists(file)
-		if exists {
-			return file
-		}
-	}
-
-	if err != nil {
-		fmt.Fprintln(os.Stderr, "unable to get or create config file")
-		os.Exit(1)
-	}
-
-	return configFilePath
-}
-
-// SetConfigPathForTesting overrides the config path used by helpers in tests.
-func SetConfigPathForTesting(path string) {
-	configPathMu.Lock()
-	configPathTestOverride = path
-	configPathMu.Unlock()
-}
-
-// GetPreferences returns preferences based on the config file
-func GetPreferences() Preferences {
-	_ = loadConfig()
-	return config.Prefs
-}
-
-// loadConfig load config from file
-func loadConfig() (err error) {
-	loadConfigOnce.Do(func() {
-		ymlPath := GetConfigPath()
-		exist, _ := utils.FileExist(ymlPath)
-		if exist {
-			bs, readErr := os.ReadFile(ymlPath)
-			if readErr != nil {
-				err = fmt.Errorf("failed to read config file %s: %w", ymlPath, readErr)
-				return
-			}
-
-			if unmarshalErr := yaml.Unmarshal(bs, &config); unmarshalErr != nil {
-				err = fmt.Errorf("failed to parse config file %s: %w", ymlPath, unmarshalErr)
-				return
-			}
-		}
-	})
-	return
-}
-
-// reloadConfigFromDisk re-reads the config file from disk, bypassing the sync.Once.
-// This is used after acquiring a lock to ensure we have the latest config state.
-// The caller must hold the config lock.
-func reloadConfigFromDisk() error {
-	ymlPath := GetConfigPath()
-	exist, _ := utils.FileExist(ymlPath)
-	if !exist {
-		// No config file yet, start with empty config
-		config = LocalConfig{}
-		return nil
-	}
-
-	bs, err := os.ReadFile(ymlPath)
-	if err != nil {
-		return fmt.Errorf("failed to read config file %s: %w", ymlPath, err)
-	}
-
-	if err := yaml.Unmarshal(bs, &config); err != nil {
-		return fmt.Errorf("failed to parse config file %s: %w", ymlPath, err)
-	}
-
-	return nil
-}
-
-// SetConfigForTesting replaces the in-memory config and marks it as loaded.
-// This allows tests to inject config without relying on file-based loading.
-func SetConfigForTesting(cfg LocalConfig) {
-	loadConfigOnce.Do(func() {}) // ensure sync.Once is spent
-	config = cfg
-}
-
-// saveConfigUnsafe saves config to file without acquiring a lock.
-// Caller must hold the config lock.
-func saveConfigUnsafe() error {
-	ymlPath := GetConfigPath()
-	bs, err := yaml.Marshal(config)
-	if err != nil {
-		return err
-	}
-	return os.WriteFile(ymlPath, bs, 0o600)
-}