feat!: rebuild tea on Cobra with explicit noun/verb commands (#1126)

- **switch tea to the Cobra command tree:** `internal/app` wires the packages from parts 1–4 into explicit noun/verb commands with `--repo`, `--json` / `--jq`, `--sudo` and `--debug`; `main.go` points at it. Build, release and docs tooling (`tools/cli-docs`, Makefile, goreleaser, snap, CI) and README / CONTRIBUTING are updated. - **remove the urfave/cli command tree:** deletes `cmd/`, `modules/`, the old integration tests, contrib completion scripts and the generated `docs/CLI.md`, and drops their dependencies. This commit only deletes. ## Breaking changes This is a breaking release. It requires Gitea 28 or newer; configuration moves to separate `config.yml` and `hosts.yml` files and requires fresh authentication, and command names, aliases, flags and output formats change. `docs/migration-1.0.md` maps every old command, flag and environment variable to its replacement. ## Issues fixes #1118 fixes #1116 fixes #1115 fixes #1094 fixes #1091 fixes #1073 fixes #1052 fixes #1032 fixes #1023 fixes #966 fixes #908 fixes #833 fixes #831 fixes #817 fixes #804 fixes #779 fixes #770 fixes #737 fixes #697 fixes #726 fixes #677 fixes #672 fixes #633 fixes #632 fixes #560 fixes #556 fixes #523 fixes #516 fixes #510 fixes #504 fixes #500 fixes #482 fixes #406 fixes #403 fixes #373 fixes #351 fixes #344 fixes #326 fixes #325 fixes #323 fixes #246 fixes #240 fixes #232 fixes #197 fixes #172 fixes #141 fixes #69 fixes #1110 fixes #569 fixes #480 fixes #666 fixes #670 fixes #457 fixes #643 fixes #498 fixes #490 fixes #1069 fixes #834 fixes #602 fixes #328 fixes #417 fixes #571 fixes #1029 fixes #489 fixes #1050 fixes #162 fixes #430 fixes #1087 fixes #683 Reviewed-on: https://gitea.com/gitea/tea/pulls/1126 Reviewed-by: TheFox0x7 <95654+thefox0x7@noreply.gitea.com>
2026-10-26 19:11:25 +01:00 · 2026-10-11 17:23:06 +00:00
1 parent 12e415a7a7
commit f02245449b
@@ -1,143 +0,0 @@
-// Copyright 2026 The Gitea Authors. All rights reserved.
-// SPDX-License-Identifier: MIT
-
-package config
-
-import (
-	"context"
-	"crypto/ed25519"
-	"crypto/rand"
-	"crypto/x509"
-	"encoding/pem"
-	"net/http"
-	"net/http/httptest"
-	"os"
-	"path/filepath"
-	"sync/atomic"
-	"testing"
-	"time"
-
-	gitea "gitea.dev/sdk"
-	"golang.org/x/crypto/ssh"
-
-	"github.com/stretchr/testify/assert"
-	"github.com/stretchr/testify/require"
-)
-
-func TestLoginClientWithSSHPubkeyDoesNotDeadlockOnFirstRequest(t *testing.T) {
-	t.Parallel()
-
-	sshKeyPath, fingerprint := writeTestSSHKey(t)
-
-	var versionRequests atomic.Int32
-	var issueRequests atomic.Int32
-	var signedVersionRequests atomic.Int32
-	var signedIssueRequests atomic.Int32
-
-	server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
-		switch r.URL.Path {
-		case "/api/v1/version":
-			versionRequests.Add(1)
-			if r.Header.Get("Signature") != "" {
-				signedVersionRequests.Add(1)
-			}
-			w.Header().Set("Content-Type", "application/json")
-			_, _ = w.Write([]byte(`{"version":"1.26.4"}`))
-		case "/api/v1/repos/gitea/tea/issues":
-			issueRequests.Add(1)
-			if r.Header.Get("Signature") != "" {
-				signedIssueRequests.Add(1)
-			}
-			w.Header().Set("Content-Type", "application/json")
-			_, _ = w.Write([]byte(`[]`))
-		default:
-			t.Errorf("unexpected path %s", r.URL.Path)
-			w.WriteHeader(http.StatusNotFound)
-		}
-	}))
-	defer server.Close()
-
-	login := &Login{
-		Name:              "ssh-login",
-		URL:               server.URL,
-		SSHKey:            sshKeyPath,
-		SSHKeyFingerprint: fingerprint,
-		VersionCheck:      true,
-	}
-
-	type result struct {
-		issues []*gitea.Issue
-		err    error
-	}
-
-	done := make(chan result, 1)
-	go func() {
-		issues, _, err := login.Client().Issues.ListRepoIssues(context.Background(), "gitea", "tea", gitea.ListIssueOption{})
-		done <- result{issues: issues, err: err}
-	}()
-
-	select {
-	case res := <-done:
-		require.NoError(t, res.err)
-		assert.Empty(t, res.issues)
-	case <-time.After(2 * time.Second):
-		t.Fatal("ListRepoIssues deadlocked while bootstrapping the server version for SSH-signed requests")
-	}
-
-	assert.EqualValues(t, 1, versionRequests.Load())
-	assert.EqualValues(t, 0, signedVersionRequests.Load())
-	assert.EqualValues(t, 1, issueRequests.Load())
-	assert.EqualValues(t, 1, signedIssueRequests.Load())
-}
-
-func TestLoginSSHKeyPath(t *testing.T) {
-	t.Parallel()
-
-	tests := []struct {
-		name  string
-		login Login
-		want  string
-	}{
-		{
-			name:  "disk key",
-			login: Login{SSHKey: "/tmp/id_ed25519"},
-			want:  "/tmp/id_ed25519",
-		},
-		{
-			name:  "ssh agent ignores disk key",
-			login: Login{SSHKey: "/tmp/id_ed25519", SSHAgent: true},
-			want:  "",
-		},
-		{
-			name:  "ssh agent without disk key",
-			login: Login{SSHAgent: true},
-			want:  "",
-		},
-	}
-
-	for _, tt := range tests {
-		t.Run(tt.name, func(t *testing.T) {
-			t.Parallel()
-			assert.Equal(t, tt.want, tt.login.SSHKeyPath())
-		})
-	}
-}
-
-func writeTestSSHKey(t *testing.T) (string, string) {
-	t.Helper()
-
-	_, privateKey, err := ed25519.GenerateKey(rand.Reader)
-	require.NoError(t, err)
-
-	pkcs8, err := x509.MarshalPKCS8PrivateKey(privateKey)
-	require.NoError(t, err)
-
-	pemBytes := pem.EncodeToMemory(&pem.Block{Type: "PRIVATE KEY", Bytes: pkcs8})
-	sshKeyPath := filepath.Join(t.TempDir(), "id_ed25519")
-	require.NoError(t, os.WriteFile(sshKeyPath, pemBytes, 0o600))
-
-	signer, err := ssh.NewSignerFromKey(privateKey)
-	require.NoError(t, err)
-
-	return sshKeyPath, ssh.FingerprintSHA256(signer.PublicKey())
-}