feat!: rebuild tea on Cobra with explicit noun/verb commands (#1126)

- **switch tea to the Cobra command tree:** `internal/app` wires the packages from parts 1–4 into explicit noun/verb commands with `--repo`, `--json` / `--jq`, `--sudo` and `--debug`; `main.go` points at it. Build, release and docs tooling (`tools/cli-docs`, Makefile, goreleaser, snap, CI) and README / CONTRIBUTING are updated. - **remove the urfave/cli command tree:** deletes `cmd/`, `modules/`, the old integration tests, contrib completion scripts and the generated `docs/CLI.md`, and drops their dependencies. This commit only deletes. ## Breaking changes This is a breaking release. It requires Gitea 28 or newer; configuration moves to separate `config.yml` and `hosts.yml` files and requires fresh authentication, and command names, aliases, flags and output formats change. `docs/migration-1.0.md` maps every old command, flag and environment variable to its replacement. ## Issues fixes #1118 fixes #1116 fixes #1115 fixes #1094 fixes #1091 fixes #1073 fixes #1052 fixes #1032 fixes #1023 fixes #966 fixes #908 fixes #833 fixes #831 fixes #817 fixes #804 fixes #779 fixes #770 fixes #737 fixes #697 fixes #726 fixes #677 fixes #672 fixes #633 fixes #632 fixes #560 fixes #556 fixes #523 fixes #516 fixes #510 fixes #504 fixes #500 fixes #482 fixes #406 fixes #403 fixes #373 fixes #351 fixes #344 fixes #326 fixes #325 fixes #323 fixes #246 fixes #240 fixes #232 fixes #197 fixes #172 fixes #141 fixes #69 fixes #1110 fixes #569 fixes #480 fixes #666 fixes #670 fixes #457 fixes #643 fixes #498 fixes #490 fixes #1069 fixes #834 fixes #602 fixes #328 fixes #417 fixes #571 fixes #1029 fixes #489 fixes #1050 fixes #162 fixes #430 fixes #1087 fixes #683 Reviewed-on: https://gitea.com/gitea/tea/pulls/1126 Reviewed-by: TheFox0x7 <95654+thefox0x7@noreply.gitea.com>
2026-10-26 19:11:25 +01:00 · 2026-10-11 17:23:06 +00:00
1 parent 12e415a7a7
commit f02245449b
@@ -1,91 +0,0 @@
-// Copyright 2026 The Gitea Authors. All rights reserved.
-// SPDX-License-Identifier: MIT
-
-package httputil
-
-import (
-	"net"
-	"net/http"
-	"testing"
-	"time"
-)
-
-// TestWrapTransportTimeouts verifies the transport returned by WrapTransport
-// carries tea's standard timeout values, so a stalled server can't make tea
-// hang forever (issue #1018).
-func TestWrapTransportTimeouts(t *testing.T) {
-	rt := WrapTransport(nil)
-	uat, ok := rt.(*userAgentTransport)
-	if !ok {
-		t.Fatalf("WrapTransport returned %T, want *userAgentTransport", rt)
-	}
-	tr, ok := uat.base.(*http.Transport)
-	if !ok {
-		t.Fatalf("underlying base is %T, want *http.Transport", uat.base)
-	}
-	if tr.TLSHandshakeTimeout != TLSHandshakeTimeout {
-		t.Errorf("TLSHandshakeTimeout = %v, want %v", tr.TLSHandshakeTimeout, TLSHandshakeTimeout)
-	}
-	if tr.ResponseHeaderTimeout != ResponseHeaderTimeout {
-		t.Errorf("ResponseHeaderTimeout = %v, want %v", tr.ResponseHeaderTimeout, ResponseHeaderTimeout)
-	}
-	if tr.DialContext == nil {
-		t.Error("DialContext is nil, want a dialer with DialTimeout")
-	}
-}
-
-// newStallListener returns a listener that accepts connections, reads the
-// request, then goes silent without ever sending response headers — the
-// "server accepts the connection but never responds" case ResponseHeaderTimeout
-// guards against. The returned closer stops the listener.
-func newStallListener(t *testing.T) (addr string, closer func()) {
-	t.Helper()
-	ln, err := net.Listen("tcp", "127.0.0.1:0")
-	if err != nil {
-		t.Fatalf("listen: %v", err)
-	}
-	done := make(chan struct{})
-	go func() {
-		for {
-			conn, err := ln.Accept()
-			if err != nil {
-				return
-			}
-			go func(c net.Conn) {
-				buf := make([]byte, 4096)
-				_, _ = c.Read(buf) // drain the request, then never respond
-				<-done             // hold the connection open until the test ends
-				c.Close()
-			}(conn)
-		}
-	}()
-	return ln.Addr().String(), func() {
-		close(done)
-		ln.Close()
-	}
-}
-
-// TestResponseHeaderTimeoutFires proves a request to a server that accepts the
-// connection and request but never sends response headers aborts via
-// ResponseHeaderTimeout rather than hanging. It builds the transport the same
-// way WrapTransport does, with a short ResponseHeaderTimeout so the test is fast.
-func TestResponseHeaderTimeoutFires(t *testing.T) {
-	addr, closer := newStallListener(t)
-	defer closer()
-
-	tr := timeoutTransport(nil)
-	tr.ResponseHeaderTimeout = 2 * time.Second
-	client := &http.Client{Transport: &userAgentTransport{base: tr}}
-
-	start := time.Now()
-	_, err := client.Get("http://" + addr + "/")
-	elapsed := time.Since(start)
-
-	if err == nil {
-		t.Fatal("expected a timeout error from stalled server, got nil")
-	}
-	if elapsed > 10*time.Second {
-		t.Errorf("request took %v; ResponseHeaderTimeout did not fire", elapsed)
-	}
-	t.Logf("request failed as expected after %v: %v", elapsed, err)
-}