2bdd72dfff
Improve error messages ( #370 )
...
fixes #367
Co-authored-by: Norwin Roosen <git@nroo.de >
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com >
Reviewed-on: https://gitea.com/gitea/tea/pulls/370
Reviewed-by: 6543 <6543@obermui.de >
Reviewed-by: KN4CK3R <kn4ck3r@noreply.gitea.io >
Co-authored-by: Norwin <noerw@noreply.gitea.io >
Co-committed-by: Norwin <noerw@noreply.gitea.io >
2021-07-03 22:39:05 +08:00
3129e60a73
text editor selection: follow unix defacto standards ( #356 )
...
Currently, `tea` only supports the $EDITOR env var to open the user's preferred editor (used for reviewing pull requests).
Standard \*nix practice is, however, to check for $VISUAL first and only then use $EDITOR as fallback.
This is also done by Git itself, see man git-var(1).
(Actually, the order there is $GIT_EDITOR > core.editor > $VISUAL > $EDITOR > vi)
Co-authored-by: plgruener <pl.gruener@gmail.com >
Reviewed-on: https://gitea.com/gitea/tea/pulls/356
Reviewed-by: Norwin <noerw@noreply.gitea.io >
Reviewed-by: 6543 <6543@obermui.de >
Co-authored-by: plgruener <plgruener@noreply.gitea.io >
Co-committed-by: plgruener <plgruener@noreply.gitea.io >
2021-06-21 20:08:27 +08:00
3abc5a5b42
Allow checking out PRs with deleted head branch ( #341 )
...
..by explicitly fetching `refs/pulls/:idx/head` from the base repo.
Sorry, I mixed this with a split-up of `PullCheckout()`. I can try to separate that, if preferred
Co-authored-by: Norwin Roosen <git@nroo.de >
Co-authored-by: 6543 <6543@obermui.de >
Reviewed-on: https://gitea.com/gitea/tea/pulls/341
Reviewed-by: 6543 <6543@obermui.de >
Reviewed-by: Andrew Thornton <art27@cantab.net >
Co-authored-by: Norwin <noerw@noreply.gitea.io >
Co-committed-by: Norwin <noerw@noreply.gitea.io >
2021-03-12 02:16:02 +08:00
6f738df4a5
Add more issue / pr creation params ( #331 )
...
adds assignees, labels, deadline, milestone params
- [x] add flags to `tea issue create` (this is BREAKING, `-b` moved to `-d` for consistency with pr create)
- [x] add interactive mode to `tea issue create`
- [x] add flags to `tea pr create`
- [x] add interactive mode to `tea pr create`
fixes #171 , fixes #303
Co-authored-by: Norwin Roosen <git@nroo.de >
Co-authored-by: 6543 <6543@obermui.de >
Reviewed-on: https://gitea.com/gitea/tea/pulls/331
Reviewed-by: 6543 <6543@obermui.de >
Reviewed-by: Lunny Xiao <xiaolunwen@gmail.com >
Co-authored-by: Norwin <noerw@noreply.gitea.io >
Co-committed-by: Norwin <noerw@noreply.gitea.io >
2021-03-08 19:48:03 +08:00
d22b314701
Introduce workaround for missing pull head sha ( #340 )
...
fix #318
test with `tea pr 58`
Co-authored-by: Norwin Roosen <git@nroo.de >
Reviewed-on: https://gitea.com/gitea/tea/pulls/340
Reviewed-by: Norwin <noerw@noreply.gitea.io >
Reviewed-by: Andrew Thornton <art27@cantab.net >
Co-authored-by: 6543 <6543@obermui.de >
Co-committed-by: 6543 <6543@obermui.de >
2021-03-08 03:45:50 +08:00
d474883e90
don't push before creating a pull ( #334 )
...
Not sure if this is the best way, but it's the simplest way to fix #333 .
Everything else is overly complex due to a chicken-egg problem:
Knowing which remote / branch to push involves requires prompting the user,
which requires to have a upstream branch pushed to detect default values.
Co-authored-by: Norwin Roosen <git@nroo.de >
Reviewed-on: https://gitea.com/gitea/tea/pulls/334
Reviewed-by: 6543 <6543@obermui.de >
Reviewed-by: Andrew Thornton <art27@cantab.net >
Reviewed-by: khmarbaise <khmarbaise@noreply.gitea.io >
Co-authored-by: Norwin <noerw@noreply.gitea.io >
Co-committed-by: Norwin <noerw@noreply.gitea.io >
2021-03-05 18:27:09 +08:00
e96cfdbbe7
tea pr checkout
: dont create local branches (#314 )
...
This avoids creation of local branches, to avoid cluttering the local repo:
- if the commit already exists on the tip of a local branch, check that one out
- otherwise check out the remote tracking branch (`refs/remotes/<remote>/<head>`), and suggest what to do if you want to make changes.
I'm not certain this behaviour is actually better, I suggest leaving this open for a while for people to try out the new behaviour:
```
tea pr checkout 314
make install
```
fixes #293
Co-authored-by: Norwin Roosen <git@nroo.de >
Co-authored-by: 6543 <6543@obermui.de >
Reviewed-on: https://gitea.com/gitea/tea/pulls/314
Reviewed-by: 6543 <6543@obermui.de >
Reviewed-by: Lunny Xiao <xiaolunwen@gmail.com >
Co-authored-by: Norwin <noerw@noreply.gitea.io >
Co-committed-by: Norwin <noerw@noreply.gitea.io >
2021-03-02 21:50:11 +08:00
8bb5c15745
Add commands for reviews ( #315 )
...
add interactive `tea pr review`
it's amazingly simple
vendor gitea.com/noerw/unidiff-comments
add `tea pr lgtm|reject` shorthands
vendor slimmed down diff parser
review diff: default to true
if users want a shortcut, they can use lgtm or reject subcmds
`tea pr approve`: accept optional comment
Co-authored-by: Norwin Roosen <git@nroo.de >
Reviewed-on: https://gitea.com/gitea/tea/pulls/315
Reviewed-by: Lunny Xiao <xiaolunwen@gmail.com >
Reviewed-by: 6543 <6543@obermui.de >
Co-Authored-By: Norwin <noerw@noreply.gitea.io >
Co-Committed-By: Norwin <noerw@noreply.gitea.io >
2020-12-21 23:22:22 +08:00
43e9943757
Add interactive mode for tea milestone create
( #310 )
...
Implement interactive milestone creation
Return fmt.Errorf when title is empty
Incorporate deadline functionality
Use dateparse and cleanup CreateMilestone task
Signed-off-by: Martin Reboredo <yakoyoku@gmail.com >
Co-authored-by: Martin Reboredo <yakoyoku@gmail.com >
Reviewed-on: https://gitea.com/gitea/tea/pulls/310
Reviewed-by: Norwin <noerw@noreply.gitea.io >
Reviewed-by: 6543 <6543@obermui.de >
Co-Authored-By: Martin Reboredo <yakoyakoyokuyoku@noreply.gitea.io >
Co-Committed-By: Martin Reboredo <yakoyakoyokuyoku@noreply.gitea.io >
2020-12-18 02:50:07 +08:00
8b588f5313
make PR workflow helpers more robust ( #300 )
...
improve handling of remote deleted branches
split git.TeaDeleteBranch
only delete remote branch if we have permission
add missing err check
Co-authored-by: Norwin Roosen <git@nroo.de >
Reviewed-on: https://gitea.com/gitea/tea/pulls/300
Reviewed-by: 6543 <6543@obermui.de >
Reviewed-by: Lunny Xiao <xiaolunwen@gmail.com >
Co-Authored-By: Norwin <noerw@noreply.gitea.io >
Co-Committed-By: Norwin <noerw@noreply.gitea.io >
2020-12-17 22:00:16 +08:00
83b73ce78e
Show PR CI status ( #306 )
...
fix layout of pr reviews
show PR CI status
put conflict info in status list
remove line
show merged state
deduplicate reviews by user
Co-authored-by: Norwin Roosen <git@nroo.de >
Reviewed-on: https://gitea.com/gitea/tea/pulls/306
Reviewed-by: Lunny Xiao <xiaolunwen@gmail.com >
Reviewed-by: 6543 <6543@obermui.de >
Co-Authored-By: Norwin <noerw@noreply.gitea.io >
Co-Committed-By: Norwin <noerw@noreply.gitea.io >
2020-12-17 01:16:50 +08:00
a948fd7e10
Refactor error handling ( #308 )
...
use fmt instead of log
log.Fatal -> return err
set non-zero exit code on error
print to default err log
cleanup
fix vet
Co-authored-by: Norwin Roosen <git@nroo.de >
Co-authored-by: 6543 <6543@obermui.de >
Reviewed-on: https://gitea.com/gitea/tea/pulls/308
Reviewed-by: Lunny Xiao <xiaolunwen@gmail.com >
Reviewed-by: 6543 <6543@obermui.de >
Co-Authored-By: Norwin <noerw@noreply.gitea.io >
Co-Committed-By: Norwin <noerw@noreply.gitea.io >
2020-12-17 00:18:10 +08:00
b9f5ba0702
Add interactive mode for tea issue create
( #302 )
...
Implement interactive issue creation
Comment PromptRepoSlug
Move PromptRepoSlug to the right place
Hide promptRepoSlug
Signed-off-by: Martin Reboredo <yakoyoku@gmail.com >
Co-authored-by: Martin Reboredo <yakoyoku@gmail.com >
Reviewed-on: https://gitea.com/gitea/tea/pulls/302
Reviewed-by: Norwin <noerw@noreply.gitea.io >
Reviewed-by: khmarbaise <khmarbaise@noreply.gitea.io >
Reviewed-by: 6543 <6543@obermui.de >
Co-Authored-By: Martin Reboredo <yakoyakoyokuyoku@noreply.gitea.io >
Co-Committed-By: Martin Reboredo <yakoyakoyokuyoku@noreply.gitea.io >
2020-12-15 04:05:31 +08:00
c063329e9a
[Refactor] unexport config.Config var & move login tasks to task module ( #288 )
...
Unexport generateToken()
move CreateLogin into task
Create func config.SetDefaultLogin()
Unexport loadConfig() & saveConfig
unexport config var
make SetDefaultLogin() case insensitive
update func descriptions
move FindSSHKey to task module
Reviewed-on: https://gitea.com/gitea/tea/pulls/288
Reviewed-by: Norwin <noerw@noreply.gitea.io >
Reviewed-by: Andrew Thornton <art27@cantab.net >
Co-Authored-By: 6543 <6543@obermui.de >
Co-Committed-By: 6543 <6543@obermui.de >
2020-12-12 21:28:37 +08:00
0f38da068c
Improve ssh handling ( #277 )
...
checkout: use configured protocol for PR checkout
instead of defaulting to ssh if that is enabled
this might fix #262
login add: try to find a matching ssh key & store it in config
possibly expensive operation should be done once
pr checkout: don't fetch ssh keys
As a result, we don't try to pull via ssh, if no privkey was configured.
This increases chances of a using ssh only on a working ssh setup.
fix import order
remove debug print statement
improve ssh-key value docs
rm named return & fix pwCallback nil check
Co-authored-by: Norwin Roosen <git@nroo.de >
Co-authored-by: 6543 <6543@obermui.de >
Reviewed-on: https://gitea.com/gitea/tea/pulls/277
Reviewed-by: khmarbaise <khmarbaise@noreply.gitea.io >
Reviewed-by: Lunny Xiao <xiaolunwen@gmail.com >
Reviewed-by: 6543 <6543@obermui.de >
Co-Authored-By: Norwin <noerw@noreply.gitea.io >
Co-Committed-By: Norwin <noerw@noreply.gitea.io >
2020-12-11 21:42:41 +08:00
adb2382aa5
Add interactive mode for tea pr create
( #279 )
...
refactor pull create into task & interact module
avoid creation of invalid PRs
refactor task.CreatePull
to make functionality reusable in interact module
implement interactive.CreatePull
Co-authored-by: Norwin Roosen <git@nroo.de >
Reviewed-on: https://gitea.com/gitea/tea/pulls/279
Reviewed-by: 6543 <6543@obermui.de >
Reviewed-by: techknowlogick <techknowlogick@gitea.io >
Co-Authored-By: Norwin <noerw@noreply.gitea.io >
Co-Committed-By: Norwin <noerw@noreply.gitea.io >
2020-12-09 05:41:50 +08:00
c98441b13c
Remove Interact Dependency Of Task Module ( #280 )
...
remove interact dependency in task module
accept nil callback
format code
Reviewed-on: https://gitea.com/gitea/tea/pulls/280
Reviewed-by: Norwin <noerw@noreply.gitea.io >
Reviewed-by: Andrew Thornton <art27@cantab.net >
Co-Authored-By: 6543 <6543@obermui.de >
Co-Committed-By: 6543 <6543@obermui.de >
2020-12-08 19:25:21 +08:00
5cb3e1ded5
Refactor: Move list print functions into print package ( #273 )
...
MV list issues -> print.IssuesList
MV list labels -> print.LabelsList & task.LabelsExport
MV list logins -> print.LoginsList
MV list miles -> print.MilestonesList
MV list pulls -> print.PullsList
MV list releases -> print.ReleasesList
MV list issues&pulls of mile -> print.IssuesPullsList
MV list notification threads -> print.NotificationsList
Unexport print.outputList
Unexport print.outputMarkdown
remove comd/flags dependency in print module
Reviewed-on: https://gitea.com/gitea/tea/pulls/273
Reviewed-by: Lunny Xiao <xiaolunwen@gmail.com >
Reviewed-by: Andrew Thornton <art27@cantab.net >
Co-Authored-By: 6543 <6543@obermui.de >
Co-Committed-By: 6543 <6543@obermui.de >
2020-12-08 18:28:54 +08:00
d0e05e8be2
move git auth prompts to interact module ( #276 )
...
move password prompt to interact module
closes #231
allow up to 3 ssh key password attempts
rename param
Co-authored-by: Norwin Roosen <git@nroo.de >
Reviewed-on: https://gitea.com/gitea/tea/pulls/276
Reviewed-by: 6543 <6543@obermui.de >
Reviewed-by: Lunny Xiao <xiaolunwen@gmail.com >
Co-Authored-By: Norwin <noerw@noreply.gitea.io >
Co-Committed-By: Norwin <noerw@noreply.gitea.io >
2020-12-08 09:21:05 +08:00
9a3b54b9a3
use token auth for https remotes ( #275 )
...
use token for https auth instead of user name
also handle http urls
Co-authored-by: Norwin Roosen <git@nroo.de >
Reviewed-on: https://gitea.com/gitea/tea/pulls/275
Reviewed-by: Lunny Xiao <xiaolunwen@gmail.com >
Reviewed-by: 6543 <6543@obermui.de >
Co-Authored-By: Norwin <noerw@noreply.gitea.io >
Co-Committed-By: Norwin <noerw@noreply.gitea.io >
2020-12-07 22:14:56 +08:00
0cea700dd8
[Refactor] move pull checkout & clean code into task module ( #249 )
...
Merge branch 'master' into refactor_checkout2task
move pull clean code into task module
fix lint
format code
unify PullCheckout() and gitConfigForPR()
move pull checkout code into task module
Co-authored-by: 6543 <6543@noreply.gitea.io >
Reviewed-on: https://gitea.com/gitea/tea/pulls/249
Reviewed-by: Norwin <noerw@noreply.gitea.io >
Reviewed-by: Lunny Xiao <xiaolunwen@gmail.com >
Co-Authored-By: 6543 <6543@obermui.de >
Co-Committed-By: 6543 <6543@obermui.de >
2020-11-10 14:51:48 +08:00