mirror of
https://gitea.com/gitea/tea.git
synced 2026-10-26 11:01:25 +01:00
bircni
62962b4f70
Every confirmation defaulted to No, so Enter after a filled-in form canceled it; prompts were titled with raw flag names and aborted on an empty answer; and the shared issue and pull request form lost input: - Multi-selects hid their last option, so a single assignee looked like an empty list and labels showed four of five. They now get an explicit height and scroll past eight options. - A pty without a window size, such as `script` run without a terminal, made bubbles panic. Forms now refuse it with "terminal size unknown; pass the values as flags or use --no-input". - Without a configured editor, the form ran to the end and then failed with "configure an editor", discarding everything typed. The editor is now resolved before the form; without one the body is typed into an inline multi-line field. - The pull request form said "Issue title" and "Issue description". The shared fields read "Title (required):" and "Body (markdown):", and the review body label gained its missing space. New prompt API for the area commands: confirmAction with a terminal.Confirmation (DefaultYes for constructive actions, Typed for type-to-confirm, NonTTY to name the action in the --yes error) and requireInput with a human label and inline validation. Declined or aborted prompts return terminal.ErrCanceled (exit code 3). The existing confirm and require helpers keep working on top of them, and prompters without the new terminal.Asker methods keep the plain behavior. Signed-off-by: bircni <bircni@icloud.com>
76 lines
2.6 KiB
Go
76 lines
2.6 KiB
Go
// Copyright 2026 The Gitea Authors. All rights reserved.
|
|
// SPDX-License-Identifier: MIT
|
|
|
|
package app
|
|
|
|
import (
|
|
"context"
|
|
"testing"
|
|
|
|
"gitea.dev/tea/internal/clierr"
|
|
"gitea.dev/tea/internal/terminal"
|
|
"github.com/stretchr/testify/require"
|
|
)
|
|
|
|
// askingPrompter is scriptedPrompter with the terminal.Asker extension that FormPrompter has.
|
|
type askingPrompter struct {
|
|
scriptedPrompter
|
|
texts []string
|
|
defaults []bool
|
|
}
|
|
|
|
func (p *askingPrompter) Ask(ctx context.Context, title string, _ func(string) error) (string, error) {
|
|
return p.Input(ctx, title)
|
|
}
|
|
|
|
func (p *askingPrompter) AskText(_ context.Context, title, initial string) (string, error) {
|
|
p.texts = append(p.texts, title+" "+initial)
|
|
return "typed body", nil
|
|
}
|
|
|
|
func (p *askingPrompter) ConfirmDefault(ctx context.Context, title string, defaultYes bool) (bool, error) {
|
|
p.defaults = append(p.defaults, defaultYes)
|
|
return p.Confirm(ctx, title)
|
|
}
|
|
|
|
func TestConfirmActionFollowsThePromptPolicy(t *testing.T) {
|
|
c := terminal.Confirmation{Prompt: `Delete label "bug" from alice/x?`, NonTTY: `delete label "bug" from alice/x`}
|
|
deps, _, _ := testDeps(t)
|
|
a, cmd := outputApplication(deps, "")
|
|
err := a.confirmAction(cmd, c)
|
|
require.Equal(t, clierr.Usage, clierr.ExitCode(err))
|
|
require.EqualError(t, err, `confirmation required to delete label "bug" from alice/x; rerun with --yes`)
|
|
a.options.yes = true
|
|
require.NoError(t, a.confirmAction(cmd, c))
|
|
|
|
prompt := &askingPrompter{}
|
|
deps.Prompter = prompt
|
|
deps.Streams.InTTY, deps.Streams.ErrTTY = true, true
|
|
a, cmd = outputApplication(deps, "")
|
|
err = a.confirmAction(cmd, c)
|
|
require.ErrorIs(t, err, terminal.ErrCanceled)
|
|
require.Equal(t, clierr.Canceled, clierr.ExitCode(err))
|
|
prompt.accept = true
|
|
require.NoError(t, a.confirmAction(cmd, terminal.Confirmation{Prompt: "Create pull request?", DefaultYes: true}))
|
|
require.Equal(t, []string{c.Prompt, "Create pull request?"}, prompt.confirmations)
|
|
require.Equal(t, []bool{false, true}, prompt.defaults)
|
|
}
|
|
|
|
func TestRequireInputPromptsWithTheLabel(t *testing.T) {
|
|
prompt := &scriptedPrompter{input: "bug"}
|
|
deps, _, _ := testDeps(t)
|
|
deps.Prompter = prompt
|
|
a, cmd := outputApplication(deps, "")
|
|
name := ""
|
|
_, err := a.requireInput(cmd, &name, "name", "Label name", nil)
|
|
require.EqualError(t, err, "missing required input: supply --name")
|
|
|
|
deps.Streams.InTTY, deps.Streams.ErrTTY = true, true
|
|
a, cmd = outputApplication(deps, "")
|
|
asked, err := a.requireInput(cmd, &name, "name", "Label name", nil)
|
|
require.NoError(t, err)
|
|
require.True(t, asked)
|
|
require.Equal(t, "bug", name)
|
|
require.Equal(t, []string{"Label name"}, prompt.asked)
|
|
}
|