Files
gitea-tea/internal/services/action_values_test.go
T
bircni 83924892ff refactor: reuse the existing service and rendering helpers
services.IsNotFound replaces the hand-rolled 404 checks, convertPage
the copied page conversions and lastPathNumber the comment's own
number parser. The List wrappers around ListPage of releases,
branches, wiki pages, secrets and variables go, pull request filters
resolve milestones through Milestones.FindOne like issues, and
localFlagsChanged, boolOrder, Cell.Render, stateBadge and dueText
replace their copies.

Signed-off-by: bircni <bircni@icloud.com>
2026-10-12 11:22:52 +02:00

142 lines
5.6 KiB
Go

// Copyright 2026 The Gitea Authors. All rights reserved.
// SPDX-License-Identifier: MIT
package services
import (
"context"
"encoding/json"
"fmt"
"net/http"
"testing"
"gitea.dev/tea/internal/transport"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
)
var actionValueScopes = []struct {
name string
scope ActionScope
path string
}{
{"repository", ActionScope{Repository: "alice/project"}, "/api/v1/repos/alice/project/actions"},
{"organization", ActionScope{Organization: "team"}, "/api/v1/orgs/team/actions"},
{"account", ActionScope{Account: true}, "/api/v1/user/actions"},
}
func TestVariableSetSelectsCreateOrUpdate(t *testing.T) {
for _, scope := range actionValueScopes {
for _, test := range []struct {
read int
wantMethod string
}{{http.StatusOK, http.MethodPut}, {http.StatusNotFound, http.MethodPost}, {http.StatusForbidden, ""}} {
t.Run(fmt.Sprintf("%s/%d", scope.name, test.read), func(t *testing.T) {
var mutations []string
client := newTestClient(t, http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
assert.Equal(t, scope.path+"/variables/BUILD_MODE", r.URL.Path)
if r.Method == http.MethodGet {
w.WriteHeader(test.read)
_, _ = w.Write([]byte(`{"name":"BUILD_MODE","data":"old"}`))
return
}
mutations = append(mutations, r.Method)
var payload map[string]string
assert.NoError(t, json.NewDecoder(r.Body).Decode(&payload))
assert.Equal(t, "new\nvalue", payload["value"])
assert.Equal(t, "build flavor", payload["description"])
w.WriteHeader(http.StatusNoContent)
}))
item, err := (ActionVariables{Client: client, Scope: scope.scope}).Set(context.Background(), "BUILD_MODE", "new\nvalue", "build flavor")
if test.wantMethod == "" {
var apiErr *transport.APIError
require.ErrorAs(t, err, &apiErr)
require.Equal(t, http.StatusForbidden, apiErr.Status)
require.Empty(t, mutations, "a failed read must not mutate")
return
}
require.NoError(t, err)
require.Equal(t, []string{test.wantMethod}, mutations)
require.Equal(t, ActionVariable{Name: "BUILD_MODE", Value: "new\nvalue", Description: "build flavor"}, item)
})
}
}
}
func TestVariableReadsAndDeletesUseTheirScope(t *testing.T) {
for _, scope := range actionValueScopes {
t.Run(scope.name, func(t *testing.T) {
var requests []string
client := newTestClient(t, http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
requests = append(requests, r.Method+" "+r.URL.Path)
switch {
case r.Method == http.MethodDelete:
w.WriteHeader(http.StatusNoContent)
case r.URL.Path == scope.path+"/variables":
assert.Equal(t, "20", r.URL.Query().Get("limit"))
assert.Equal(t, "2", r.URL.Query().Get("page"))
_, _ = w.Write([]byte(`[{"name":"MODE","data":"test","description":"build mode","owner_id":1}]`))
default:
_, _ = w.Write([]byte(`{"name":"MODE","data":"test","description":"build mode"}`))
}
}))
service := ActionVariables{Client: client, Scope: scope.scope}
want := ActionVariable{Name: "MODE", Value: "test", Description: "build mode"}
items, err := service.ListPage(context.Background(), 20, 2)
require.NoError(t, err)
require.Equal(t, []ActionVariable{want}, items.Items)
item, err := service.View(context.Background(), "MODE")
require.NoError(t, err)
require.Equal(t, want, item)
require.NoError(t, service.Delete(context.Background(), "MODE"))
require.Equal(t, []string{
"GET " + scope.path + "/variables", "GET " + scope.path + "/variables/MODE", "DELETE " + scope.path + "/variables/MODE",
}, requests)
})
}
}
func TestSecretMutationsUseTheirScope(t *testing.T) {
for _, scope := range actionValueScopes {
t.Run(scope.name, func(t *testing.T) {
var requests []string
client := newTestClient(t, http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
requests = append(requests, r.Method+" "+r.URL.EscapedPath())
if r.Method == http.MethodPut {
var payload map[string]string
assert.NoError(t, json.NewDecoder(r.Body).Decode(&payload))
assert.Equal(t, map[string]string{"data": "secret", "description": "deploy key"}, payload)
}
w.WriteHeader(http.StatusNoContent)
}))
service := ActionSecrets{Client: client, Scope: scope.scope}
item, err := service.Set(context.Background(), "TOKEN", "secret", "deploy key")
require.NoError(t, err)
require.Equal(t, ActionSecret{Name: "TOKEN", Description: "deploy key"}, item)
require.NoError(t, service.Delete(context.Background(), "A B"))
require.Equal(t, []string{"PUT " + scope.path + "/secrets/TOKEN", "DELETE " + scope.path + "/secrets/A%20B"}, requests)
})
}
}
func TestSecretListReturnsMetadataOnly(t *testing.T) {
for _, scope := range actionValueScopes {
t.Run(scope.name, func(t *testing.T) {
client := newTestClient(t, http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
assert.Equal(t, scope.path+"/secrets", r.URL.Path)
assert.Equal(t, "20", r.URL.Query().Get("limit"))
assert.Equal(t, "2", r.URL.Query().Get("page"))
_, _ = w.Write([]byte(`[{"name":"TOKEN","data":"never-display","description":"deploy","created_at":"2028-01-02T03:04:05Z"},{"name":"OTHER"}]`))
}))
items, err := (ActionSecrets{Client: client, Scope: scope.scope}).ListPage(context.Background(), 20, 2)
if scope.scope.Account {
var unsupported *CapabilityError
require.ErrorAs(t, err, &unsupported)
return
}
require.NoError(t, err)
require.Equal(t, []ActionSecret{{Name: "TOKEN", Description: "deploy", CreatedAt: "2028-01-02T03:04:05Z"}, {Name: "OTHER"}}, items.Items)
})
}
}