Files
gitea-tea/internal/app/labelfile_test.go
T
bircni 0d013746b5 fix(label): refuse duplicate label names unless --force
tea label create --name bug twice created a second "bug" label, after
which issue edit --add-labels bug failed as ambiguous and issue list
--label bug matched nothing. label create (and --file imports) now fail
with "label "bug" already exists in alice/project; pass --force to
update it", ignoring case; --force updates the existing label. The
ambiguity error for labels that already share a name lists their IDs.

Signed-off-by: bircni <bircni@icloud.com>
2026-10-12 00:14:30 +02:00

75 lines
2.6 KiB
Go

// Copyright 2026 The Gitea Authors. All rights reserved.
// SPDX-License-Identifier: MIT
package app
import (
"context"
"encoding/json"
"fmt"
"io"
"net/http"
"os"
"path/filepath"
"strings"
"testing"
"gitea.dev/tea/internal/services"
"github.com/stretchr/testify/require"
)
func TestLabelFileRoundTrip(t *testing.T) {
for _, label := range []services.Label{
{Name: "bug", Color: "ff0000", Description: "Something is broken"},
{Name: "kind/feature request", Color: "#00FF00", Description: "Wanted; maybe"},
{Name: "#hash", Color: "0000ff"},
} {
row, err := formatLabel(label)
require.NoError(t, err, label.Name)
parsed, err := parseLabelFile(strings.NewReader(row))
require.NoError(t, err, row)
require.Len(t, parsed, 1)
require.Equal(t, label.Name, *parsed[0].Name)
require.Equal(t, strings.TrimPrefix(label.Color, "#"), *parsed[0].Color)
require.Equal(t, label.Description, *parsed[0].Description)
}
for _, label := range []services.Label{
{Name: "", Color: "ff0000"},
{Name: "two spaces", Color: "ff0000"},
{Name: "semi;colon", Color: "ff0000"},
{Name: "tab\tname", Color: "ff0000"},
{Name: "bug", Color: "red"},
{Name: "bug", Color: "ff0000", Description: "line\nbreak"},
{Name: "bug", Color: "ff0000", Description: " padded"},
} {
_, err := formatLabel(label)
require.ErrorContains(t, err, "cannot be represented", label)
}
}
func TestLabelImportAcceptsColorPrefixedRows(t *testing.T) {
var created []string
server := newAuthenticatedServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
require.Equal(t, "/api/v1/repos/alice/project/labels", r.URL.Path)
if r.Method == http.MethodGet {
_, _ = w.Write([]byte(`[]`))
return
}
payload, err := io.ReadAll(r.Body)
require.NoError(t, err)
var label struct{ Name string }
require.NoError(t, json.Unmarshal(payload, &label))
created = append(created, string(payload))
_, _ = fmt.Fprintf(w, `{"id":%d,"name":%q}`, len(created), label.Name)
}))
defer server.Close()
deps, out, _ := serverDeps(t, server.URL)
file := filepath.Join(t.TempDir(), "labels.txt")
require.NoError(t, os.WriteFile(file, []byte("# Gitea default labels\n#ee0701 bug ; Something is not working\n84b6eb enhancement\n"), 0o600))
require.NoError(t, Execute(context.Background(), deps, []string{"label", "create", "-R", "alice/project", "--file", file, "--yes"}))
require.Len(t, created, 2)
requirePayload(t, `{"name":"bug","color":"ee0701","description":"Something is not working"}`, strings.NewReader(created[0]))
requirePayload(t, `{"name":"enhancement","color":"84b6eb"}`, strings.NewReader(created[1]))
require.Equal(t, "1\tbug\t\t\n2\tenhancement\t\t\n", out.String())
}