Files
gitea-tea/internal/app/release_assets.go
T
bircni f02245449b feat!: rebuild tea on Cobra with explicit noun/verb commands (#1126)
- **switch tea to the Cobra command tree:** `internal/app` wires the packages from parts 1–4 into explicit noun/verb commands with `--repo`, `--json` / `--jq`, `--sudo` and `--debug`; `main.go` points at it. Build, release and docs tooling (`tools/cli-docs`, Makefile, goreleaser, snap, CI) and README / CONTRIBUTING are updated.
- **remove the urfave/cli command tree:** deletes `cmd/`, `modules/`, the old integration tests, contrib completion scripts and the generated `docs/CLI.md`, and drops their dependencies. This commit only deletes.

## Breaking changes

This is a breaking release. It requires Gitea 28 or newer; configuration moves to separate `config.yml` and `hosts.yml` files and requires fresh authentication, and command names, aliases, flags and output formats change. `docs/migration-1.0.md` maps every old command, flag and environment variable to its replacement.

## Issues

fixes #1118
fixes #1116
fixes #1115
fixes #1094
fixes #1091
fixes #1073
fixes #1052
fixes #1032
fixes #1023
fixes #966
fixes #908
fixes #833
fixes #831
fixes #817
fixes #804
fixes #779
fixes #770
fixes #737
fixes #697
fixes #726
fixes #677
fixes #672
fixes #633
fixes #632
fixes #560
fixes #556
fixes #523
fixes #516
fixes #510
fixes #504
fixes #500
fixes #482
fixes #406
fixes #403
fixes #373
fixes #351
fixes #344
fixes #326
fixes #325
fixes #323
fixes #246
fixes #240
fixes #232
fixes #197
fixes #172
fixes #141
fixes #69
fixes #1110
fixes #569
fixes #480
fixes #666
fixes #670
fixes #457
fixes #643
fixes #498
fixes #490
fixes #1069
fixes #834
fixes #602
fixes #328
fixes #417
fixes #571
fixes #1029
fixes #489
fixes #1050
fixes #162
fixes #430
fixes #1087
fixes #683

Reviewed-on: https://gitea.com/gitea/tea/pulls/1126
Reviewed-by: TheFox0x7 <95654+thefox0x7@noreply.gitea.com>
2026-10-11 17:23:06 +00:00

188 lines
6.0 KiB
Go

// Copyright 2026 The Gitea Authors. All rights reserved.
// SPDX-License-Identifier: MIT
package app
import (
"errors"
"fmt"
"os"
"path/filepath"
"slices"
"strconv"
"strings"
"gitea.dev/tea/internal/clierr"
"gitea.dev/tea/internal/services"
"gitea.dev/tea/internal/terminal"
"github.com/spf13/cobra"
)
func (a *application) releaseAssetCommand() *cobra.Command {
group := &cobra.Command{Use: "asset", Short: "Manage release assets"}
var limit, page int
list := &cobra.Command{Use: "list <tag>", Short: "List release assets", Args: argsExact(1), RunE: func(cmd *cobra.Command, args []string) error {
target, err := a.resolve(cmd.Context(), true)
if err != nil {
return err
}
service := services.Releases{Client: target.client, Repository: target.Repo}
release, err := service.View(cmd.Context(), args[0])
if err != nil {
return err
}
items, err := service.Assets(cmd.Context(), release.ID, limit, page)
if err != nil {
return err
}
return writeList(a, cmd, items, assetRow)
}}
pageFlags(list, &limit, &page)
group.AddCommand(list)
var name string
upload := &cobra.Command{Use: "upload <tag> <file>...", Short: "Upload release assets", Args: usageArgs(cobra.MinimumNArgs(2)), RunE: func(cmd *cobra.Command, args []string) error {
if cmd.Flags().Changed("name") && (len(args) != 2 || strings.TrimSpace(name) == "") {
return clierr.Wrap(clierr.Usage, errors.New("--name requires exactly one file and a nonempty name"))
}
files, err := openRegularFiles(args[1:])
defer closeFiles(files)
if err != nil {
return err
}
target, err := a.resolve(cmd.Context(), true)
if err != nil {
return err
}
service := services.Releases{Client: target.client, Repository: target.Repo}
release, err := service.View(cmd.Context(), args[0])
if err != nil {
return err
}
filename := func(file *os.File) string {
if cmd.Flags().Changed("name") {
return name
}
return filepath.Base(file.Name())
}
return batch(a, cmd, files, func(file *os.File) string { return "upload asset " + filename(file) }, func(file *os.File) (services.ReleaseAsset, error) {
return service.UploadAsset(cmd.Context(), release.ID, filename(file), file)
}, assetRow)
}}
upload.Flags().StringVar(&name, "name", "", "Uploaded asset name (defaults to filename)")
group.AddCommand(upload)
for _, verb := range []string{"edit", "delete"} {
var newName string
var byName bool
command := &cobra.Command{Use: verb + " <tag> <asset-id>", Short: titleCase(verb) + " release assets", Args: argsExact(2)}
if verb == "delete" {
command.Use = "delete <tag> <asset-id>..."
command.Args = usageArgs(cobra.MinimumNArgs(2))
command.Flags().BoolVar(&byName, "by-name", false, "Select assets by exact name instead of ID")
command.Annotations = textOutput("asset deletion does not return a resource")
}
command.RunE = func(cmd *cobra.Command, args []string) error {
if verb == "edit" && strings.TrimSpace(newName) == "" {
return clierr.Wrap(clierr.Usage, errors.New("supply --name for asset rename"))
}
var ids []int64
if !byName {
var err error
if ids, err = resourceNumbers(args[1:]); err != nil {
return err
}
}
target, err := a.resolve(cmd.Context(), true)
if err != nil {
return err
}
service := services.Releases{Client: target.client, Repository: target.Repo}
release, err := service.View(cmd.Context(), args[0])
if err != nil {
return err
}
if verb == "edit" {
item, err := service.RenameAsset(cmd.Context(), release.ID, ids[0], newName)
if err != nil {
return err
}
return writeItem(a, cmd, item, assetRow)
}
if byName {
assets, err := service.AllAssets(cmd.Context(), release.ID)
if err != nil {
return err
}
for _, name := range args[1:] {
var matches []int64
for _, asset := range assets {
if asset.Name == name {
matches = append(matches, asset.ID)
}
}
if len(matches) != 1 {
return clierr.Wrap(clierr.Usage, fmt.Errorf("asset name %q matches %d assets; use an explicit asset ID", name, len(matches)))
}
if slices.Contains(ids, matches[0]) {
return clierr.Wrap(clierr.Usage, errors.New("duplicate asset selections"))
}
ids = append(ids, matches[0])
}
}
if err := a.confirm(cmd, "Delete release assets "+strings.Join(args[1:], ", ")+" on "+target.Repo); err != nil {
return err
}
var failures []error
for _, id := range ids {
if err := service.DeleteAsset(cmd.Context(), release.ID, id); err != nil {
failures = append(failures, fmt.Errorf("delete asset %d: %w", id, err))
continue
}
if len(ids) > 1 {
if _, err := fmt.Fprintf(cmd.ErrOrStderr(), "Deleted asset %d\n", id); err != nil {
return err
}
}
}
return errors.Join(failures...)
}
if verb == "edit" {
command.Flags().StringVar(&newName, "name", "", "New asset name")
}
group.AddCommand(command)
}
var output string
download := &cobra.Command{Use: "download <tag> <asset-id>", Short: "Download an asset to a file or stdout", Annotations: textOutput("asset downloads are binary"), Args: argsExact(2), RunE: func(cmd *cobra.Command, args []string) error {
id, err := number(args[1])
if err != nil {
return err
}
if err := validateDownloadDestination(output); err != nil {
return err
}
target, err := a.resolve(cmd.Context(), true)
if err != nil {
return err
}
service := services.Releases{Client: target.client, Repository: target.Repo}
release, err := service.View(cmd.Context(), args[0])
if err != nil {
return err
}
body, err := service.DownloadAsset(cmd.Context(), release.ID, id)
if err != nil {
return err
}
defer body.Close()
return writeDownload(cmd, body, output)
}}
download.Flags().StringVar(&output, "output-file", "", "Destination file (must not exist), or - for stdout")
group.AddCommand(download)
return group
}
func assetRow(item services.ReleaseAsset) []terminal.Cell {
return terminal.Row(strconv.FormatInt(item.ID, 10), item.Name, strconv.FormatInt(item.Size, 10), item.URL)
}