mirror of
https://gitea.com/gitea/tea.git
synced 2024-12-01 14:56:54 +01:00
d5058b3b20
update go min version Update Vendors: * code.gitea.io/gitea-vet v0.2.0 -> v0.2.1 * code.gitea.io/sdk/gitea v0.13.0 -> v0.13.1 * github.com/AlecAivazis/survey v2.1.1 -> v2.2.2 * github.com/adrg/xdg v0.2.1 -> v0.2.2 * github.com/araddon/dateparse d820a6159ab1 -> 8aadafed4dc4 * github.com/go-git/go-git v5.1.0 -> v5.2.0 * github.com/muesli/termenv v0.7.2 -> v0.7.4 * github.com/stretchr/testify v1.5.1 -> v1.6.1 * github.com/urfave/cli v2.2.0 -> v2.3.0 Co-authored-by: 6543 <6543@obermui.de> Reviewed-on: https://gitea.com/gitea/tea/pulls/250 Reviewed-by: Andrew Thornton <art27@cantab.net> Reviewed-by: mrsdizzie <info@mrsdizzie.com> Co-Authored-By: 6543 <6543@noreply.gitea.io> Co-Committed-By: 6543 <6543@noreply.gitea.io>
127 lines
2.7 KiB
Go
127 lines
2.7 KiB
Go
package analysis
|
|
|
|
import (
|
|
"fmt"
|
|
"reflect"
|
|
"strings"
|
|
"unicode"
|
|
)
|
|
|
|
// Validate reports an error if any of the analyzers are misconfigured.
|
|
// Checks include:
|
|
// that the name is a valid identifier;
|
|
// that the Requires graph is acyclic;
|
|
// that analyzer fact types are unique;
|
|
// that each fact type is a pointer.
|
|
func Validate(analyzers []*Analyzer) error {
|
|
// Map each fact type to its sole generating analyzer.
|
|
factTypes := make(map[reflect.Type]*Analyzer)
|
|
|
|
// Traverse the Requires graph, depth first.
|
|
const (
|
|
white = iota
|
|
grey
|
|
black
|
|
finished
|
|
)
|
|
color := make(map[*Analyzer]uint8)
|
|
var visit func(a *Analyzer) error
|
|
visit = func(a *Analyzer) error {
|
|
if a == nil {
|
|
return fmt.Errorf("nil *Analyzer")
|
|
}
|
|
if color[a] == white {
|
|
color[a] = grey
|
|
|
|
// names
|
|
if !validIdent(a.Name) {
|
|
return fmt.Errorf("invalid analyzer name %q", a)
|
|
}
|
|
|
|
if a.Doc == "" {
|
|
return fmt.Errorf("analyzer %q is undocumented", a)
|
|
}
|
|
|
|
// fact types
|
|
for _, f := range a.FactTypes {
|
|
if f == nil {
|
|
return fmt.Errorf("analyzer %s has nil FactType", a)
|
|
}
|
|
t := reflect.TypeOf(f)
|
|
if prev := factTypes[t]; prev != nil {
|
|
return fmt.Errorf("fact type %s registered by two analyzers: %v, %v",
|
|
t, a, prev)
|
|
}
|
|
if t.Kind() != reflect.Ptr {
|
|
return fmt.Errorf("%s: fact type %s is not a pointer", a, t)
|
|
}
|
|
factTypes[t] = a
|
|
}
|
|
|
|
// recursion
|
|
for _, req := range a.Requires {
|
|
if err := visit(req); err != nil {
|
|
return err
|
|
}
|
|
}
|
|
color[a] = black
|
|
}
|
|
|
|
if color[a] == grey {
|
|
stack := []*Analyzer{a}
|
|
inCycle := map[string]bool{}
|
|
for len(stack) > 0 {
|
|
current := stack[len(stack)-1]
|
|
stack = stack[:len(stack)-1]
|
|
if color[current] == grey && !inCycle[current.Name] {
|
|
inCycle[current.Name] = true
|
|
stack = append(stack, current.Requires...)
|
|
}
|
|
}
|
|
return &CycleInRequiresGraphError{AnalyzerNames: inCycle}
|
|
}
|
|
|
|
return nil
|
|
}
|
|
for _, a := range analyzers {
|
|
if err := visit(a); err != nil {
|
|
return err
|
|
}
|
|
}
|
|
|
|
// Reject duplicates among analyzers.
|
|
// Precondition: color[a] == black.
|
|
// Postcondition: color[a] == finished.
|
|
for _, a := range analyzers {
|
|
if color[a] == finished {
|
|
return fmt.Errorf("duplicate analyzer: %s", a.Name)
|
|
}
|
|
color[a] = finished
|
|
}
|
|
|
|
return nil
|
|
}
|
|
|
|
func validIdent(name string) bool {
|
|
for i, r := range name {
|
|
if !(r == '_' || unicode.IsLetter(r) || i > 0 && unicode.IsDigit(r)) {
|
|
return false
|
|
}
|
|
}
|
|
return name != ""
|
|
}
|
|
|
|
type CycleInRequiresGraphError struct {
|
|
AnalyzerNames map[string]bool
|
|
}
|
|
|
|
func (e *CycleInRequiresGraphError) Error() string {
|
|
var b strings.Builder
|
|
b.WriteString("cycle detected involving the following analyzers:")
|
|
for n := range e.AnalyzerNames {
|
|
b.WriteByte(' ')
|
|
b.WriteString(n)
|
|
}
|
|
return b.String()
|
|
}
|