mirror of
https://gitea.com/gitea/tea.git
synced 2026-04-25 17:53:37 +02:00
## Summary \`Page: -1\` in the Gitea SDK calls \`setDefaults()\` which sets both \`Page=0\` and \`PageSize=0\`, resulting in \`?page=0&limit=0\` being sent to the server. The server interprets \`limit=0\` as "use server default" (typically 30 items via \`DEFAULT_PAGING_NUM\`), not "return everything". Any resource beyond the first page of results was silently invisible. This affected 8 call sites, with the most user-visible impact being \`tea issues edit --add-labels\` and \`tea pulls edit --add-labels\` silently failing to apply labels on repositories with more than ~30 labels. ## Affected call sites | File | API call | User-visible impact | |---|---|---| | \`modules/task/labels.go\` | \`ListRepoLabels\` | \`issues/pulls edit --add-labels\` fails silently | | \`modules/interact/issue_create.go\` | \`ListRepoLabels\` | interactive label picker missing labels | | \`modules/task/pull_review_comment.go\` | \`ListPullReviews\` | review comments truncated | | \`modules/task/login_ssh.go\` | \`ListMyPublicKeys\` | SSH key auto-detection fails | | \`modules/task/login_create.go\` | \`ListAccessTokens\` | token name deduplication misses existing tokens | | \`cmd/pulls.go\` | \`ListPullReviews\` | PR detail view missing reviews | | \`cmd/releases/utils.go\` | \`ListReleases\` | tag lookup fails on repos with many releases | | \`cmd/attachments/delete.go\` | \`ListReleaseAttachments\` | attachment deletion fails when many attachments exist | ## Fix Each call site is replaced with an explicit pagination loop that follows \`resp.NextPage\` until all pages are exhausted. Reviewed-on: https://gitea.com/gitea/tea/pulls/967 Reviewed-by: Lunny Xiao <xiaolunwen@gmail.com> Co-authored-by: Alain Thiffault <athiffau@effectivemomentum.com> Co-committed-by: Alain Thiffault <athiffau@effectivemomentum.com>
98 lines
2.4 KiB
Go
98 lines
2.4 KiB
Go
// Copyright 2024 The Gitea Authors. All rights reserved.
|
|
// SPDX-License-Identifier: MIT
|
|
|
|
package attachments
|
|
|
|
import (
|
|
stdctx "context"
|
|
"fmt"
|
|
|
|
"code.gitea.io/tea/cmd/flags"
|
|
"code.gitea.io/tea/cmd/releases"
|
|
"code.gitea.io/tea/modules/context"
|
|
|
|
"code.gitea.io/sdk/gitea"
|
|
"github.com/urfave/cli/v3"
|
|
)
|
|
|
|
// CmdReleaseAttachmentDelete represents a sub command of Release Attachments to delete a release attachment
|
|
var CmdReleaseAttachmentDelete = cli.Command{
|
|
Name: "delete",
|
|
Aliases: []string{"rm"},
|
|
Usage: "Delete one or more release attachments",
|
|
Description: `Delete one or more release attachments`,
|
|
ArgsUsage: "<release tag> <attachment name> [<attachment name>...]",
|
|
Action: runReleaseAttachmentDelete,
|
|
Flags: append([]cli.Flag{
|
|
&cli.BoolFlag{
|
|
Name: "confirm",
|
|
Aliases: []string{"y"},
|
|
Usage: "Confirm deletion (required)",
|
|
},
|
|
}, flags.AllDefaultFlags...),
|
|
}
|
|
|
|
func runReleaseAttachmentDelete(_ stdctx.Context, cmd *cli.Command) error {
|
|
ctx, err := context.InitCommand(cmd)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
if err := ctx.Ensure(context.CtxRequirement{RemoteRepo: true}); err != nil {
|
|
return err
|
|
}
|
|
client := ctx.Login.Client()
|
|
|
|
if ctx.Args().Len() < 2 {
|
|
return fmt.Errorf("no release tag or attachment names specified.\nUsage:\t%s", ctx.Command.UsageText)
|
|
}
|
|
|
|
tag := ctx.Args().First()
|
|
if len(tag) == 0 {
|
|
return fmt.Errorf("release tag needed to delete attachment")
|
|
}
|
|
|
|
if !ctx.Bool("confirm") {
|
|
fmt.Println("Are you sure? Please confirm with -y or --confirm.")
|
|
return nil
|
|
}
|
|
|
|
release, err := releases.GetReleaseByTag(ctx.Owner, ctx.Repo, tag, client)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
var existing []*gitea.Attachment
|
|
for page := 1; ; {
|
|
page_attachments, resp, err := client.ListReleaseAttachments(ctx.Owner, ctx.Repo, release.ID, gitea.ListReleaseAttachmentsOptions{
|
|
ListOptions: gitea.ListOptions{Page: page, PageSize: 50},
|
|
})
|
|
if err != nil {
|
|
return err
|
|
}
|
|
existing = append(existing, page_attachments...)
|
|
if resp == nil || resp.NextPage == 0 {
|
|
break
|
|
}
|
|
page = resp.NextPage
|
|
}
|
|
|
|
for _, name := range ctx.Args().Slice()[1:] {
|
|
var attachment *gitea.Attachment
|
|
for _, a := range existing {
|
|
if a.Name == name {
|
|
attachment = a
|
|
}
|
|
}
|
|
if attachment == nil {
|
|
return fmt.Errorf("release does not have attachment named '%s'", name)
|
|
}
|
|
|
|
_, err = client.DeleteReleaseAttachment(ctx.Owner, ctx.Repo, release.ID, attachment.ID)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
}
|
|
|
|
return nil
|
|
}
|