mirror of
https://gitea.com/gitea/tea.git
synced 2026-04-25 17:53:37 +02:00
## Summary \`Page: -1\` in the Gitea SDK calls \`setDefaults()\` which sets both \`Page=0\` and \`PageSize=0\`, resulting in \`?page=0&limit=0\` being sent to the server. The server interprets \`limit=0\` as "use server default" (typically 30 items via \`DEFAULT_PAGING_NUM\`), not "return everything". Any resource beyond the first page of results was silently invisible. This affected 8 call sites, with the most user-visible impact being \`tea issues edit --add-labels\` and \`tea pulls edit --add-labels\` silently failing to apply labels on repositories with more than ~30 labels. ## Affected call sites | File | API call | User-visible impact | |---|---|---| | \`modules/task/labels.go\` | \`ListRepoLabels\` | \`issues/pulls edit --add-labels\` fails silently | | \`modules/interact/issue_create.go\` | \`ListRepoLabels\` | interactive label picker missing labels | | \`modules/task/pull_review_comment.go\` | \`ListPullReviews\` | review comments truncated | | \`modules/task/login_ssh.go\` | \`ListMyPublicKeys\` | SSH key auto-detection fails | | \`modules/task/login_create.go\` | \`ListAccessTokens\` | token name deduplication misses existing tokens | | \`cmd/pulls.go\` | \`ListPullReviews\` | PR detail view missing reviews | | \`cmd/releases/utils.go\` | \`ListReleases\` | tag lookup fails on repos with many releases | | \`cmd/attachments/delete.go\` | \`ListReleaseAttachments\` | attachment deletion fails when many attachments exist | ## Fix Each call site is replaced with an explicit pagination loop that follows \`resp.NextPage\` until all pages are exhausted. Reviewed-on: https://gitea.com/gitea/tea/pulls/967 Reviewed-by: Lunny Xiao <xiaolunwen@gmail.com> Co-authored-by: Alain Thiffault <athiffau@effectivemomentum.com> Co-committed-by: Alain Thiffault <athiffau@effectivemomentum.com>
92 lines
2.1 KiB
Go
92 lines
2.1 KiB
Go
// Copyright 2020 The Gitea Authors. All rights reserved.
|
|
// SPDX-License-Identifier: MIT
|
|
|
|
package task
|
|
|
|
import (
|
|
"encoding/base64"
|
|
"os"
|
|
"path/filepath"
|
|
"strings"
|
|
|
|
"code.gitea.io/tea/modules/utils"
|
|
|
|
"code.gitea.io/sdk/gitea"
|
|
"golang.org/x/crypto/ssh"
|
|
)
|
|
|
|
// findSSHKey retrieves the ssh keys registered in gitea, and tries to find
|
|
// a matching private key in ~/.ssh/. If no match is found, path is empty.
|
|
func findSSHKey(client *gitea.Client) (string, error) {
|
|
// get keys registered on gitea instance
|
|
var keys []*gitea.PublicKey
|
|
for page := 1; ; {
|
|
page_keys, resp, err := client.ListMyPublicKeys(gitea.ListPublicKeysOptions{
|
|
ListOptions: gitea.ListOptions{Page: page, PageSize: 50},
|
|
})
|
|
if err != nil {
|
|
return "", err
|
|
}
|
|
keys = append(keys, page_keys...)
|
|
if resp == nil || resp.NextPage == 0 {
|
|
break
|
|
}
|
|
page = resp.NextPage
|
|
}
|
|
if len(keys) == 0 {
|
|
return "", nil
|
|
}
|
|
|
|
// enumerate ~/.ssh/*.pub files
|
|
glob, err := utils.AbsPathWithExpansion("~/.ssh/*.pub")
|
|
if err != nil {
|
|
return "", err
|
|
}
|
|
localPubkeyPaths, err := filepath.Glob(glob)
|
|
if err != nil {
|
|
return "", err
|
|
}
|
|
|
|
// parse each local key with present privkey & compare fingerprints to online keys
|
|
for _, pubkeyPath := range localPubkeyPaths {
|
|
var pubkeyFile []byte
|
|
pubkeyFile, err = os.ReadFile(pubkeyPath)
|
|
if err != nil {
|
|
continue
|
|
}
|
|
fields := strings.Split(string(pubkeyFile), " ")
|
|
if len(fields) < 2 { // first word is key type, second word is key material
|
|
continue
|
|
}
|
|
|
|
var keymaterial []byte
|
|
keymaterial, err = base64.StdEncoding.DecodeString(fields[1])
|
|
if err != nil {
|
|
continue
|
|
}
|
|
|
|
var pubkey ssh.PublicKey
|
|
pubkey, err = ssh.ParsePublicKey(keymaterial)
|
|
if err != nil {
|
|
continue
|
|
}
|
|
|
|
privkeyPath := strings.TrimSuffix(pubkeyPath, ".pub")
|
|
var exists bool
|
|
exists, err = utils.FileExist(privkeyPath)
|
|
if err != nil || !exists {
|
|
continue
|
|
}
|
|
|
|
// if pubkey fingerprints match, return path to corresponding privkey.
|
|
fingerprint := ssh.FingerprintSHA256(pubkey)
|
|
for _, key := range keys {
|
|
if fingerprint == key.Fingerprint {
|
|
return privkeyPath, nil
|
|
}
|
|
}
|
|
}
|
|
|
|
return "", err
|
|
}
|