Files
gitea-tea/internal/services/branches_test.go
T
bircni 02cf01093f feat(branch): branch from tags and commits, protect with explicit rules
branch create --source v1.0.0 (or a commit) failed with "The old branch
does not exist" because only old_branch_name was sent; the request now
sends old_ref_name, through a raw call until the SDK has the field.

branch protect nope exited 0 and created a rule for a missing branch,
and protecting twice failed with "permission denied". Branches must now
exist (--pattern protects a glob instead), an existing rule warns
"! main is already protected", and unprotecting an unprotected branch
warns instead of failing. The rule is explained in help and set with
--required-approvals, --allow-push, --status-check,
--block-on-rejected-reviews and --dismiss-stale-approvals.

branch list shows NAME (marking the default branch), COMMIT, PROTECTED,
UPDATED and MESSAGE, branch view is a full view with --web, branch
delete takes several branches, and every change reports a ✓ line.

Signed-off-by: bircni <bircni@icloud.com>
2026-10-11 23:52:02 +02:00

109 lines
4.5 KiB
Go

// Copyright 2026 The Gitea Authors. All rights reserved.
// SPDX-License-Identifier: MIT
package services
import (
"context"
"encoding/json"
"net/http"
"testing"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
)
func TestBranchRenameEscapesNames(t *testing.T) {
mutations := 0
client := newTestClient(t, http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
mutations++
assert.Equal(t, http.MethodPatch, r.Method)
assert.Equal(t, "/api/v1/repos/owner/repo/branches/feature/a%23b", r.URL.EscapedPath())
var payload map[string]string
assert.NoError(t, json.NewDecoder(r.Body).Decode(&payload))
assert.Equal(t, map[string]string{"name": "feature/renamed"}, payload)
w.WriteHeader(http.StatusNoContent)
}))
err := (Branches{Client: client}).Rename(context.Background(), "owner/repo", "feature/a#b", "feature/renamed")
require.NoError(t, err)
require.Equal(t, 1, mutations)
}
func TestBranchListMapsServerFields(t *testing.T) {
client := newTestClient(t, http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
assert.Equal(t, "/api/v1/repos/owner/repo/branches", r.URL.Path)
assert.Equal(t, "20", r.URL.Query().Get("limit"))
assert.Equal(t, "3", r.URL.Query().Get("page"))
_, _ = w.Write([]byte(`[{"name":"main","commit":{"id":"abc","message":"Fix\n\nbody","timestamp":"2026-10-01T12:00:00Z"},"protected":true,"required_approvals":2,"user_can_push":true,"user_can_merge":true},{"name":"orphan","commit":null}]`))
}))
items, err := (Branches{Client: client}).List(context.Background(), "owner/repo", 20, 3)
require.NoError(t, err)
require.Equal(t, []Branch{
{Name: "main", SHA: "abc", Message: "Fix\n\nbody", UpdatedAt: "2026-10-01T12:00:00Z", Protected: true, RequiredApprovals: 2, CanPush: true, CanMerge: true},
{Name: "orphan"},
}, items)
}
func TestBranchCreateAndProtectPayloads(t *testing.T) {
client := newTestClient(t, http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
payload := requestJSON(t, r)
switch r.URL.Path {
case "/api/v1/repos/owner/repo/branches":
assert.Equal(t, "feature", payload["new_branch_name"])
assert.Empty(t, payload["old_branch_name"])
w.WriteHeader(http.StatusCreated)
_, _ = w.Write([]byte(`{"name":"feature","commit":{"id":"abc"}}`))
case "/api/v1/repos/owner/repo/branch_protections":
assert.Equal(t, "main", payload["rule_name"])
assert.Equal(t, false, payload["enable_push"])
assert.EqualValues(t, 1, payload["required_approvals"])
w.WriteHeader(http.StatusCreated)
_, _ = w.Write([]byte(`{"rule_name":"main"}`))
default:
t.Errorf("unexpected request %s", r.URL.Path)
}
}))
service := Branches{Client: client}
item, err := service.Create(context.Background(), "owner/repo", "feature", "")
require.NoError(t, err)
require.Equal(t, Branch{Name: "feature", SHA: "abc"}, item)
created, err := service.Protect(context.Background(), "owner/repo", Protection{Rule: "main", RequiredApprovals: 1})
require.NoError(t, err)
require.True(t, created)
}
func TestBranchCreateFromATagOrCommitSendsOldRefName(t *testing.T) {
client := newTestClient(t, http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
assert.Equal(t, http.MethodPost+" /api/v1/repos/owner/repo/branches", r.Method+" "+r.URL.Path)
assert.Equal(t, map[string]any{"new_branch_name": "hotfix", "old_ref_name": "v1.0.0"}, requestJSON(t, r))
w.WriteHeader(http.StatusCreated)
_, _ = w.Write([]byte(`{"name":"hotfix","commit":{"id":"abc"}}`))
}))
item, err := (Branches{Client: client}).Create(context.Background(), "owner/repo", "hotfix", "v1.0.0")
require.NoError(t, err)
require.Equal(t, Branch{Name: "hotfix", SHA: "abc"}, item)
}
func TestBranchProtectionIsIdempotent(t *testing.T) {
client := newTestClient(t, http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
switch r.Method + " " + r.URL.Path {
case "POST /api/v1/repos/owner/repo/branch_protections":
w.WriteHeader(http.StatusForbidden)
_, _ = w.Write([]byte(`{"message":"Branch protection already exist"}`))
case "DELETE /api/v1/repos/owner/repo/branch_protections/main":
w.WriteHeader(http.StatusNotFound)
case "GET /api/v1/repos/owner/repo":
_, _ = w.Write([]byte(`{"full_name":"owner/repo"}`))
default:
t.Errorf("unexpected request %s %s", r.Method, r.URL.Path)
}
}))
service := Branches{Client: client}
created, err := service.Protect(context.Background(), "owner/repo", Protection{Rule: "main"})
require.NoError(t, err)
require.False(t, created)
removed, err := service.Unprotect(context.Background(), "owner/repo", "main")
require.NoError(t, err)
require.False(t, removed)
}