mirror of
https://gitea.com/gitea/tea.git
synced 2026-02-01 03:35:13 +01:00
7ab3366220
## Summary
Fix the `tea labels delete` and `tea labels update` commands which were silently ignoring the `--id` flag.
## Problem
Both commands used `IntFlag` for the `--id` parameter but called `ctx.Int64("id")` to retrieve the value. This type mismatch caused the ID to always be read as `0`, making the commands useless.
**Before (bug):**
```bash
$ tea labels delete --id 36 --debug
DELETE: .../labels/0 # Wrong! ID ignored
```
**After (fix):**
```bash
$ tea labels delete --id 36 --debug
GET: .../labels/36 # Verify exists
DELETE: .../labels/36 # Correct ID
Label 'my-label' (id: 36) deleted successfully
```
## Changes
### labels/delete.go
- Change `IntFlag` to `Int64Flag` to match `ctx.Int64()` usage
- Make `--id` flag required
- Verify label exists before attempting deletion
- Provide clear error messages with label name and ID context
- Print success message after deletion
### labels/update.go
- Change `IntFlag` to `Int64Flag` to fix the same bug
## Test plan
- [x] `go test ./...` passes
- [x] `go vet ./...` passes
- [x] `gofmt` check passes
- [x] Manual testing confirms ID is now correctly passed to API
- [ ] CI passes
Reviewed-on: https://gitea.com/gitea/tea/pulls/865
Reviewed-by: Lunny Xiao <xiaolunwen@gmail.com>
Co-authored-by: Alain Thiffault <athiffau@effectivemomentum.com>
Co-committed-by: Alain Thiffault <athiffau@effectivemomentum.com>
77 lines
1.5 KiB
Go
77 lines
1.5 KiB
Go
// Copyright 2020 The Gitea Authors. All rights reserved.
|
|
// SPDX-License-Identifier: MIT
|
|
|
|
package labels
|
|
|
|
import (
|
|
stdctx "context"
|
|
|
|
"code.gitea.io/tea/cmd/flags"
|
|
"code.gitea.io/tea/modules/context"
|
|
|
|
"code.gitea.io/sdk/gitea"
|
|
"github.com/urfave/cli/v3"
|
|
)
|
|
|
|
// CmdLabelUpdate represents a sub command of labels to update label.
|
|
var CmdLabelUpdate = cli.Command{
|
|
Name: "update",
|
|
Usage: "Update a label",
|
|
Description: `Update a label`,
|
|
ArgsUsage: " ", // command does not accept arguments
|
|
Action: runLabelUpdate,
|
|
Flags: append([]cli.Flag{
|
|
&cli.Int64Flag{
|
|
Name: "id",
|
|
Usage: "label id",
|
|
},
|
|
&cli.StringFlag{
|
|
Name: "name",
|
|
Usage: "label name",
|
|
},
|
|
&cli.StringFlag{
|
|
Name: "color",
|
|
Usage: "label color value",
|
|
},
|
|
&cli.StringFlag{
|
|
Name: "description",
|
|
Usage: "label description",
|
|
},
|
|
}, flags.AllDefaultFlags...),
|
|
}
|
|
|
|
func runLabelUpdate(_ stdctx.Context, cmd *cli.Command) error {
|
|
ctx := context.InitCommand(cmd)
|
|
ctx.Ensure(context.CtxRequirement{RemoteRepo: true})
|
|
|
|
id := ctx.Int64("id")
|
|
var pName, pColor, pDescription *string
|
|
name := ctx.String("name")
|
|
if name != "" {
|
|
pName = &name
|
|
}
|
|
|
|
color := ctx.String("color")
|
|
if color != "" {
|
|
pColor = &color
|
|
}
|
|
|
|
description := ctx.String("description")
|
|
if description != "" {
|
|
pDescription = &description
|
|
}
|
|
|
|
var err error
|
|
_, _, err = ctx.Login.Client().EditLabel(ctx.Owner, ctx.Repo, id, gitea.EditLabelOption{
|
|
Name: pName,
|
|
Color: pColor,
|
|
Description: pDescription,
|
|
})
|
|
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
return nil
|
|
}
|